Replace incorrect reference to sssd-krb5.conf manpage with the correct
sssd-krb5 in sssd_krb5_locator_plugin man page source.
---
src/man/sssd_krb5_locator_plugin.8.xml |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/man/sssd_krb5_locator_plugin.8.xml
Hi everyone,
I've been looking at the sssd sources for some test failure investigation and
noticed that the DEBUG macro expands to quite a lot of code. I decided to see
if it can be reduced and what the impact will be. The result is the patches
that follow.
I've noticed that the total size of
Remove extra fflush(3) invocation when outputting debug messages.
---
src/util/debug.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/util/debug.c b/src/util/debug.c
index c2e2571..9588083 100644
--- a/src/util/debug.c
+++ b/src/util/debug.c
@@ -104,10 +104,14 @@
On 10/10/2013 05:03 PM, Nikolai Kondrashov wrote:
I've been looking at the sssd sources for some test failure investigation and
noticed that the DEBUG macro expands to quite a lot of code. I decided to see
if it can be reduced and what the impact will be. The result is the patches
that follow
Add files cscope creates for inverted index (when running with -q) to
.gitignore. Inverted index enables faster symbol lookup.
---
.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index de6c573..25a197a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,6 +6,8
Move DEBUG macro body to the debug_fn function, adding function
argument to the latter.
Rename debug_fn in sssd_krb5_locator_plugin.c to plugin_debug_fn to
remove conflict with the sssd debug_fn.
Replace DEBUG_MSG macro usage with debug_fn function usage.
Remove DEBUG_MSG macro along with tests.
Hi Stephen,
On 10/10/2013 10:46 PM, Stephen Gallagher wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote:
Make DEBUG macro accept variable number of arguments, thus removing
the need to wrap the format string and its arguments into parens
On 10/10/2013 11:27 PM, Simo Sorce wrote:
On Thu, 2013-10-10 at 15:46 -0400, Stephen Gallagher wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote:
Make DEBUG macro accept variable number of arguments, thus removing
the need to wrap the format
Hi Stephen,
On 10/10/2013 10:42 PM, Stephen Gallagher wrote:
Replying
to myself.
I was able to get the mbox versions from patchworks and apply them
locally. I'm attaching the versions I created (tar.gz because patch 3
is 2MB).
Sorry to hear you had to do extra work. I replied within 1.5
On 10/11/2013 11:17 AM, Jakub Hrozek wrote:
Can you also send the next round of patches gzipped so that you don't
have to wait until they make it through moderation?
Sure, I will.
Although, IMHO, it makes it harder to respond to particular patches and
snippets and discuss effectively.
On 10/11/2013 11:23 AM, Nikolai Kondrashov wrote:
On 10/11/2013 11:17 AM, Jakub Hrozek wrote:
Can you also send the next round of patches gzipped so that you don't
have to wait until they make it through moderation?
Sure, I will.
Although, IMHO, it makes it harder to respond to particular
On 10/11/2013 11:25 AM, Nikolai Kondrashov wrote:
On 10/11/2013 11:23 AM, Nikolai Kondrashov wrote:
On 10/11/2013 11:17 AM, Jakub Hrozek wrote:
Can you also send the next round of patches gzipped so that you don't
have to wait until they make it through moderation?
Sure, I will.
Although
Hi Simo,
On 10/10/2013 11:25 PM, Simo Sorce wrote:
Hi Nikolai,
nice work.
Thanks :)
The code size reduction looks appealing, however please check the level
before calling the function, directly in the DEBUG() macro.
This way we completely avoid the function call when we are not going to
On 10/10/2013 11:29 PM, Simo Sorce wrote:
On Thu, 2013-10-10 at 16:25 -0400, Simo Sorce wrote:
The code size reduction looks appealing, however please check the
level
before calling the function, directly in the DEBUG() macro.
This way we completely avoid the function call when we are not going
On 10/15/2013 07:19 PM, Jakub Hrozek wrote:
On Fri, Oct 11, 2013 at 09:42:05AM -0400, Simo Sorce wrote:
Finally if everybody agree they want to make this huge change, *then* I
absolutely want to see each change also change debug numbers from
numbers to the new macros. It makes no sense
On 10/17/2013 12:16 PM, Nikolai Kondrashov wrote:
On 10/15/2013 07:19 PM, Jakub Hrozek wrote:
On Fri, Oct 11, 2013 at 09:42:05AM -0400, Simo Sorce wrote:
Finally if everybody agree they want to make this huge change, *then* I
absolutely want to see each change also change debug numbers from
Hi Stephen,
On 12/18/2013 07:55 PM, Stephen Gallagher wrote:
Nikolai, has there been any progress on this? I'd actually really like
to see these changes land, as they'll make my life easier as I work on
journald support for the debug logs.
What I'm looking for is mostly the variadic change (so
On 12/20/2013 09:43 PM, Stephen Gallagher wrote:
Actually, minor Nack on 0008:
#define DEBUG(level, format, ...) do { \
- -int __debug_macro_newlevel = debug_get_level(level); \
- -if (DEBUG_IS_SET(__debug_macro_newlevel)) \
- -debug_fn(__FUNCTION__, __debug_macro_newlevel,
Hi Stephen,
Thanks for the review! Replies below.
On 12/20/2013 09:31 PM, Stephen Gallagher wrote:
I'd rather that 0005 and 0006 be squashed together and that the comment
be written as follows:
{{{
Make DEBUG macro invocations variadic
Use a script to update DEBUG macro invocations to use it
On 12/23/2013 01:42 PM, Jakub Hrozek wrote:
On Sun, Dec 22, 2013 at 11:23:58AM +0200, Nikolai Kondrashov wrote:
1. There are 2273 uses of the old levels, *half* of all DEBUG macro
invocations, so updating them on occasion will take a *long* time.
2. Code is more often read
Hi Jakub,
Thanks a lot for reviewing!
On 01/07/2014 02:33 PM, Jakub Hrozek wrote:
I spoke about the same problem with Simo (or Stephen? Sorry, I forgot
over holidays) and it seems my opinion is in minority so I won't block
the patchset over it.
I have some very minor comments about the
On 01/07/2014 04:53 PM, Jakub Hrozek wrote:
On Tue, Jan 07, 2014 at 03:31:50PM +0200, Nikolai Kondrashov wrote:
On 01/07/2014 02:33 PM, Jakub Hrozek wrote:
[PATCH 3/8] Remove extra flushing from debug message output
The code is fine, but why is it a separate patch and not part of #2 ? It
seems
Hi Jakub,
On 01/13/2014 04:52 PM, Jakub Hrozek wrote:
These patches work for me. I had to rebase them on top of the current
master (sorry, I pushed Stef's patches before I checked the moderation
queue). Attached is a tarball with patches that include my
modifications, feel free to inspect it.
Hi everyone,
This is a trivial patch for https://bugzilla.redhat.com/show_bug.cgi?id=1043826
Sincerely,
Nick
From 8001e884391f1853964240b9e0e2ce71dc36138e Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov nikolai.kondras...@redhat.com
Date: Tue, 14 Jan 2014 14:15:32 +0200
Subject: [PATCH 1/1
Hi everyone,
Attached are several fixes for bashrc_sssd script.
Sincerely,
Nick
From b8cad9fb3ebda7be0b4b862a3601ebd6097c0200 Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov nikolai.kondras...@redhat.com
Date: Wed, 5 Feb 2014 17:54:17 +0100
Subject: [PATCH 1/3] Use HW instead of processor
this is necessary, but I'll think about it.
Sincerely,
Nick
From b8cad9fb3ebda7be0b4b862a3601ebd6097c0200 Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov nikolai.kondras...@redhat.com
Date: Wed, 5 Feb 2014 17:54:17 +0100
Subject: [PATCH 1/4] Use HW instead of processor name as build arch
Use machine
On 02/12/2014 04:38 PM, Stephen Gallagher wrote:
New patches attached. These should be the correct ones now. These
necessitated a rebase of my journald patches as well, so I'll send
those too.
Thanks a lot for taking care of rebasing, Stephen!
Sincerely,
Nick
On 02/12/2014 10:44 PM, Jakub Hrozek wrote:
Coverity found some errors which seem completely unrelated - code that
was prefixed by a comment saying we should never get here was marked as
dead code. I suspect that this is due to a new scanner version and dead
code is a soft error anyway, so I'm
On 02/12/2014 08:57 PM, Michal Židek wrote:
On 02/07/2014 02:12 PM, Nikolai Kondrashov wrote:
# them. This builds with optimizations turned off and GDB debugging symbols.
chmake()
{
-make V=0 CFLAGS+=-ggdb3 -O0 $SSS_WARNINGS ${SSS_WERROR-} \
+make V=0 CFLAGS=-ggdb3 -O0
On 02/13/2014 10:31 AM, Nikolai Kondrashov wrote:
On 02/12/2014 08:57 PM, Michal Židek wrote:
I do not think it is correct to remove the +, because it changes the
behaviour for some people.
Yes, I didn't think about environment variables, will fix. Thank you, Michal.
Please find fixed
Hi everyone,
I've thrown together a basic experimental setup of a continuous integration
(CI) system, and I'd like to gather feedback and ideas for further
development.
For now it is Jenkins with two slaves (Fedora 20 and RHEL 7) running on Brno
Lab VMs:
Hi everyone,
Please find attached removing the unused --with-distro-version configure
option.
Sincerely,
Nick
From c7391960ced0866fe1bd9b43d729224248ce4a47 Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov nikolai.kondras...@redhat.com
Date: Wed, 19 Mar 2014 12:57:42 +0200
Subject: [PATCH 1/1
Hi Lukas,
On 03/19/2014 04:21 PM, Lukas Slebodnik wrote:
On (19/03/14 14:59), Nikolai Kondrashov wrote:
Remove support for --with-distro-version configure option as unused.
The option was added in August 2011 (d3da1c1). As of now nothing seems
to use it. Packaging checked: rpm, deb, pacman
Hi everyone,
This fixes distcheck when configured with systemd, but without journald (e.g.
as done by Debian package), when journald library package is missing.
Sincerely,
Nick
From ce1f0d21ed9890d23f1a1a7dbf04cbcc5341a996 Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov nikolai.kondras
Hi everyone,
This fixes test-io execution with relative test dir.
Sincerely,
Nick
From 76b7d1ff6b1a4117a5e8917b29d8b2b916d1e439 Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov nikolai.kondras...@redhat.com
Date: Tue, 15 Apr 2014 19:08:34 +0300
Subject: [PATCH 1/1] tests: Don't assume absolute
On 04/15/2014 09:42 PM, Lukas Slebodnik wrote:
On (15/04/14 20:00), Nikolai Kondrashov wrote:
From 76b7d1ff6b1a4117a5e8917b29d8b2b916d1e439 Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov nikolai.kondras...@redhat.com
Date: Tue, 15 Apr 2014 19:08:34 +0300
Subject: [PATCH 1/1] tests: Don't
On 04/15/2014 10:38 PM, Lukas Slebodnik wrote:
On (15/04/14 17:47), Nikolai Kondrashov wrote:
Hi everyone,
This fixes distcheck when configured with systemd, but without journald (e.g.
as done by Debian package), when journald library package is missing.
This is because debian has separate
On 04/16/2014 02:22 PM, Nikolai Kondrashov wrote:
On 04/15/2014 09:42 PM, Lukas Slebodnik wrote:
On (15/04/14 20:00), Nikolai Kondrashov wrote:
From 76b7d1ff6b1a4117a5e8917b29d8b2b916d1e439 Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov nikolai.kondras...@redhat.com
Date: Tue, 15 Apr 2014
On 04/16/2014 03:00 PM, Jakub Hrozek wrote:
On Wed, Apr 16, 2014 at 02:39:06PM +0300, Nikolai Kondrashov wrote:
Sorry, I felt a bit upset about This patch is useless. I understand that my
patch probably didn't explain enough. However, saying this is unclear, please
elaborate would have been
On 04/16/2014 02:50 PM, Lukas Slebodnik wrote:
If configure is run without argument --with-test-dir test will pass
If configure is run with argument --with-test-dir=/tmp/dir test will pass
result: This patch is useless
The test will fail if you run it with --with-test-dir=test-dir.
I can
On 04/16/2014 03:39 PM, Lukas Slebodnik wrote:
On (16/04/14 14:38), Lukas Slebodnik wrote:
On (16/04/14 15:26), Nikolai Kondrashov wrote:
On 04/16/2014 03:00 PM, Jakub Hrozek wrote:
On Wed, Apr 16, 2014 at 02:39:06PM +0300, Nikolai Kondrashov wrote:
Sorry, I felt a bit upset about This patch
On 04/16/2014 04:03 PM, Lukas Slebodnik wrote:
Agreed.
However, the problem lies entirely in the test, and I'm trying to solve it.
The test first changes into TEST_DIR, then tries to open TEST_DIR.
This wouldn't work with a relative path such as test-dir, as there is not
likely to be test-dir
On 04/16/2014 03:38 PM, Lukas Slebodnik wrote:
On (16/04/14 15:26), Nikolai Kondrashov wrote:
On 04/16/2014 03:00 PM, Jakub Hrozek wrote:
On Wed, Apr 16, 2014 at 02:39:06PM +0300, Nikolai Kondrashov wrote:
Sorry, I felt a bit upset about This patch is useless. I understand that my
patch
On 04/16/2014 05:44 PM, Lukas Slebodnik wrote:
On (16/04/14 16:21), Nikolai Kondrashov wrote:
On 04/16/2014 04:03 PM, Lukas Slebodnik wrote:
Agreed.
However, the problem lies entirely in the test, and I'm trying to solve it.
The test first changes into TEST_DIR, then tries to open TEST_DIR
On 04/16/2014 02:24 PM, Nikolai Kondrashov wrote:
your patch reminds me another issue in Makefile.am
Use the same ifdef around:
systemdconf_DATA += \
src/sysv/systemd/journal.conf
Because it does not make sense to install this file if sssd was not configured
with journald.
Yes
On 04/16/2014 06:27 PM, Lukas Slebodnik wrote:
On (16/04/14 17:54), Nikolai Kondrashov wrote:
On 04/16/2014 05:44 PM, Lukas Slebodnik wrote:
On (16/04/14 16:21), Nikolai Kondrashov wrote:
On 04/16/2014 04:03 PM, Lukas Slebodnik wrote:
Agreed.
However, the problem lies entirely in the test
Hi Lukas,
A slightly more complete answer to your last message.
On 04/16/2014 05:44 PM, Lukas Slebodnik wrote:
On (16/04/14 16:21), Nikolai Kondrashov wrote:
On 04/16/2014 04:03 PM, Lukas Slebodnik wrote:
It works if $TEST_DIR is created.
Not always. Not when the path is relative
On 04/17/2014 02:29 AM, Lukas Slebodnik wrote:
It does not make sense to argue.
test-io was not ideal unit test and adding another workaroud(fix/hack) is not
good. I could sleep, but ...
Patch is attached.
Thanks, Lukas. This fixes my problem.
Sincerely,
Nick
Hi everyone,
This will let us skip running Python tests under Valgrind, as they produce too
many interpreter-specific errors, which are hard to suppress.
Sincerely,
Nick
From 4ab362aecba7614d95dc92f423f6d66a03d9cb52 Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov nikolai.kondras...@redhat.com
Hi Jakub,
On 04/22/2014 06:28 PM, Jakub Hrozek wrote:
On Fri, Apr 18, 2014 at 03:18:29PM +0300, Nikolai Kondrashov wrote:
Hi everyone,
This will let us skip running Python tests under Valgrind, as they produce too
many interpreter-specific errors, which are hard to suppress.
Sincerely,
Nick
On 04/29/2014 05:09 PM, Jakub Hrozek wrote:
On Tue, Apr 29, 2014 at 03:53:37PM +0200, Sumit Bose wrote:
On Tue, Apr 29, 2014 at 03:45:36PM +0200, Pavel Březina wrote:
On 04/29/2014 03:24 PM, Jakub Hrozek wrote:
Hi,
we've been keeping the sssd-1-11 branch fairly conservative recently,
mostly
On 04/30/2014 06:29 PM, Nikolai Kondrashov wrote:
On 04/29/2014 05:09 PM, Jakub Hrozek wrote:
Nikolai, do you have time to do the backport before you leave for
vacation or would you like some help?
I'll send the first version of the backported patches later today.
Jakub, could you please
On 04/30/2014 11:02 PM, Lukas Slebodnik wrote:
I realised that sssd cannot be built after applying the 5th and the 6th patch.
0005-Make-DEBUG-macro-definition-variadic.patch
0006-Make-DEBUG-macro-invocations-variadic.patch
It is fixed by the 7th patch.
On 04/30/2014 11:39 PM, Nikolai Kondrashov wrote:
On 04/30/2014 11:02 PM, Lukas Slebodnik wrote:
I realised that sssd cannot be built after applying the 5th and the 6th patch.
0005-Make-DEBUG-macro-definition-variadic.patch
0006-Make-DEBUG-macro-invocations-variadic.patch
It is fixed by the 7th
On 05/05/2014 10:36 PM, Lukas Slebodnik wrote:
On (01/05/14 00:51), Nikolai Kondrashov wrote:
One thing, though: having the script-generated patches separate certainly made
cherry-picking easier and faster.
The patches were pushed, so we can continue with this discussion.
The only way how
On 05/09/2014 10:00 PM, Lukas Slebodnik wrote:
On (09/05/14 15:09), Nikolai Kondrashov wrote:
On 05/05/2014 10:36 PM, Lukas Slebodnik wrote:
On (01/05/14 00:51), Nikolai Kondrashov wrote:
One thing, though: having the script-generated patches separate certainly made
cherry-picking easier
On 04/17/2014 01:13 PM, Lukas Slebodnik wrote:
On (17/04/14 10:44), Jakub Hrozek wrote:
On Thu, Apr 17, 2014 at 11:06:16AM +0300, Nikolai Kondrashov wrote:
On 04/17/2014 02:29 AM, Lukas Slebodnik wrote:
It does not make sense to argue.
test-io was not ideal unit test and adding another
On 05/16/2014 11:32 PM, Lukas Slebodnik wrote:
On (16/04/14 21:30), Nikolai Kondrashov wrote:
In my case there is no beneficial performance difference when running with
valgrind. There is about 25% improvement using /dev/shm when running with
coverage enabled, but even in a VM it takes less
On 05/19/2014 10:33 AM, Lukas Slebodnik wrote:
On (17/05/14 01:14), Nikolai Kondrashov wrote:
On 05/16/2014 11:32 PM, Lukas Slebodnik wrote:
On (16/04/14 21:30), Nikolai Kondrashov wrote:
In my case there is no beneficial performance difference when running with
valgrind. There is about 25
On 05/19/2014 05:55 PM, Nikolai Kondrashov wrote:
On 05/19/2014 10:33 AM, Lukas Slebodnik wrote:
On (17/05/14 01:14), Nikolai Kondrashov wrote:
On 05/16/2014 11:32 PM, Lukas Slebodnik wrote:
On (16/04/14 21:30), Nikolai Kondrashov wrote:
In my case there is no beneficial performance
On 05/19/2014 07:40 PM, Lukas Slebodnik wrote:
On (19/05/14 18:15), Nikolai Kondrashov wrote:
Could you perhaps try timing the command running all tests under Valgrind,
which I mentioned in the previous message, if time allows?
Sure,
//parallel
sh-4.2$ time make -j4 check LOG_COMPILER=libtool
On 05/20/2014 11:52 AM, Lukas Slebodnik wrote:
On (19/05/14 20:34), Nikolai Kondrashov wrote:
On 05/19/2014 07:40 PM, Lukas Slebodnik wrote:
On (19/05/14 18:15), Nikolai Kondrashov wrote:
Could you perhaps try timing the command running all tests under Valgrind,
which I mentioned
On 05/21/2014 01:20 PM, Nikolai Kondrashov wrote:
On 05/19/2014 08:34 PM, Nikolai Kondrashov wrote:
Yes, I managed not to notice this before, behind other errors, but I get these
too. It seems it is reall a Valgrind issue. I.e. it doesn't seem to make sense
to apply --error-exitcode to child
On 05/23/2014 12:49 PM, Jakub Hrozek wrote:
On Fri, May 23, 2014 at 12:39:55PM +0300, Nikolai Kondrashov wrote:
On 05/21/2014 01:20 PM, Nikolai Kondrashov wrote:
On 05/19/2014 08:34 PM, Nikolai Kondrashov wrote:
Yes, I managed not to notice this before, behind other errors, but I get
On 05/23/2014 01:00 PM, Nikolai Kondrashov wrote:
On 05/23/2014 12:49 PM, Jakub Hrozek wrote:
On Fri, May 23, 2014 at 12:39:55PM +0300, Nikolai Kondrashov wrote:
On 05/21/2014 01:20 PM, Nikolai Kondrashov wrote:
On 05/19/2014 08:34 PM, Nikolai Kondrashov wrote:
Yes, I managed not to notice
On 05/23/2014 12:39 PM, Nikolai Kondrashov wrote:
On 05/21/2014 01:20 PM, Nikolai Kondrashov wrote:
On 05/19/2014 08:34 PM, Nikolai Kondrashov wrote:
Yes, I managed not to notice this before, behind other errors, but I get these
too. It seems it is reall a Valgrind issue. I.e. it doesn't seem
On 05/26/2014 04:51 PM, Lukas Slebodnik wrote:
On (21/05/14 13:30), Nikolai Kondrashov wrote:
Use AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am instead of
DISTCHECK_CONFIGURE_FLAGS to allow using the latter at build time,
upon making distcheck target.
In particular, the above would allow
On 05/31/2014 04:45 AM, Dmitri Pal wrote:
I reworked the design based on the feedback provided.
It is a completely rewritten version.
Please take a look.
https://fedorahosted.org/sssd/wiki/DesignDocs/ding-libs/INIConfigMerge
I'm likely awfully under-informed (I haven't seen any prior
2001
From: Nikolai Kondrashov nikolai.kondras...@redhat.com
Date: Tue, 25 Mar 2014 12:01:00 +0200
Subject: [PATCH 1/1] Add basic support for CI test execution
Add basic support for executing continuous integration (CI) tests on
RHEL7, Fedora 20 and Debian Testing.
This adds two front-end scripts
Hi Lukas,
On 06/11/2014 10:52 AM, Lukas Slebodnik wrote:
[1]
http://sssd-ci.idm.lab.eng.brq.redhat.com:8080/job/new_private_master_fedora20/214/console
The host is not accesible. It should not be in commit message.
$ ping sssd-ci.idm.lab.eng.brq.redhat.com
ping: unknown host
On 06/11/2014 03:46 PM, Lukas Slebodnik wrote:
On (11/06/14 14:52), Nikolai Kondrashov wrote:
On 06/11/2014 10:52 AM, Lukas Slebodnik wrote:
I would like to avoind maintain two different lists with build dependency for
fedora/rhel based OSes. We already have listed all build dependencies
On 06/11/2014 05:28 PM, Nikolai Kondrashov wrote:
A package missing from CI dependencies would be immediately obvious as CI
builds would fail and it would be easy to then update the lists.
RPM dependencies are subset of CI dependencies.
you can install CI dependencies with yum install and sssd
On 06/11/2014 05:54 PM, Pavel Reichl wrote:
On Wed, 2014-06-11 at 17:28 +0300, Nikolai Kondrashov wrote:
Sure, there are various ways to make Valgrind happy, although none of them are
very easy. The important thing is that we would have a way to track it now.
This way, or another we should
On 06/11/2014 06:19 PM, Lukas Slebodnik wrote:
On (11/06/14 17:28), Nikolai Kondrashov wrote:
It will expand macros, which can include Lua scripts, and those can do
basically anything. See http://www.rpm.org/wiki/PackagerDocs/RpmLua
Try putting %{lua: os.execute('echo Hello, world
On 06/11/2014 08:14 PM, Pavel Reichl wrote:
On Wed, 2014-06-11 at 19:34 +0300, Nikolai Kondrashov wrote:
On 06/11/2014 05:54 PM, Pavel Reichl wrote:
On Wed, 2014-06-11 at 17:28 +0300, Nikolai Kondrashov wrote:
Sure, there are various ways to make Valgrind happy, although none of them
On 06/11/2014 05:28 PM, Nikolai Kondrashov wrote:
On 06/11/2014 03:46 PM, Lukas Slebodnik wrote:
On (11/06/14 14:52), Nikolai Kondrashov wrote:
On 06/11/2014 10:52 AM, Lukas Slebodnik wrote:
+declare -r DEBUG_CFLAGS=-O0 -g3
In my opinion, sssd should be built without optimisation only
On 06/11/2014 05:28 PM, Nikolai Kondrashov wrote:
On 06/11/2014 03:46 PM, Lukas Slebodnik wrote:
On (11/06/14 14:52), Nikolai Kondrashov wrote:
On 06/11/2014 10:52 AM, Lukas Slebodnik wrote:
I would prefer to split this function into two parts.
* running static analyser
* code
On 06/13/2014 10:43 AM, Lukas Slebodnik wrote:
On (12/06/14 22:53), Nikolai Kondrashov wrote:
On 06/11/2014 05:28 PM, Nikolai Kondrashov wrote:
On 06/11/2014 03:46 PM, Lukas Slebodnik wrote:
On (11/06/14 14:52), Nikolai Kondrashov wrote:
On 06/11/2014 10:52 AM, Lukas Slebodnik wrote:
I
On 06/13/2014 02:00 PM, Lukas Slebodnik wrote:
On (13/06/14 13:40), Nikolai Kondrashov wrote:
On 06/13/2014 10:48 AM, Lukas Slebodnik wrote:
On (11/06/14 17:29), Nikolai Kondrashov wrote:
On 06/11/2014 05:28 PM, Nikolai Kondrashov wrote:
A package missing from CI dependencies would
On 06/13/2014 03:14 PM, Lukas Slebodnik wrote:
On (13/06/14 14:50), Nikolai Kondrashov wrote:
On 06/13/2014 02:00 PM, Lukas Slebodnik wrote:
On (13/06/14 13:40), Nikolai Kondrashov wrote:
However, the fact that someone (who has different situation) does something,
doesn't mean that it's
On 06/13/2014 06:52 PM, Lukas Slebodnik wrote:
On (13/06/14 16:50), Lukas Slebodnik wrote:
On (13/06/14 16:49), Nikolai Kondrashov wrote:
On 06/13/2014 03:14 PM, Lukas Slebodnik wrote:
On (13/06/14 14:50), Nikolai Kondrashov wrote:
On 06/13/2014 02:00 PM, Lukas Slebodnik wrote:
On (13/06/14
On 06/13/2014 05:50 PM, Lukas Slebodnik wrote:
On (13/06/14 16:49), Nikolai Kondrashov wrote:
On 06/13/2014 03:14 PM, Lukas Slebodnik wrote:
On (13/06/14 14:50), Nikolai Kondrashov wrote:
CI runs configure anyway, so make srpm would be better as it's slightly more
reliable compared
On 06/13/2014 08:51 PM, Nikolai Kondrashov wrote:
On 06/13/2014 05:50 PM, Lukas Slebodnik wrote:
Or do you want to start new clean VM every time?
It would be overkill from my POV.
As I understand it, the ultimate plan decided by the management is to use
OpenStack or some such to provision
Sorry, I lost the whole day to this thread already and am quite tired, so my
answers will be brief.
On 06/13/2014 09:58 PM, Lukas Slebodnik wrote:
On (13/06/14 20:51), Nikolai Kondrashov wrote:
On 06/13/2014 05:50 PM, Lukas Slebodnik wrote:
On (13/06/14 16:49), Nikolai Kondrashov wrote
On 06/13/2014 10:28 PM, Lukas Slebodnik wrote:
On (13/06/14 20:27), Nikolai Kondrashov wrote:
On 06/13/2014 06:52 PM, Lukas Slebodnik wrote:
On (13/06/14 16:50), Lukas Slebodnik wrote:
On (13/06/14 16:49), Nikolai Kondrashov wrote:
On 06/13/2014 03:14 PM, Lukas Slebodnik wrote:
On (13/06/14
On 06/14/2014 12:56 AM, Lukas Slebodnik wrote:
On (13/06/14 23:26), Nikolai Kondrashov wrote:
On 06/13/2014 10:28 PM, Lukas Slebodnik wrote:
Let's summarize.
Sure, it was satisfying deleting that much quotation :)
I don't like maintaing build dependecies in two different palaces
and you
Hi Lukas,
I've removed most of the discussion since we agreed to seek compromise on
dependencies and my answer below removes the need to discuss the rest.
On 06/14/2014 01:21 AM, Lukas Slebodnik wrote:
I don't want to complicate the current script further by inventing something
else above two
On 06/14/2014 11:47 AM, Lukas Slebodnik wrote:
On (14/06/14 10:59), Nikolai Kondrashov wrote:
Hi Lukas,
I've removed most of the discussion since we agreed to seek compromise on
dependencies and my answer below removes the need to discuss the rest.
On 06/14/2014 01:21 AM, Lukas Slebodnik
On 06/14/2014 11:55 AM, Lukas Slebodnik wrote:
On (14/06/14 10:47), Nikolai Kondrashov wrote:
On 06/14/2014 12:56 AM, Lukas Slebodnik wrote:
On (13/06/14 23:26), Nikolai Kondrashov wrote:
On 06/13/2014 10:28 PM, Lukas Slebodnik wrote:
Let's summarize.
Sure, it was satisfying deleting
On 06/16/2014 04:29 PM, Lukas Slebodnik wrote:
On (14/06/14 12:01), Nikolai Kondrashov wrote:
I'll provide a way to choose what set of tests (full/essential) to run and
whether it should be run on all or just the last commit, upon submission.
You will need to modify script anyway to address
Hi everyone,
Attached are several patches fixing RHEL6 build issues.
Nick
From adfb7725d982fed7cbd4ecefebd1128d244a0c85 Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov nikolai.kondras...@redhat.com
Date: Mon, 16 Jun 2014 19:39:25 +0300
Subject: [PATCH 1/3] build: Switch back
On 06/17/2014 05:23 PM, Lukas Slebodnik wrote:
On (17/06/14 15:09), Nikolai Kondrashov wrote:
+DISTCHECK_CONFIGURE_FLAGS = --with-ldb-lib-dir=$$dc_install_base/lib/ldb \
+--disable-dbus-tests \
+--enable-all-experimental-features
On 06/11/2014 02:52 PM, Nikolai Kondrashov wrote:
On 06/11/2014 10:52 AM, Lukas Slebodnik wrote:
+if [ `xqilla -i \\$f\ /dev/stdin \
Could you use xmllint instead of xqilla.
We need xmllint for building manual pages. I didn't try it, but here is the 2nd
link from quick
On 06/18/2014 01:39 PM, Lukas Slebodnik wrote:
On (17/06/14 18:50), Nikolai Kondrashov wrote:
On 06/17/2014 05:23 PM, Lukas Slebodnik wrote:
On (17/06/14 15:09), Nikolai Kondrashov wrote:
I would like to avoid that, if possible, as it would complicate the CI script.
I will give you some
On 06/18/2014 10:58 AM, Lukas Slebodnik wrote:
On (17/06/14 20:24), Nikolai Kondrashov wrote:
On 06/11/2014 02:52 PM, Nikolai Kondrashov wrote:
On 06/11/2014 10:52 AM, Lukas Slebodnik wrote:
+if [ `xqilla -i \\$f\ /dev/stdin \
Could you use xmllint instead of xqilla.
We
On 06/18/2014 02:45 PM, Lukas Slebodnik wrote:
On (18/06/14 14:33), Nikolai Kondrashov wrote:
On 06/18/2014 10:58 AM, Lukas Slebodnik wrote:
On (17/06/14 20:24), Nikolai Kondrashov wrote:
On 06/11/2014 02:52 PM, Nikolai Kondrashov wrote:
On 06/11/2014 10:52 AM, Lukas Slebodnik wrote
On 06/17/2014 03:09 PM, Nikolai Kondrashov wrote:
Attached are several patches fixing RHEL6 build issues.
Please find attached version 2.
It has the build: Propagate CIFS plugin status to distcheck patch removed
and build: Switch back to DISTCHECK_CONFIGURE_FLAGS using
On 06/19/2014 06:57 PM, Jakub Hrozek wrote:
On Thu, Jun 19, 2014 at 08:53:44AM +0200, Lukas Slebodnik wrote:
ACK
LS
master:
* 5377441d7a846461c2d9a7a870cea711360a529a
* c6e39e15178675d0779e0ae855245774a09b4eb5
Nick, if you'd like the patches be pushed to sssd-1-11, too (I think
On 06/19/2014 07:33 PM, Jakub Hrozek wrote:
On Thu, Jun 19, 2014 at 07:29:06PM +0300, Nikolai Kondrashov wrote:
On 06/19/2014 06:57 PM, Jakub Hrozek wrote:
On Thu, Jun 19, 2014 at 08:53:44AM +0200, Lukas Slebodnik wrote:
ACK
LS
master:
* 5377441d7a846461c2d9a7a870cea711360a529a
Hi everyone,
Here is the cherry-pick of build: Switch back to DISTCHECK_CONFIGURE_FLAGS
to sssd-1-11.
Nick
From a8d7d75cb286b82ee5ab15effe5380f100c6b857 Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov nikolai.kondras...@redhat.com
Date: Mon, 16 Jun 2014 19:39:25 +0300
Subject: [PATCH 1/1
1 - 100 of 475 matches
Mail list logo
