[SSSD] [sssd PR#62][-Changes requested] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#30][+Pushed] sssctl: use systemd D-Bus API

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API jhrozek commented: """ * master: 03713a6..761515e """ See the full comment at https://github.com/SSSD/sssd/pull/30#issuecomment-252905006 _

[SSSD] [sssd PR#30][closed] sssctl: use systemd D-Bus API

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Author: pbrezina Title: #30: sssctl: use systemd D-Bus API Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/30/head:pr30 git checkout pr30

[SSSD] [sssd PR#30][-Accepted] sssctl: use systemd D-Bus API

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#45][closed] tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/45 Author: jhrozek Title: #45: tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/45/head:pr45 git

[SSSD] [sssd PR#45][+Pushed] tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/45 Title: #45: tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#45][comment] tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/45 Title: #45: tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME jhrozek commented: """ * master: * eb9bc1c590b8c3b3b58574c70d9fe5357ef3e901 * 03713a6444fdecd01465b9d5fbfead9601adce6e """

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ Well, it's still a lot of code :) but at least I started the review now. For starters, Coverity found some warnings: ``` Error: FORWARD_NULL (CWE-476): sssd-1.14.

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API jhrozek commented: """ On Mon, Oct 10, 2016 at 03:04:35AM -0700, Pavel Březina wrote: > Hi, your patch looks good to me. There was no specific reason, see > https://github.com/SSSD/sssd

[SSSD] [sssd PR#30][+Accepted] sssctl: use systemd D-Bus API

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#30][-Changes requested] sssctl: use systemd D-Bus API

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#47][opened] BUILD: Fix build without /sbin/service installed on the build host

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: opened PR body: """ There were some issues in the sssctl-related patches that we pushed recently. First, the build failed if no

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-10-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed jhrozek commented: """ So I wanted to write a test for the memberof patch, but I couldn't reproduce the ticket #2940 even without the memberof patch. I tried ex

[SSSD] [sssd PR#44][comment] libwbclient-sssd: update interface to version 0.13

2016-10-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/44 Title: #44: libwbclient-sssd: update interface to version 0.13 jhrozek commented: """ btw what the library exports also looks good to me: ``` objdump -T /usr/lib64/sssd/modules/libwbclient.so.0.13.0 | grep WBCLIENT_0.13 5e7

[SSSD] [sssd PR#47][comment] BUILD: Fix build without /sbin/service installed on the build host

2016-10-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host jhrozek commented: """ Apparently our CI, see the master build status :). And I guess especially Debian-based systems or other distributions might rely on t

[SSSD] [sssd PR#49][opened] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Author: jhrozek Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Action: opened PR body: """ This is a proposed way of solving https://fedorahosted.org/sssd/ticket/3199. It

[SSSD] [sssd PR#44][comment] libwbclient-sssd: update interface to version 0.13

2016-10-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/44 Title: #44: libwbclient-sssd: update interface to version 0.13 jhrozek commented: """ On Thu, Oct 13, 2016 at 02:35:57AM -0700, fidencio wrote: > Okay, please, fire our CI and feel free to push the patches after CI passes. Unfortunat

[SSSD] [sssd PR#47][synchronized] BUILD: Fix build without /sbin/service installed on the build host

2016-10-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47

[SSSD] [sssd PR#30][+Changes requested] sssctl: use systemd D-Bus API

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#35][comment] sss_cache: improve option argument handling

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/35 Title: #35: sss_cache: improve option argument handling jhrozek commented: """ master: 1330390c698ca0802200725df43356557aa633a2 """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#35][closed] sss_cache: improve option argument handling

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/35 Author: justin-stephenson Title: #35: sss_cache: improve option argument handling Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/35/head:pr35 git checkout pr35

[SSSD] [sssd PR#35][-Accepted] sss_cache: improve option argument handling

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/35 Title: #35: sss_cache: improve option argument handling Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#35][+Pushed] sss_cache: improve option argument handling

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/35 Title: #35: sss_cache: improve option argument handling Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#31][comment] nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/31 Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME jhrozek commented: """ * master: dcdf292567d50e5cc527766c1944dcf6a8ecacc5 """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#31][comment] nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/31 Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME jhrozek commented: """ On Mon, Oct 10, 2016 at 01:07:12AM -0700, sumit-bose wrote: > On Fri, Oct 07, 2016 at 08:21:21AM -0700, Jakub Hrozek wrote: >

[SSSD] [sssd PR#31][+Accepted] nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/31 Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API jhrozek commented: """ Thanks, this looks good, but I wonder if we could really just detect the service command (I know we talked about it and then decided not to..but I forgot why). See for

[SSSD] [sssd PR#31][-Accepted] nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/31 Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#31][closed] nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/31 Author: sumit-bose Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/31/head:pr31 git checkout pr31

[SSSD] [sssd PR#31][+Pushed] nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/31 Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#45][opened] tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/45 Author: jhrozek Title: #45: tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME Action: opened PR body: """ This is what I used to test recent Sumit's patches for ticket #3194. """ To

[SSSD] [sssd PR#45][synchronized] tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/45 Author: jhrozek Title: #45: tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/45/head:pr45 git

[SSSD] [sssd PR#46][comment] sss_client: Defer thread cancellation until completion of nss/pam operations

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/46 Title: #46: sss_client: Defer thread cancellation until completion of nss/pam operations jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-17 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization jhrozek commented: """ I don't know how to unstuck this PR except providing some ideas * SSS_TOOL_FLAG_NOCONF * SSS_TOOL_FLAG_STATIC * SSS_TOOL_FLAG_CONFPARSE_FALSE "&quo

[SSSD] [sssd PR#13][+Pushed] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed jhrozek commented: """ master: e0903f41922721edf292a9f7e6605a4519db53a1 eaf44bc07dda469a20be07d46737d93f518e2047 """ See the full comment at https:

[SSSD] [sssd PR#13][closed] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Author: celestian Title: #13: MEMBEROF: Don't resolve members if they are removed Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/13/head:pr13 git checkout pr13

[SSSD] [sssd PR#13][-Accepted] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#103][comment] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/103 Title: #103: sudo: do not store usn if no rules are found jhrozek commented: """ ACK, thanks for the patch. I will push it once full CI finishes. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#103][+Accepted] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/103 Title: #103: sudo: do not store usn if no rules are found Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#105][comment] RESPONDER: Remove dead assignment to the variable ret

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/105 Title: #105: RESPONDER: Remove dead assignment to the variable ret jhrozek commented: """ * master: 3d5bf48ac5b8b807facbfda225cdebff2f685cb8 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#105][closed] RESPONDER: Remove dead assignment to the variable ret

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/105 Author: lslebodn Title: #105: RESPONDER: Remove dead assignment to the variable ret Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/105/head:pr105 git checkout pr105

[SSSD] [sssd PR#105][-Accepted] RESPONDER: Remove dead assignment to the variable ret

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/105 Title: #105: RESPONDER: Remove dead assignment to the variable ret Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#105][+Pushed] RESPONDER: Remove dead assignment to the variable ret

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/105 Title: #105: RESPONDER: Remove dead assignment to the variable ret Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#102][+Changes requested] Sssctl no case sensitive searches

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ One suggestion came from simo about using FGETPWENT(3) instead of opening the NSS module directly. """ See the full comment at https://gi

[SSSD] [sssd PR#99][+Accepted] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/99 Title: #99: Prevent use after free in fd_input_available Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#99][closed] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/99 Author: chlunde Title: #99: Prevent use after free in fd_input_available Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/99/head:pr99 git checkout pr99

[SSSD] [sssd PR#99][comment] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/99 Title: #99: Prevent use after free in fd_input_available jhrozek commented: """ Fixed upstream: master: 9676b464dd428557ff5a648e1351a3972440396f sssd-1-14: fefdd70237cbe82af7d8845131e45401e73b3b0

[SSSD] [sssd PR#99][-Accepted] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/99 Title: #99: Prevent use after free in fd_input_available Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#104][-Accepted] Suppress a confusing error message from timestamp cache updates

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/104 Title: #104: Suppress a confusing error message from timestamp cache updates Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#104][+Pushed] Suppress a confusing error message from timestamp cache updates

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/104 Title: #104: Suppress a confusing error message from timestamp cache updates Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#104][closed] Suppress a confusing error message from timestamp cache updates

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/104 Author: jhrozek Title: #104: Suppress a confusing error message from timestamp cache updates Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/104/head:pr104 git checkout pr104

[SSSD] [sssd PR#104][comment] Suppress a confusing error message from timestamp cache updates

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/104 Title: #104: Suppress a confusing error message from timestamp cache updates jhrozek commented: """ * master: ee576602d8b46b313c4f7ac8324cc31faefae46a """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#97][-Accepted] IFP: Remove "ChangeDebugTemporarily" method

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/97 Title: #97: IFP: Remove "ChangeDebugTemporarily" method Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#97][closed] IFP: Remove "ChangeDebugTemporarily" method

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/97 Author: fidencio Title: #97: IFP: Remove "ChangeDebugTemporarily" method Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/97/head:pr97 git checkout pr97

[SSSD] [sssd PR#97][+Pushed] IFP: Remove "ChangeDebugTemporarily" method

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/97 Title: #97: IFP: Remove "ChangeDebugTemporarily" method Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#97][comment] IFP: Remove "ChangeDebugTemporarily" method

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/97 Title: #97: IFP: Remove "ChangeDebugTemporarily" method jhrozek commented: """ * master: 78b4b7e5ec55861c43775581c08ae1804cd865f0 """ See the full comment at https://github.com/

[SSSD] [sssd PR#99][comment] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/99 Title: #99: Prevent use after free in fd_input_available jhrozek commented: """ Since the patch looks good to me, apparently fixes a crash an none of the maintainers have another opinion, I'm ACKing the patch. """

[SSSD] [sssd PR#99][+Pushed] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/99 Title: #99: Prevent use after free in fd_input_available Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#103][-Accepted] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/103 Title: #103: sudo: do not store usn if no rules are found Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#103][+Pushed] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/103 Title: #103: sudo: do not store usn if no rules are found Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#103][comment] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/103 Title: #103: sudo: do not store usn if no rules are found jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/58/31/summary.html The rawhide failure is unrelated.. """ See the full comment at https:/

[SSSD] [sssd PR#103][comment] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/103 Title: #103: sudo: do not store usn if no rules are found jhrozek commented: """ master: 46703740e83a66909974a5ee8d47df6a6e5076e7 sssd-1-14: 76e97affaa05ce45709efd59d120595c5992aa21 sssd-1-13: 4e25db79aa514e09c8ad4

[SSSD] [sssd PR#103][closed] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/103 Author: pbrezina Title: #103: sudo: do not store usn if no rules are found Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/103/head:pr103 git checkout pr103

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/109#issuecomment-266973055 ___ s

[SSSD] [sssd PR#102][comment] Sssctl no case sensitive searches

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches jhrozek commented: """ Except for the single question about the first patch to make sure I understand why we needed the change, the patches look good to me. CI is pending. "&quo

[SSSD] [sssd PR#109][+Changes requested] SSSCTL: fix netgroup-show parsing

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ Thank you for the patch. Since we already have the full entry object in sysdb_attrs I think it would be better to take a look at the objectclass (`sysdb_attrs_g

[SSSD] [sssd PR#102][+Changes requested] Sssctl no case sensitive searches

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#102][comment] Sssctl no case sensitive searches

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches jhrozek commented: """ Actually, the tests don't pass on RHEL-6, because the subprocess module is too old there: http://sssd-ci.duckdns.org/logs/job/59/14/rhel6/ci-build-debug/ci-make-i

[SSSD] [sssd PR#100][+Accepted] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/100 Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/100 Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds jhrozek commented: """ Actually, I didn't notice at first the patches are still split into three. if you squash the patches, I'll p

[SSSD] [sssd PR#100][-Accepted] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/100 Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#100][+Changes requested] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/100 Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an

[SSSD] [sssd PR#111][comment] BUILD: Find a host-prefixed krb5-config when cross-compiling

2016-12-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/111 Title: #111: BUILD: Find a host-prefixed krb5-config when cross-compiling jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/111#issuecomment-267546737 __

[SSSD] [sssd PR#94][+Changes requested] Enable {socket, dbus}-activation for responders

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders jhrozek commented: """ Hi, I read the patches, so far I didn't do a whole lot of testing, so maybe some questions here are invalid, but nonetheless, here is my take on t

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ On Tue, Dec 13, 2016 at 07:06:58AM -0800, Simo Sorce wrote: > On Tue, 2016-12-13 at 05:59 -0800, Jakub Hrozek wrote: > > On Tu

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ On Tue, Dec 13, 2016 at 02:44:44AM -0800, Simo Sorce wrote: > On Tue, 2016-12-13 at 02:25 -0800, fidencio wrote: > > Pavel, >

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders jhrozek commented: """ On Mon, Dec 12, 2016 at 05:19:18AM -0800, fidencio wrote: > >Would it make any sense to own the sockets by the sssd user as well? > >Cur

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ So..I wonder how much of a hack this is but if the intent here is to reset the watchdog from a signal handler, could we send a signal

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ On Mon, Dec 12, 2016 at 04:51:31AM -0800, Pavel Březina wrote: > I will try to do some review in this week. Thank you, but please note that I will try to implem

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ On Mon, Dec 12, 2016 at 06:55:13AM -0800, Simo Sorce wrote: > Yes we should ask, I think we really need to try to use monotonic clocks

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ I'm not sure I like the idea of killing a service because the admin runs ntpdate, even if the monitor should restart the service. @si

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ On Tue, Dec 13, 2016 at 08:16:33AM -0800, Simo Sorce wrote: > On Tue, 2016-12-13 at 08:02 -0800, Jakub Hrozek wrote: > > On Tu

[SSSD] [sssd PR#104][opened] Suppress a confusing error message from timestamp cache updates

2016-12-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/104 Author: jhrozek Title: #104: Suppress a confusing error message from timestamp cache updates Action: opened PR body: """ 0 is not an error, let's use a second variable instead to track the timestamp update retval and only emit a MINO

[SSSD] [sssd PR#102][+Accepted] Sssctl no case sensitive searches

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#102][comment] Sssctl no case sensitive searches

2016-12-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches jhrozek commented: """ Thank you, since the only issue in the set was related to the CI failure, I'm acking the set.. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#107][+Changes requested] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-12-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection jhrozek commented: """ It looks like this patch has stalled a bit. @lslebodn I think it makes sense to merge it anyway, even if we continue discussing some possible additional cha

[SSSD] [sssd PR#102][comment] Sssctl no case sensitive searches

2016-12-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches jhrozek commented: """ * 35ecfab87a24031e55798b22975e02832ee0f2ad * 715abb607540945cc82355e94712da7ac9746a67 * d6e875c49d6be650a03fc14f00a680734b23ef66 * 867bb85ecc8117aa8bdde9add0df8857cf

[SSSD] [sssd PR#102][closed] Sssctl no case sensitive searches

2016-12-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/102 Author: mzidek-rh Title: #102: Sssctl no case sensitive searches Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/102/head:pr102 git checkout pr102

[SSSD] [sssd PR#102][-Accepted] Sssctl no case sensitive searches

2016-12-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#106][+Changes requested] Add a new "files" provider

2016-12-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2016-12-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ I just set the Changes Requested label so that it's clear to reviewers new patch set is coming up.. """ See the full comment at https://gi

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ I just set the Changes Requested label so that it's clear to reviewers new patch set is coming up.. """ See the full comme

[SSSD] [sssd PR#102][+Pushed] Sssctl no case sensitive searches

2016-12-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#110][opened] Add more DEBUG messages to help admins diagnose Kerberos login failures

2016-12-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/110 Author: jhrozek Title: #110: Add more DEBUG messages to help admins diagnose Kerberos login failures Action: opened PR body: """ This PR contains two trivial (code-wise) patches that just add one DEBUG message each. It's quite co

<    2   3   4   5   6   7   8   9   10   11   >