[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ On Mon, Dec 12, 2016 at 07:30:30AM -0800, Simo Sorce wrote: > well you could have a globalk variable for the watchdog and change i

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2017-01-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders jhrozek commented: """ On Fri, Jan 13, 2017 at 02:52:49AM -0800, fidencio wrote: > On Fri, Jan 13, 2017 at 11:42 AM, Jakub Hrozek <notificati...@github.com> > wrote:

[SSSD] [sssd PR#110][synchronized] Add more DEBUG messages to help admins diagnose Kerberos login failures

2017-01-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/110 Author: jhrozek Title: #110: Add more DEBUG messages to help admins diagnose Kerberos login failures Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/110/head:pr110 git

[SSSD] [sssd PR#113][comment] Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267.

2017-01-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/113 Title: #113: Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267. jhrozek commented: """ On Fri, Jan 06, 2017 at 02:10:02AM -0800, lslebodn wrote: > I think you can use p

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-01-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ All the python-related comments should be fixed and pep8 shouldn't report any more errors. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-01-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ On Mon, Jan 09, 2017 at 03:17:24AM -0800, Pavel Březina wrote: > So far it looks good and I have only very few comments. I didn't read the > code thoroughl

[SSSD] [sssd PR#110][comment] Add more DEBUG messages to help admins diagnose Kerberos login failures

2017-01-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/110 Title: #110: Add more DEBUG messages to help admins diagnose Kerberos login failures jhrozek commented: """ Hmm, sorry, i thought I dropped the second patch some time ago already """ See the full comment at https:/

[SSSD] [sssd PR#113][synchronized] Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267.

2017-01-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/113 Author: jhrozek Title: #113: Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267. Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git

[SSSD] [sssd PR#113][-Changes requested] Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267.

2017-01-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/113 Title: #113: Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267. Label: -Changes requested ___ sssd-devel mailing list --

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ To me as well. I tested again the watchdog restart and the timeshift and both cases work fine. """ See the full comment at

[SSSD] [sssd PR#107][+Accepted] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2017-01-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders jhrozek commented: """ oh, and just so that it's known what I tested, I removed the services line altogether, then went one-by-one through all the responders and tested th

[SSSD] [sssd PR#124][opened] Fix a segfault in IFP's GetUserAttr

2017-01-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/124 Author: jhrozek Title: #124: Fix a segfault in IFP's GetUserAttr Action: opened PR body: """ This PR fixes a crash in GetUserAttr. To reproduce, it's enough to: dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe /

[SSSD] [sssd PR#93][comment] SSH: Use default_domain_suffix for users' authorized keys

2016-12-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/93 Title: #93: SSH: Use default_domain_suffix for users' authorized keys jhrozek commented: """ master: ed71fba97dfcf5b3f0f1834c06660c481b9ab3ce sssd-1-14: 2949fe58ac344c44d756ca309d4b2b7f3590cee3 """ See the full comme

[SSSD] [sssd PR#93][comment] SSH: Use default_domain_suffix for users' authorized keys

2016-12-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/93 Title: #93: SSH: Use default_domain_suffix for users' authorized keys jhrozek commented: """ On Mon, Nov 28, 2016 at 05:06:54AM -0800, Pavel Březina wrote: > Can you also prepare a patch to handle this inside cache_req? Ideally on &g

[SSSD] [sssd PR#93][closed] SSH: Use default_domain_suffix for users' authorized keys

2016-12-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/93 Author: jhrozek Title: #93: SSH: Use default_domain_suffix for users' authorized keys Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/93/head:pr93 git checkout pr93

[SSSD] [sssd PR#93][+Pushed] SSH: Use default_domain_suffix for users' authorized keys

2016-12-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/93 Title: #93: SSH: Use default_domain_suffix for users' authorized keys Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#93][-Accepted] SSH: Use default_domain_suffix for users' authorized keys

2016-12-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/93 Title: #93: SSH: Use default_domain_suffix for users' authorized keys Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#117][+Accepted] Fix compilation with python3.6

2017-01-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/117 Title: #117: Fix compilation with python3.6 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#117][comment] Fix compilation with python3.6

2017-01-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/117 Title: #117: Fix compilation with python3.6 jhrozek commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/117#issuecomment-269948911 ___ sssd-de

[SSSD] [sssd PR#107][+Changes requested] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/107#issuecomment-270630387

[SSSD] [sssd PR#107][+Accepted] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ hmm, it seems I was wrong and at least with systemd (is that the difference?) when we kill the whole process group also the nss and

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2017-01-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ btw now I'm wondering if the setpgrp should be a separate patch also for stable branches because I guess the bug was present in sssd f

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

2017-01-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ > On 6 Jan 2017, at 16:29, lslebodn <notificati...@github.com> wrote: > > On (06/01/17 05:52), Jakub Hrozek wrote: > >This patch is OK, b

[SSSD] [sssd PR#106][+Changes requested] Add a new "files" provider

2017-01-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-01-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ Yes, but as I said in the comment (in the part you quoted out), assert_passwd_by_name won't work, because it expects dir and uses dir in its control directory: `

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-01-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ so the solution would be to convert ent.py to not use dir internally either and I'm fine doing that if you think it would help """ See the full

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

2017-01-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req jhrozek commented: """ On Mon, Jan 02, 2017 at 01:53:23AM -0800, Pavel Březina wrote: > @jhrozek > * #1126 -- pam, ssh and pac (?) responders needs to be amend

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-01-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ OK, ready for review, @pbrezina There is still a commit that generates the default configuration. We already have a PR #108 that reverts this functionality --

[SSSD] [sssd PR#106][-Changes requested] Add a new "files" provider

2017-01-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#116][comment] intg: Generate tmp dir with lowercase

2017-01-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/116 Title: #116: intg: Generate tmp dir with lowercase jhrozek commented: """ ACK. Can you file a ticket to remove this hack once we have a version of python-requests that works? """ See the full comment at https:/

[SSSD] [sssd PR#116][+Accepted] intg: Generate tmp dir with lowercase

2017-01-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/116 Title: #116: intg: Generate tmp dir with lowercase Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

2017-01-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ This patch is OK, but only for sssd-1-14. In master, we already fall back to parsing the name string as short name if parsing the qualified name fails. I’m not

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2016-12-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ I hope you noticed the earlier comment that says "I just set the Changes Requested label so that it's clear to reviewers new patch set is coming up.."

[SSSD] [sssd PR#113][opened] Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267.

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/113 Author: jhrozek Title: #113: Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267. Action: opened PR body: """ None """ To pull the PR as Git branch: git remote

[SSSD] [sssd PR#94][+Changes requested] Enable {socket, dbus}-activation for responders

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#110][-Changes requested] Add more DEBUG messages to help admins diagnose Kerberos login failures

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/110 Title: #110: Add more DEBUG messages to help admins diagnose Kerberos login failures Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders jhrozek commented: """ Coverity seems to have detected a warning: Error: CHECKED_RETURN (CWE-252): sssd-1.14.90/src/responder/autofs/autofssrv_cmd.c:323: check_

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ btw I also added a test in PR #113 so that we don't regress again """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#107][+Changes requested] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#109][+Accepted] SSSCTL: fix netgroup-show parsing

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ Thank you, the patch works well. Just please note that after 7b293a5095ef3e63cd2e3f2ff01b7484bf6dcd38 was commited, this patch would only apply for sssd-1-14.

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ I have two comments: 1. The new debug message has "louder" debug level than the one that sets the port as non-working. I would suggest to als

[SSSD] [sssd PR#112][+Changes requested] FAILOVER: Improve port status log messages

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ I wonder if @mzidek-rh has any more comments """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268183489 _

[SSSD] [sssd PR#109][-Changes requested] SSSCTL: fix netgroup-show parsing

2016-12-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

2016-12-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req jhrozek commented: """ @pbrezina @lslebodn is there any more work needed on https://fedorahosted.org/sssd/ticket/1126 or https://fedorahosted.org/sssd/ticket/2320 ? Do we ant

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

2016-12-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ Ah, I didn't realize we don't read the objectclass attribute by default. The following hunk should fix it: ``` @@ -219,12 +233,14 @@ static const char **sss

[SSSD] [sssd PR#111][closed] BUILD: Find a host-prefixed krb5-config when cross-compiling

2016-12-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/111 Author: dm0- Title: #111: BUILD: Find a host-prefixed krb5-config when cross-compiling Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/111/head:pr111 git checkout pr111

[SSSD] [sssd PR#111][+Pushed] BUILD: Find a host-prefixed krb5-config when cross-compiling

2016-12-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/111 Title: #111: BUILD: Find a host-prefixed krb5-config when cross-compiling Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#111][comment] BUILD: Find a host-prefixed krb5-config when cross-compiling

2016-12-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/111 Title: #111: BUILD: Find a host-prefixed krb5-config when cross-compiling jhrozek commented: """ * master: baadb6080be0ec5cee2e351c3d5324d755f86f9c """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#111][+Accepted] BUILD: Find a host-prefixed krb5-config when cross-compiling

2016-12-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/111 Title: #111: BUILD: Find a host-prefixed krb5-config when cross-compiling Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#111][comment] BUILD: Find a host-prefixed krb5-config when cross-compiling

2016-12-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/111 Title: #111: BUILD: Find a host-prefixed krb5-config when cross-compiling jhrozek commented: """ ACK, CI: http://sssd-ci.duckdns.org/logs/job/59/21/summary.html (the failure on rawhide is unrelated) """ See the full

[SSSD] [sssd PR#67][+Accepted] UTIL: Unset O_NONBLOCK for ldap connection

2017-01-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#94][+Changes requested] Enable {socket, dbus}-activation for responders

2017-01-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2017-01-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders jhrozek commented: """ OK, I don't have any more comments than those inline. Thank you for the patches, really nice work. I'm just setting the Changes Requested label so that

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ rebased on master """ See the full comment at https://github.com/SSSD/sssd/pull/197#issuecomment-288860242 ___ sssd-de

[SSSD] [sssd PR#192][comment] Add certificate mapping library

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/192 Title: #192: Add certificate mapping library jhrozek commented: """ Thank you, the patches now look good to me. I'm only waiting for the CI run before the final ACK, but it should be noted again that the review was mostly based on r

[SSSD] [sssd PR#192][+Accepted] Add certificate mapping library

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/192 Title: #192: Add certificate mapping library Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ On Tue, Mar 21, 2017 at 10:31:10AM -0700, mzidek-rh wrote: > Nitpick: In the contrib/kcm_default_ccache it would be good to indicate (in > the comments) where the s

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ CI on the rebased patches: http://sssd-ci.duckdns.org/logs/job/65/45/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ @lslebodn I pushed a new patchset that should fix the warning in the kcm_queue test, can you verify if all warnings you saw are fixed? """ See the full comment at htt

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ OK, hopefully final CI run: http://sssd-ci.duckdns.org/logs/job/65/48/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#215][edited] Support for non-POSIX users and groups

2017-03-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Author: jhrozek Title: #215: Support for non-POSIX users and groups Action: edited Changed field: body Original value: """ This PR implements https://pagure.io/SSSD/sssd/issue/3310 The goal is to enable application users through the

[SSSD] [sssd PR#215][comment] Support for non-POSIX users and groups

2017-03-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Title: #215: Support for non-POSIX users and groups jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/65/97/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#213][+Accepted] intg: Remove bashism from intgcheck-prepare

2017-03-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/213 Title: #213: intg: Remove bashism from intgcheck-prepare Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#213][comment] intg: Remove bashism from intgcheck-prepare

2017-03-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/213 Title: #213: intg: Remove bashism from intgcheck-prepare jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/213#issuecomment-289805740

[SSSD] [sssd PR#197][closed] KCM responder

2017-03-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Author: jhrozek Title: #197: KCM responder Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/197/head:pr197 git checkout pr197 ___ sssd

[SSSD] [sssd PR#197][+Pushed] KCM responder

2017-03-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ Pushed to master: * e89ba95737202d551db2c9524127e6c4cf308796 * 2b5518eeaacc6245cfa77ee4a7086f16208060fc * 35c9dfe9ba78d3a635cd1af0fb6349ba44344623 * cac0db2f8004ae88b9263dc38

[SSSD] [sssd PR#215][+Pushed] Support for non-POSIX users and groups

2017-03-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Title: #215: Support for non-POSIX users and groups Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#215][comment] Support for non-POSIX users and groups

2017-03-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Title: #215: Support for non-POSIX users and groups jhrozek commented: """ * master: * 861ab44e8148208425b67c4711bc8fade10fd3ed * 3e39806177e1cd383743ff596cb96df44a6ce8c9 * ed0cdfcacc44e4e13e1524e25

[SSSD] [sssd PR#215][comment] Support for non-POSIX users and groups

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Title: #215: Support for non-POSIX users and groups jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/215#issuecomment-290113327

[SSSD] [sssd PR#215][comment] Support for non-POSIX users and groups

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Title: #215: Support for non-POSIX users and groups jhrozek commented: """ I fixed the minor issues in comments and the man pages. I also fixed the issue in the Kerberos provider with the following hunk: ``` diff --git a/src/providers/k

[SSSD] [sssd PR#208][comment] IFP: Filter with * in Users.ListByName method

2017-03-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/208 Title: #208: IFP: Filter with * in Users.ListByName method jhrozek commented: """ On Thu, Mar 30, 2017 at 03:46:20AM -0700, Pavel Březina wrote: > @jhrozek I agree there is a bug there. I just want to confirm one thing -- do > we

[SSSD] [sssd PR#215][comment] Support for non-POSIX users and groups

2017-03-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Title: #215: Support for non-POSIX users and groups jhrozek commented: """ the new PR just amends the manpage description of the non-POSIX domains """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#208][comment] IFP: Filter with * in Users.ListByName method

2017-03-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/208 Title: #208: IFP: Filter with * in Users.ListByName method jhrozek commented: """ On Thu, Mar 30, 2017 at 03:46:20AM -0700, Pavel Březina wrote: > @jhrozek I agree there is a bug there. I just want to confirm one thing -- do > we

[SSSD] [sssd PR#215][comment] Support for non-POSIX users and groups

2017-03-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Title: #215: Support for non-POSIX users and groups jhrozek commented: """ On Thu, Mar 30, 2017 at 02:53:18AM -0700, sumit-bose wrote: > I tested the patches with a plain LDAP setup and with and AD. In general they > work as expec

[SSSD] [sssd PR#215][comment] Support for non-POSIX users and groups

2017-03-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Title: #215: Support for non-POSIX users and groups jhrozek commented: """ On Thu, Mar 30, 2017 at 01:59:20AM -0700, Pavel Březina wrote: > I got error in enumeration as well with my secrets patch (definitely not > re

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ Thank you for the testing and the review, I hope I addressed all comments. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#197][-Changes requested] KCM responder

2017-03-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ I pushed new patches. CI passed: http://sssd-ci.duckdns.org/logs/job/65/29/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#207][comment] nss-idmap: add sss_nss_getlistbycert()

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/207 Title: #207: nss-idmap: add sss_nss_getlistbycert() jhrozek commented: """ CI passed: http://sssd-ci.duckdns.org/logs/job/65/30/summary.html Coverity is also clean """ See the full comment at https://github.com/S

[SSSD] [sssd PR#192][+Accepted] Add certificate mapping library

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/192 Title: #192: Add certificate mapping library Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#192][comment] Add certificate mapping library

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/192 Title: #192: Add certificate mapping library jhrozek commented: """ * master: * c44728a02d5e2c9eaced11e74820a6ae6a985f61 * 49f8ec8e0a3723a748bdb043d6dc1fb2a3977a8a * b341ee51cffd98b642b9c68a4

[SSSD] [sssd PR#192][closed] Add certificate mapping library

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/192 Author: sumit-bose Title: #192: Add certificate mapping library Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/192/head:pr192 git checkout pr192

[SSSD] [sssd PR#203][comment] IPA: Enhance debug logging for ipa s2n operations

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations jhrozek commented: """ * master: * cd83aead3c9799ac05d8f8977dbb92bbd399c6d5 * a04bef313508c423ed06cc54805a3b8106ab90cd """ See the full comment at https:/

[SSSD] [sssd PR#207][+Pushed] nss-idmap: add sss_nss_getlistbycert()

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/207 Title: #207: nss-idmap: add sss_nss_getlistbycert() Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#203][closed] IPA: Enhance debug logging for ipa s2n operations

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/203 Author: justin-stephenson Title: #203: IPA: Enhance debug logging for ipa s2n operations Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/203/head:pr203 git checkout pr203

[SSSD] [sssd PR#207][-Accepted] nss-idmap: add sss_nss_getlistbycert()

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/207 Title: #207: nss-idmap: add sss_nss_getlistbycert() Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#203][+Pushed] IPA: Enhance debug logging for ipa s2n operations

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#207][comment] nss-idmap: add sss_nss_getlistbycert()

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/207 Title: #207: nss-idmap: add sss_nss_getlistbycert() jhrozek commented: """ The code works fine: ``` >>> print >>&

[SSSD] [sssd PR#207][+Accepted] nss-idmap: add sss_nss_getlistbycert()

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/207 Title: #207: nss-idmap: add sss_nss_getlistbycert() Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#192][-Accepted] Add certificate mapping library

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/192 Title: #192: Add certificate mapping library Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#192][+Pushed] Add certificate mapping library

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/192 Title: #192: Add certificate mapping library Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#207][closed] nss-idmap: add sss_nss_getlistbycert()

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/207 Author: sumit-bose Title: #207: nss-idmap: add sss_nss_getlistbycert() Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/207/head:pr207 git checkout pr207

[SSSD] [sssd PR#207][comment] nss-idmap: add sss_nss_getlistbycert()

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/207 Title: #207: nss-idmap: add sss_nss_getlistbycert() jhrozek commented: """ * master: * a0b1bfa76073d3ce3208e67e6d72bb92088edac5 * 440797cba931aa491bf418035f55935943e22b4b """ See the full comment at https:/

<    3   4   5   6   7   8   9   10   11   12   >