[SSSD] [sssd PR#22] LDAP: Return partial results from adminlimit exceeded (-Changes requested)

2016-09-13 Thread lslebodn
jhrozek's pull request #22: "LDAP: Return partial results from adminlimit exceeded" label *Changes requested* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/22 ___ sssd-devel mailing list

[SSSD] [sssd PR#20] sss_override fails to export (comment)

2016-09-13 Thread lslebodn
lslebodn commented on a pull request """ On (09/09/16 05:50), mzidek-rh wrote: >See the updated tests. It uses export and import and checks if override works >after import. > ACK for test; just waiting for CI LS """ See the full comment at https://gi

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-13 Thread lslebodn
lslebodn commented on a pull request """ On (13/09/16 06:07), sumit-bose wrote: >I think it is still an ACK. > master: * d3348f49260998880bb7cd3b2fb72d562b1b7a64 LS """ See the full comment at https://github.com/SSSD

[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder

2016-09-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder lslebodn commented: """ Do we need review also from native speaker for initial version? LS """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#20] sss_override fails to export (+Changes requested)

2016-09-09 Thread lslebodn
mzidek-rh's pull request #20: "sss_override fails to export" label *Changes requested* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/20 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#20] sss_override fails to export (comment)

2016-09-09 Thread lslebodn
lslebodn commented on a pull request """ On (07/09/16 10:26), mzidek-rh wrote: >Here is a fix + CI test for https://fedorahosted.org/sssd/ticket/3179. > >Michal >You can view, comment on, or merge this pull request online at: > > https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-09-26 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed lslebodn commented: """ Downstream related tests passed. So +1 However, it seems that patch "MEMBEROF: Don't resolve members if they are removed" is not covered b

[SSSD] [sssd PR#13][+Changes requested] MEMBEROF: Don't resolve members if they are removed

2016-09-26 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#13][-Accepted] MEMBEROF: Don't resolve members if they are removed

2016-09-26 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#28][comment] PAM: call free only when memory is expected to be allocated

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/28 Title: #28: PAM: call free only when memory is expected to be allocated lslebodn commented: """ master: * a8631161c47cbaefe7fd14b88202238bbdcc3dc8 LS """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() lslebodn commented: """ On (19/09/16 04:39), celestian wrote: >Lukas, >sorry,I missed it. New version pushed. > >I have question, is there any way how to reply to your

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets lslebodn commented: """ On (19/09/16 04:39), Jakub Hrozek wrote: >On Mon, Sep 19, 2016 at 04:21:08AM -0700, celestian wrote: >> Well, >>

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() lslebodn commented: """ the following change looks werd to me `-dbus_free_string_array(arr_object_path);` `+dbus_free_string_array(discard_const(arr_object_path));` What

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() lslebodn commented: """ On (19/09/16 04:07), celestian wrote: >I change the order of patches, thanks Lukas. > Thank you for changing the order but I cannot see requested

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets lslebodn commented: """ On (20/09/16 05:02), Jakub Hrozek wrote: >On Tue, Sep 20, 2016 at 04:45:53AM -0700, lslebodn wrote: >> On (20/09/16 04:09), J

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets lslebodn commented: """ On (20/09/16 04:09), Jakub Hrozek wrote: >I was getting random failures where the socket was not yet ready withou

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() lslebodn commented: """ Bump for review. Users are waiting. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#27][comment] Minor code changes

2016-09-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/27 Title: #27: Minor code changes lslebodn commented: """ NACK to the first patch. We should rather use ldap_err2string. Adding more if/else statementes just complicate the code. the 2nd patch would make sense if you would like to reuse enu

[SSSD] [sssd PR#21][comment] IFP: expose user and group unique IDs through DBus

2016-09-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/21 Title: #21: IFP: expose user and group unique IDs through DBus lslebodn commented: """ On (16/09/16 06:12), Jakub Hrozek wrote: >I also wonder if the SIDs are needed. I don't have anything to add them in >principle, except I wo

[SSSD] [sssd PR#28][comment] PAM: call free only when memory is expected to be allocated

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/28 Title: #28: PAM: call free only when memory is expected to be allocated lslebodn commented: """ LGTM, Just waiting for the result of CI LS """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets lslebodn commented: """ On (16/09/16 06:56), Jakub Hrozek wrote: >jhrozek commented on this pull request. >> +# >+ >+import sock

[SSSD] [sssd PR#25][-Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread lslebodn
lslebodn commented on a pull request """ On (07/09/16 09:51), fidencio wrote: >A few minors in the commit messages that should be fixed before pushing. > >Patch0001: TOOLS: Fix a typo in groupadd() >Remove the four spaces before the link of the trac ticket. > >Pa

[SSSD] [sssd PR#35][comment] sss_cache: improve option argument handling

2016-09-30 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/35 Title: #35: sss_cache: improve option argument handling lslebodn commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/35#issuecomment-250818767 _

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ > Thank you for digging into this and finding the connection to gnutls. Do you > think this is an issue which should be solved in OpenL

[SSSD] [sssd PR#67][opened] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-26 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Author: lslebodn Title: #67: UTIL: Unset O_NONBLOCK for ldap connection Action: opened PR body: """ Before the commit 75e66c388862a4ba05afe0791c5503226395bad0, the flag O_NONBLOCK was set only for the connect syscall in request sssd_asy

[SSSD] [sssd PR#48][closed] sssctl: Flags for commadn initialization

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/48 Author: mzidek-rh Title: #48: sssctl: Flags for commadn initialization Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/48/head:pr48 git checkout pr48

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ > Could you explain what is the interaction between sssd and gnutls? Do you > pass the fd (which was set to non-blocking) or so to gnutls? There is n

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ and client + gnutls debug without O_NONBLOCK ``` (Thu Oct 27 11:37:03 2016) [sssd[be[LDAP]]] [simple_bind_send] (0x0100): Executing simple bind as: uid=mof_u

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ client log + gnutls debug ``` (Thu Oct 27 11:20:35 2016) [sssd[be[LDAP]]] [simple_bind_send] (0x0100): Executing simple bind as: uid=mof_user1,dc=example,

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-26 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups lslebodn commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-256445927 __

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ client log + gnutls debug ``` (Thu Oct 27 11:49:01 2016) [sssd[be[LDAP]]] [simple_bind_send] (0x0100): Executing simple bind as: uid=mof_user1,dc=example,

[SSSD] [sssd PR#48][+Pushed] sssctl: Flags for commadn initialization

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization lslebodn commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/48#issuecomment-256677906 ___ s

[SSSD] [sssd PR#67][comment] UTIL: Unset O_NONBLOCK for ldap connection

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/67 Title: #67: UTIL: Unset O_NONBLOCK for ldap connection lslebodn commented: """ On (27/10/16 02:03), Nikos Mavrogiannopoulos wrote: >I don't quite understand what the fix is about nor how it relates to gnutls. >Is it about wrong h

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-27 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization lslebodn commented: """ master: * cbee11e912bb391ba254b0bac8c1159c1f634533 sssd-1-14: * ec1829de7cd529c2c68b4bdb9b6d43ac6bb545d3 LS """ See the full comment at htt

[SSSD] [sssd PR#76][+Rejected] AD: Fix crash in AD subdomain reinit

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/76 Title: #76: AD: Fix crash in AD subdomain reinit Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#76][closed] AD: Fix crash in AD subdomain reinit

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/76 Author: justin-stephenson Title: #76: AD: Fix crash in AD subdomain reinit Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/76/head:pr76 git checkout pr76

[SSSD] [sssd PR#76][comment] AD: Fix crash in AD subdomain reinit

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/76 Title: #76: AD: Fix crash in AD subdomain reinit lslebodn commented: """ Closing as duplicate of PR #74 """ See the full comment at https://github.com/SSSD/sssd/pull/76#issuecomment-259370381

[SSSD] [sssd PR#59][closed] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Author: mzidek-rh Title: #59: ipa_netgroups: Lowercase key to htable Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/59/head:pr59 git checkout pr59

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable lslebodn commented: """ Please open new PR with correct ticket attached. You can inspire in https://fedorahosted.org/sssd/ticket/2275 """ See the full comment at https:

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable lslebodn commented: """ It looks like you forgot how to read. this PR is completely wrong. Subject and fix are wrong. Reopening does not help. """ See the full comme

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for IPA and AD providers

2016-11-04 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers lslebodn commented: """ Could you add newly created xml files into src/man/po/po4a.cfg ? LS """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#59][closed] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Author: mzidek-rh Title: #59: ipa_netgroups: Lowercase key to htable Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/59/head:pr59 git checkout pr59

[SSSD] [sssd PR#72][comment] Remove two unused methods from monitor's sbus interface

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/72 Title: #72: Remove two unused methods from monitor's sbus interface lslebodn commented: """ Obvious ACK LS """ See the full comment at https://github.com/SSSD/sssd/pull/72#issuecomment-259404349 __

[SSSD] [sssd PR#72][+Pushed] Remove two unused methods from monitor's sbus interface

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/72 Title: #72: Remove two unused methods from monitor's sbus interface Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#72][closed] Remove two unused methods from monitor's sbus interface

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/72 Author: jhrozek Title: #72: Remove two unused methods from monitor's sbus interface Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/72/head:pr72 git checkout pr72

[SSSD] [sssd PR#72][comment] Remove two unused methods from monitor's sbus interface

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/72 Title: #72: Remove two unused methods from monitor's sbus interface lslebodn commented: """ master: * fd25e68446ae86135489edb0823607b394f4ec40 * ab792150c97bd6eba1f8cd46653f41a0c64fd765 LS """ See the full comment at

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code lslebodn commented: """ I do not think that initialisation to NULL is the best solution for Wunitialized on RHLE6. My experience is that such bugs occurs when there is some

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-11-09 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code lslebodn commented: """ On (09/11/16 07:54), fidencio wrote: >@lslebodn, a way easier solution would be to disable -Werror when running CI >on RHEL6 than fixing tho

[SSSD] [sssd PR#73][comment] AD_PROVIDER: Enabled subdomains (1.13)

2016-11-07 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13) lslebodn commented: """ Patches does not have "cherry picked from commit" in commit message. In another word, they were not created with the flag "-x" LS

[SSSD] [sssd PR#73][+Changes requested] AD_PROVIDER: Enabled subdomains (1.13)

2016-11-07 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13) Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#46][-Accepted] sss_client: Defer thread cancellation until completion of nss/pam operations

2016-11-07 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/46 Title: #46: sss_client: Defer thread cancellation until completion of nss/pam operations Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#70][+Changes requested] check_duplicate: check name member before using it

2016-11-08 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#70][comment] check_duplicate: check name member before using it

2016-11-08 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it lslebodn commented: """ I would appreciate integration test for the crash. Feel free to extend `test_extra_attribute_already_exists` or create new one. """

[SSSD] [sssd PR#70][-Accepted] check_duplicate: check name member before using it

2016-11-08 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#71][comment] MONITOR: Do not set up watchdog for monitor

2016-11-08 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/71 Title: #71: MONITOR: Do not set up watchdog for monitor lslebodn commented: """ ACK LS """ See the full comment at https://github.com/SSSD/sssd/pull/71#issuecomment-259090619 _

[SSSD] [sssd PR#73][closed] AD_PROVIDER: Enabled subdomains (1.13)

2016-11-08 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/73 Author: celestian Title: #73: AD_PROVIDER: Enabled subdomains (1.13) Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/73/head:pr73 git checkout pr73

[SSSD] [sssd PR#69][comment] krb5: Use command line arguments instead env vars for krb5_child

2016-11-08 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child lslebodn commented: """ On (08/11/16 03:33), celestian wrote: >Code looks good to me. CI tests passed: >http://sssd-ci.duckdns.org/logs/job/56/34/summar

[SSSD] [sssd PR#73][comment] AD_PROVIDER: Enabled subdomains (1.13)

2016-11-08 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13) lslebodn commented: """ On (08/11/16 03:06), Jakub Hrozek wrote: >I tested the patches with a setup that consists of three domains >(win.trust.test, child.win.trust.test and s

[SSSD] [sssd PR#73][+Pushed] AD_PROVIDER: Enabled subdomains (1.13)

2016-11-08 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13) Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#65][comment] Fixing of nitpicks

2016-11-08 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/65 Title: #65: Fixing of nitpicks lslebodn commented: """ On (08/11/16 05:26), celestian wrote: >celestian commented on this pull request. >> @@ -269,6 +269,10 @@ static void >> rdp_message_send_and_reply_done(DBusPendin

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-11-08 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder lslebodn commented: """ On (08/11/16 05:15), fidencio wrote: >@jhrozek: >For the first patch the tests are correct. @lslebodn also complained that >[secrets/users

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-11-11 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder lslebodn commented: """ On (10/11/16 13:38), Jakub Hrozek wrote: >Since there is no ticket, I only pushed the patches to master: >682c9c3467055c2149a

[SSSD] [sssd PR#79][comment] LIBSSS_CONFIG: Drop libsss_config

2016-11-11 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/79 Title: #79: LIBSSS_CONFIG: Drop libsss_config lslebodn commented: """ You forgot to rebuve build dependencies from spec file and from ci.deps contrib/ci/deps.sh:libaugeas-dev contrib/sssd.spec.in:BuildRequires: augeas-deve

[SSSD] [sssd PR#69][-Accepted] krb5: Use command line arguments instead env vars for krb5_child

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#69][comment] krb5: Use command line arguments instead env vars for krb5_child

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child lslebodn commented: """ The password changed failed for me with this patches. I had also applied patches for PR #77. But I doubt they could cause such change

[SSSD] [sssd PR#74][comment] IPA/AD: check auth ctx before using it

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it lslebodn commented: """ On (10/11/16 03:12), celestian wrote: >Code looks good to me. CI tests passed: >http://sssd-ci.duckdns.org/logs/job/56/88/summary.html >And I manually

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for IPA and AD providers

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers lslebodn commented: """ I can see that tokengroups are documented in this PR. So I think we can close upstream ticket https://fedorahosted.org/sssd/ticket/3233

[SSSD] [sssd PR#68][-Changes requested] MAN: Document different defaults for IPA and AD providers

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable lslebodn commented: """ FYI: there is already better ticket https://fedorahosted.org/sssd/ticket/3159 """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#52][comment] CI: Remove dlopen-test from valgrind blacklist

2016-10-18 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/52 Title: #52: CI: Remove dlopen-test from valgrind blacklist lslebodn commented: """ On (17/10/16 14:55), fidencio wrote: >On Mon, Oct 17, 2016 at 11:51 PM, lslebodn <notificati...@github.com> wrote: >> If you can reprodu

[SSSD] [sssd PR#56][opened] Update dlopen test

2016-10-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/56 Author: lslebodn Title: #56: Update dlopen test Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/56/he

[SSSD] [sssd PR#55][closed] TESTS: Fix check for py bindings in dlopen tests

2016-10-18 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/55 Author: fidencio Title: #55: TESTS: Fix check for py bindings in dlopen tests Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/55/head:pr55 git checkout pr55

[SSSD] [sssd PR#50][comment] [RFC] Use GNULIB's compiler warning code

2016-10-18 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code lslebodn commented: """ It seems that resolv patches broke `resolv-tests` on fedora 22 and fedora 23. The test has been running for 30 hours without any result. I've just cancelled

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization lslebodn commented: """ On (17/10/16 09:33), Jakub Hrozek wrote: >I don't know how to unstuck this PR except providing some ideas > * SSS_TOOL_FLAG_NOCONF >

[SSSD] [sssd PR#52][synchronized] CI: Remove dlopen-test from valgrind blacklist

2016-10-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/52 Author: lslebodn Title: #52: CI: Remove dlopen-test from valgrind blacklist Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/52/head:pr52 git checkout pr52 From

[SSSD] [sssd PR#10][closed] UTIL: Remove support to libini older than 1.0.0

2016-10-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/10 Author: fidencio Title: #10: UTIL: Remove support to libini older than 1.0.0 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/10/head:pr10 git checkout pr10

[SSSD] [sssd PR#10][comment] UTIL: Remove support to libini older than 1.0.0

2016-10-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/10 Title: #10: UTIL: Remove support to libini older than 1.0.0 lslebodn commented: """ On (07/09/16 00:56), Jakub Hrozek wrote: >On Tue, Sep 06, 2016 at 11:49:09AM -0700, lslebodn wrote: >> IMHO, it might be better to close this PR

[SSSD] [sssd PR#52][+Pushed] CI: Remove dlopen-test from valgrind blacklist

2016-10-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/52 Title: #52: CI: Remove dlopen-test from valgrind blacklist Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-10-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder lslebodn commented: """ Jakub is more familiar with that code. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#52][closed] CI: Remove dlopen-test from valgrind blacklist

2016-10-19 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/52 Author: lslebodn Title: #52: CI: Remove dlopen-test from valgrind blacklist Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/52/head:pr52 git checkout pr52

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable lslebodn commented: """ On (20/10/16 02:20), Jakub Hrozek wrote: >On Thu, Oct 20, 2016 at 01:40:15AM -0700, lslebodn wrote: >> On (20/10/16 01:21), Jakub Hrozek wro

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable lslebodn commented: """ On (20/10/16 02:58), Jakub Hrozek wrote: >On Thu, Oct 20, 2016 at 02:55:12AM -0700, lslebodn wrote: >> On (20/10/16 02:20), Jakub Hrozek wrote: >>

[SSSD] [sssd PR#59][-Changes requested] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#59][closed] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Author: mzidek-rh Title: #59: ipa_netgroups: Lowercase key to htable Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/59/head:pr59 git checkout pr59

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable lslebodn commented: """ On (20/10/16 02:58), Jakub Hrozek wrote: >On Thu, Oct 20, 2016 at 02:55:12AM -0700, lslebodn wrote: >> Here is a hierarchy based on descition in

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable lslebodn commented: """ I am glad that ticket #3117 cannot be reproduced. Please close it. The ticket #3116 is one of the best examples how should ticket not look like. Please open a n

[SSSD] [sssd PR#59][closed] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/59 Author: mzidek-rh Title: #59: ipa_netgroups: Lowercase key to htable Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/59/head:pr59 git checkout pr59

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization lslebodn commented: """ IMHO, it would be nicer if you add new macro SSS_TOOL_COMMAND_FLAGS (or different name) rather then changing usage of SSS_TOOL_COMMAND and SSS_TOOL_COMMAN

[SSSD] [sssd PR#48][+Changes requested] sssctl: Flags for commadn initialization

2016-10-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed lslebodn commented: """ On (14/10/16 04:33), Jakub Hrozek wrote: >btw since the memberof patch we couldn't test is gone, I'm fine with pushing >these two. > I w

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed lslebodn commented: """ > Great, the result is the same. Both patches could fix it. So we can use just > ldap patch. What do you mean by both patches could f

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed lslebodn commented: """ On (14/10/16 04:48), celestian wrote: >I did manual testing with reproducer above. And I ran chmake (it is without >intg., isn't it). &g

[SSSD] [sssd PR#47][comment] BUILD: Fix build without /sbin/service installed on the build host

2016-10-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host lslebodn commented: """ I hope you noticed that CI build failed: https://ci.centos.org/job/sssd-CentOS6/87/ and https://ci.centos.org/job/sssd-CentOS7

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed lslebodn commented: """ > Great, the result is the same. Both patches could fix it. So we can use just > ldap patch. What do you mean by both patches could f

[SSSD] [sssd PR#63][comment] BUILD: Fix installation without samba

2016-10-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/63 Title: #63: BUILD: Fix installation without samba lslebodn commented: """ master: * 13adcd07000ba3ca1422c6ee863df17d70e2b14c sssd-1-14: * 1fb3cccd83ede1bbe99319254c88fce1285b352d """ See the full comment at https:

[SSSD] [sssd PR#63][closed] BUILD: Fix installation without samba

2016-10-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/63 Author: sorah Title: #63: BUILD: Fix installation without samba Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/63/head:pr63 git checkout pr63

[SSSD] [sssd PR#63][+Pushed] BUILD: Fix installation without samba

2016-10-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/63 Title: #63: BUILD: Fix installation without samba Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#63][comment] BUILD: Fix installation without samba

2016-10-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/63 Title: #63: BUILD: Fix installation without samba lslebodn commented: """ On (22/10/16 10:05), fidencio wrote: >

<    1   2   3   4   5   6   7   8   9   10   >