URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
I added a note to the commit message.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/432
Author: mzidek-rh
Title: #432: CACHE_REQ: Better debugging for email conflicts
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/432/head:pr432
git checkout pr432
From
URL: https://github.com/SSSD/sssd/pull/432
Author: mzidek-rh
Title: #432: CACHE_REQ: Better debugging for email conflicts
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/432/head:pr432
git checkout pr432
From
URL: https://github.com/SSSD/sssd/pull/420
Title: #420: NSS: memcache_timeout=0
mzidek-rh commented:
"""
@lslebodn well I know that, I just thought you are reacting to that
signed-off-by comment I made. I see it probably was not the case.
"""
See the full comme
URL: https://github.com/SSSD/sssd/pull/420
Title: #420: NSS: memcache_timeout=0
mzidek-rh commented:
"""
@lslebodn about the signed-off-by, I was talking to @jhrozek ... because I
squashed his code into my patch
"""
See the full comment at
https://github.com/S
URL: https://github.com/SSSD/sssd/pull/420
Title: #420: NSS: memcache_timeout=0
mzidek-rh commented:
"""
@lslebodn about the signed-off-by, I was talking to @jhrozek
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/420
Title: #420: NSS: memcache_timeout=0
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/420
Title: #420: NSS: memcache_timeout=0
mzidek-rh commented:
"""
Btw. feel free to add your Signed-of-by tag to the that I merged with your test.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/420
Title: #420: NSS: memcache_timeout=0
mzidek-rh commented:
"""
@jhrozek I included the test you wrote. It LGTM, I am currently running the
intgcheck suite locally to see if it passes. The only change I made to the test
was that I add
URL: https://github.com/SSSD/sssd/pull/420
Author: mzidek-rh
Title: #420: NSS: memcache_timeout=0
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/420/head:pr420
git checkout pr420
From
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
Just for the record. We decided to not include these these patches in the next
release.
The options will be more useful once a memcache diagnostic function
URL: https://github.com/SSSD/sssd/pull/420
Title: #420: NSS: memcache_timeout=0
mzidek-rh commented:
"""
I removed the changes requested label without changing the code (explanation is
in my previous comment).
"""
See the full comment at
https://github.com/S
URL: https://github.com/SSSD/sssd/pull/420
Title: #420: NSS: memcache_timeout=0
mzidek-rh commented:
"""
I really do believe that it is better to move the memcache related code from
nss_process_init to a separate function and I think it is better to do moves of
this kind be
URL: https://github.com/SSSD/sssd/pull/420
Title: #420: NSS: memcache_timeout=0
mzidek-rh commented:
"""
I really do believe that it is better to move the memcache related code from
nss_process_init to a separate function and I think it is better to do moves of
this kind be
URL: https://github.com/SSSD/sssd/pull/420
Title: #420: NSS: memcache_timeout=0
mzidek-rh commented:
"""
I really do believe that it is better to move the memcache related code from
nss_process_init to a separate function and I think it is better to do moves of
this kind be
URL: https://github.com/SSSD/sssd/pull/420
Title: #420: NSS: memcache_timeout=0
mzidek-rh commented:
"""
I really do believe that it is better to move the memcache related code from
nss_process_init to a separate function and I think it is better to do moves of
this kind be
URL: https://github.com/SSSD/sssd/pull/416
Title: #416: NSS: Memcache timeout equals zero
mzidek-rh commented:
"""
This PR was resurrected here:
https://github.com/SSSD/sssd/pull/420
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/420
Author: mzidek-rh
Title: #420: NSS: memcache_timeout=0
Action: opened
PR body:
"""
This is PR is continuation of:
https://github.com/SSSD/sssd/pull/416
about new semantics of memcache_timeout=0
"""
To pull the PR
URL: https://github.com/SSSD/sssd/pull/416
Title: #416: NSS: Memcache timeout equals zero
mzidek-rh commented:
"""
Oh, I see the PR is still closed (I thought Fabiano reopened it but he probably
only has the same permissions as I do). Ok, then I guess somebody will
URL: https://github.com/SSSD/sssd/pull/416
Title: #416: NSS: Memcache timeout equals zero
mzidek-rh commented:
"""
I do not see the changes I made... could it be because I pushed the changes
while the PR was closed?
Will try to do something about it...
"""
URL: https://github.com/SSSD/sssd/pull/416
Author: mzidek-rh
Title: #416: NSS: Memcache timeout equals zero
Action: opened
PR body:
"""
Hi,
these patches add new semantics to the memcache_timeout=0.
From users perspective there is basically no change, but with value 0 the
URL: https://github.com/SSSD/sssd/pull/412
Title: #412: Gpo contributed patches
mzidek-rh commented:
"""
@fidencio Running downstream tests would be good indeed. But I do not know how
to do it. Do you know if we have something better then the step-by-step gdoc
guid
URL: https://github.com/SSSD/sssd/pull/412
Title: #412: Gpo contributed patches
mzidek-rh commented:
"""
Btw. if someone encounters the issues with the bad DC being contacted, the
second lookup always contacted the correct DC for me. I will check if we track
this issue so
URL: https://github.com/SSSD/sssd/pull/412
Author: mzidek-rh
Title: #412: Gpo contributed patches
Action: edited
Changed field: body
Original value:
"""
Hi, I am moving the patches from this PR:
https://pagure.io/SSSD/sssd/pull-request/3320
Here on GH. The issue was stalled
URL: https://github.com/SSSD/sssd/pull/412
Author: mzidek-rh
Title: #412: Gpo contributed patches
Action: opened
PR body:
"""
Hi, I am moving the patches from this PR:
https://pagure.io/SSSD/sssd/pull-request/3320
Here on GH. The issue was stalled for a long time, and
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
I see I forgot to remove the changes requested label.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
I changed the tests, because as they were written before they did not work (we
probably have a bug in memcache, but it is not related to these pa
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/390/head:pr390
git checkout pr390
From
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
Sorry there is an error in the tests, I will update new version.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/390/head:pr390
git checkout pr390
From
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
Yes, the test only covers the original use case. I will add test cases to
disable only certain memcache types, thanks for noticing that.
"""
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/390/head:pr390
git checkout pr390
From
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/390/head:pr390
git checkout pr390
From
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
I have one question to the implementation. I will add one option for all
memcache types, do we also want to have separate options for different types of
mem
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
I agree with the proposal. Will update new version.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
Hi, I just squashed the patch with the warning with the original patch, I only
kept the patches separate for review purpose, but as @fidencio mentioned it is
b
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/390/head:pr390
git checkout pr390
From
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
I updated the 'Warning' patch to use wording suggested by @fidencio (I like it
more then mine).
Btw. I do not mind documenting other discouraged options,
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/390/head:pr390
git checkout pr390
From
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
@fidencio I mentioned that I think we should add warning to the man page, but I
was not sure if we end up deleting the man page, so I did not add the chan
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/390/head:pr390
git checkout pr390
From
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
As for not putting this to upstream and only to the requested downstream
distro, I do not like it. We may end up backporting it to future versions of
that do
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
@lslebodn I am not sure about that. Maybe we could document the fact that it
has significant performance impact? Retrospectively, I think we shoul
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/390/head:pr390
git checkout pr390
From
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
Updated the man page to use wording that @pbrezina suggested.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
@fidencio I did not notice your comment before. But I do agree :)
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
@pbrezina That would not be a good idea IMO. If the administrator decides that
the memcache should be disabled, then the client applications should not be
a
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
@pbrezina Thank you for the comments. If the cache is disabled centrally using
the use_memcache option, client applications can not use it regardless of
SSS_N
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/390/head:pr390
git checkout pr390
From
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
I am opening this PR even though it is not 100% decided that we want this
option.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: opened
PR body:
"""
Added option use_memcache to centrally disable memcache
for all clients without the need to specify SSS_NSS_USE_MEMCACHE=NO
environment vari
URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code
mzidek-rh commented:
"""
I did not review all the patches, but I do not like the removal of the INI
warning. I guess we can not treat warnings as errors for all platforms. It is
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
mzidek-rh commented:
"""
Hi!
@fidencio please do not use the flag 'Rejected' when requesting changes to a
patch set. Use 'Changes requested' instead. I did not review
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
Label: -Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
mzidek-rh commented:
"""
Hi!
@fidencio please do not use the flag 'Rejected' when requesting changes to the
patch set. Use 'Changes requested' instead. I did not re
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
mzidek-rh commented:
"""
Just a note. The CI passed. Codewise I see no blockers for this patchset. I
will keep the 'changes_requested' label solely for the requested metadata
changes.
&q
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
Label: -Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
mzidek-rh commented:
"""
Hmm.. it was a different CI result that came. So I am postponing the ACK for a
few moments now (but really just waiting for the rawhide machine to finish).
Lukas,
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
mzidek-rh commented:
"""
@fidencio Sorry, I was not aware of the PRs you mentioned (my mistake). However
I already reviewed this and I think it is better to have the patches rather
the
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
mzidek-rh commented:
"""
The patches fix the warnings. Just waiting for the CI before acking.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings
mzidek-rh commented:
"""
Fine by me. I agree that we should make the python 3 API as clean as possible
before more people start using it.
"""
URL: https://github.com/SSSD/sssd/pull/365
Title: #365: PYTHON: Define constants as bytes instead of strings
mzidek-rh commented:
"""
I do like the change, but isn't this going to break existing python3 code, that
uses pysss_nss_idmap.SID_KEY.encode('utf-8')?
"&quo
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
mzidek-rh commented:
"""
I am removing the changes requested and adding back the accepted label.
@lslebodn If you had a specific function in mind you can point us to it
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
mzidek-rh commented:
"""
@jhrozek sry, I only parsed 'accepted' from your message and I though you did
accept it.
So, ACK and adding accepted flag.
"""
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
mzidek-rh commented:
"""
I do not want to postpone this any more. We can run the downstream tests before
release, but the manual testing worked for me so I will just wait fo
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
mzidek-rh commented:
"""
The code LGTM and my ad-hoc testing was so far successful. There is one more
test I want to try manually.
We do not have upstream tests that would
URL: https://github.com/SSSD/sssd/pull/345
Title: #345: Improve the situation of recurrent failing CI tests
mzidek-rh commented:
"""
I think the fact that the increased timeouts helped stabilize the tests is
helpful information. I did not look into the issue itself yet,
URL: https://github.com/SSSD/sssd/pull/202
Title: #202: T3315 infopipe group users master
mzidek-rh commented:
"""
ACK. I was able to reproduce the bug following the instructions provided above
and the patch does fix it.
CI passed.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/202
Title: #202: T3315 infopipe group users master
mzidek-rh commented:
"""
ACK. I was able to reproduce the bug following the instructions provided above
and the patch does fix it.
CI:
http://vm-058-233.abc.idm.lab.eng.brq.redhat.com
URL: https://github.com/SSSD/sssd/pull/202
Title: #202: T3315 infopipe group users master
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/202
Title: #202: T3315 infopipe group users master
mzidek-rh commented:
"""
Thank you for the description. I see the bug now and the patch makes sense.
I sent the patch to CI.
"""
See the full comment at
https://github.com/S
URL: https://github.com/SSSD/sssd/pull/202
Title: #202: T3315 infopipe group users master
mzidek-rh commented:
"""
I am Ok with closing this PR. Btw. I still do not think that what is described
in the reproducer as buggy behavior is actually wrong. I think the requests
URL: https://github.com/SSSD/sssd/pull/189
Title: #189: SELINUX: Use getseuserbyname to get IPA seuser
mzidek-rh commented:
"""
By the way in this issue: https://pagure.io/SSSD/sssd/issue/3308
it states that Petr Lautrbach recommended to use the libselinux function. I
think
URL: https://github.com/SSSD/sssd/pull/189
Title: #189: SELINUX: Use getseuserbyname to get IPA seuser
mzidek-rh commented:
"""
@jhrozek this patch replaces function from libsemanage with function from
libselinux... The commit message says that libselinux is recommended ov
URL: https://github.com/SSSD/sssd/pull/202
Title: #202: T3315 infopipe group users master
mzidek-rh commented:
"""
@fidencio , sorry but I do not know what is the issue. I was probably not clear
in my previous comments, but IMO the reproducer is wrong because it does not
descri
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
mzidek-rh commented:
"""
There is a tabulator instead of space after '=' sign
in Makefile.am:
```
458
459 dist_sbin_SCRIPTS = contrib/tools/sss_debuglevel
460
```
But as
URL: https://github.com/SSSD/sssd/pull/337
Title: #337: KCM: Fix Description of sssd-kcm.socket
mzidek-rh commented:
"""
Or, actually disregard my question. Secrets makes perfect sense because it does
not need to be used just for kcm.
Anyway, ACK.
"""
URL: https://github.com/SSSD/sssd/pull/337
Title: #337: KCM: Fix Description of sssd-kcm.socket
mzidek-rh commented:
"""
Ack.
I just wonder, why we call the service 'secrets' and not 'kcm'. I guess it is
too late to change it now, right?
"""
See the full comme
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
mzidek-rh commented:
"""
In sssctl we follow (or at least try to) the TOPIC-ACTION convention for naming
the commands. So "expire-cache" is not a good name. It shou
URL: https://github.com/SSSD/sssd/pull/314
Author: mzidek-rh
Title: #314: SDAP: Add sdap_domain_copy_search_bases
Action: opened
PR body:
"""
Add function to copy search bases from one sdap_domain to
another.
Resolves:
https://pagure.io/SSSD/sssd/issue/3435
"""
URL: https://github.com/SSSD/sssd/pull/313
Title: #313: SDAP: Update parent sdap_list
mzidek-rh commented:
"""
I hope I pushed it correctly without any garbage this time.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/313
Title: #313: SDAP: Update parent sdap_list
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/313
Author: mzidek-rh
Title: #313: SDAP: Update parent sdap_list
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/313/head:pr313
git checkout pr313
From
URL: https://github.com/SSSD/sssd/pull/313
Title: #313: SDAP: Update parent sdap_list
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/313
Author: mzidek-rh
Title: #313: SDAP: Update parent sdap_list
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/313/head:pr313
git checkout pr313
From
URL: https://github.com/SSSD/sssd/pull/313
Title: #313: SDAP: Update parent sdap_list
mzidek-rh commented:
"""
Sorry I had uncommitted changes in the repo and force pushed the patch. Fixed
now.
Yes the first one is unrelated. I even forgot I have it in this branch, but it
URL: https://github.com/SSSD/sssd/pull/313
Author: mzidek-rh
Title: #313: SDAP: Update parent sdap_list
Action: opened
PR body:
"""
Update parent sdap_list with newly created subdomain sdap domain.
Preiously, we inherited the parent sdap_list a
URL: https://github.com/SSSD/sssd/pull/285
Title: #285: SSSCTL: Add primary or subdomain information
mzidek-rh commented:
"""
Thank you.
ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/285#issuecomment-306731002
URL: https://github.com/SSSD/sssd/pull/285
Title: #285: SSSCTL: Add primary or subdomain information
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/285
Title: #285: SSSCTL: Add primary or subdomain information
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/285
Title: #285: SSSCTL: Add primary or subdomain information
mzidek-rh commented:
"""
Also please change the sentence in the --verbose description: "Show domain
list including primary or subdomain type" to "Show domain list
URL: https://github.com/SSSD/sssd/pull/285
Title: #285: SSSCTL: Add primary or subdomain information
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/285
Title: #285: SSSCTL: Add primary or subdomain information
mzidek-rh commented:
"""
Sorry to jump late to the conversation, but I want to request one change to the
patch.
We should really not use the word "subdomain" in an
401 - 500 of 698 matches
Mail list logo
