[SSSD] [sssd PR#5503][opened] pam_sss: Don't fail on deskprofiles phase for AD users

2021-02-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5503 Author: stanislavlevin Title: #5503: pam_sss: Don't fail on deskprofiles phase for AD users Action: opened PR body: """ By default (if session_provider is not none) during session setup pam_sss attempts to fetch desktop rules a

[SSSD] [sssd PR#5503][edited] pam_sss: Don't fail on deskprofiles phase for AD users

2021-02-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5503 Author: stanislavlevin Title: #5503: pam_sss: Don't fail on deskprofiles phase for AD users Action: edited Changed field: body Original value: """ By default (if session_provider is not none) during session setup pam_sss attem

[SSSD] [sssd PR#5503][synchronized] pam_sss: Don't fail on deskprofiles phase for AD users

2021-02-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5503 Author: stanislavlevin Title: #5503: pam_sss: Don't fail on deskprofiles phase for AD users Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5503/head:pr5503 git che

[SSSD] [sssd PR#5503][synchronized] pam_sss: Don't fail on deskprofiles phase for AD users

2021-02-16 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5503 Author: stanislavlevin Title: #5503: pam_sss: Don't fail on deskprofiles phase for AD users Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5503/head:pr5503 git che

[SSSD] [sssd PR#5503][comment] pam_sss: Don't fail on deskprofiles phase for AD users

2021-02-16 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5503 Title: #5503: pam_sss: Don't fail on deskprofiles phase for AD users stanislavlevin commented: """ @pbrezina, sure, pushed. """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#5503][comment] pam_sss: Don't fail on deskprofiles phase for AD users

2021-02-16 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5503 Title: #5503: pam_sss: Don't fail on deskprofiles phase for AD users stanislavlevin commented: """ @pbrezina, @sumit-bose. Thank you for review and support! """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#5845][opened] sss-analyze: Fix self imports

2021-10-27 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Author: stanislavlevin Title: #5845: sss-analyze: Fix self imports Action: opened PR body: """ - fixed self imports to allow any other Python stuff use `sssd` Python package - `sssd` Python package tranformed from namespace

[SSSD] [sssd PR#5845][edited] sss-analyze: Fix self imports

2021-10-27 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Author: stanislavlevin Title: #5845: sss-analyze: Fix self imports Action: edited Changed field: body Original value: """ - fixed self imports to allow any other Python stuff use `sssd` Python package - `sssd` Python package

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-10-27 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ > Thank you. > > > ``` > > * moved the executable out to sbin directory to split the library and > > actual executable (sbin

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-10-27 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ actually, I first checked it as a standalone tool, and only after that I see it is also called from sssctl. """ See the full comment at https://

[SSSD] [sssd PR#5847][opened] pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC

2021-10-27 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5847 Author: stanislavlevin Title: #5847: pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC Action: opened PR body: """ IPA domain controller may not support desktop profiles since this functionality

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-10-27 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @justin-stephenson, thank you for the review! Can I see the build log? which distro/version? """ See the full comment at https://github.com/SS

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-10-27 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ F34: `make rpms` works for me. """ See the full comment at https://github.com/SSSD/sssd/pull/5845#issuecomment-953051417 __

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-10-28 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @justin-stephenson, @pbrezina, please let me know if something else should be done for this PR. """ See the full comment at https://

[SSSD] [sssd PR#5847][synchronized] pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC

2021-10-28 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5847 Author: stanislavlevin Title: #5847: pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5847

[SSSD] [sssd PR#5847][comment] pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC

2021-10-28 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5847 Title: #5847: pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC stanislavlevin commented: """ it seems `test_realloc_groups_exact` is flaky, 2 distro jobs failed on it. I think the failures are not r

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-10-29 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ Any objections about libexec for sss_analyze? """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5845][synchronized] sss-analyze: Fix self imports

2021-11-03 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Author: stanislavlevin Title: #5845: sss-analyze: Fix self imports Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5845/head:pr5845 git checkout pr5845 From

[SSSD] [sssd PR#5845][synchronized] sss-analyze: Fix self imports

2021-11-03 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Author: stanislavlevin Title: #5845: sss-analyze: Fix self imports Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5845/head:pr5845 git checkout pr5845 From

[SSSD] [sssd PR#5845][synchronized] sss-analyze: Fix self imports

2021-11-03 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Author: stanislavlevin Title: #5845: sss-analyze: Fix self imports Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5845/head:pr5845 git checkout pr5845 From

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-11-03 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @pbrezina, thanks, updated. """ See the full comment at https://github.com/SSSD/sssd/pull/5845#issuecomment-958934172 __

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-11-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ Hi, @pbrezina. Sorry, I had my vacation. Given the Python stuff is not planned to be reusable and to not pollute `sssd` package (Python distribution having name

[SSSD] [sssd PR#5847][comment] pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC

2021-11-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5847 Title: #5847: pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC stanislavlevin commented: """ > Hi, > > thank you for the analysis and the patch. There is a slight difference > between the

[SSSD] [sssd PR#5847][comment] pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC

2021-11-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5847 Title: #5847: pam_sss: Allow offline authentication against non-ipa-desktopprofiles aware DC stanislavlevin commented: """ Thank you for the review @sumit-bose, @abbra. """ See the full comment at https://github.com/SS

[SSSD] [sssd PR#5845][synchronized] sss-analyze: Fix self imports

2021-11-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Author: stanislavlevin Title: #5845: sss-analyze: Fix self imports Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5845/head:pr5845 git checkout pr5845 From

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-11-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ > i'd like to see the --without-python3-bindings case handled too - because > currently it installs files to **/**sssd it's no longer installe

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-11-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @pbrezina, updated. """ See the full comment at https://github.com/SSSD/sssd/pull/5845#issuecomment-969100053

[SSSD] [sssd PR#5845][edited] sss-analyze: Fix self imports

2021-11-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Author: stanislavlevin Title: #5845: sss-analyze: Fix self imports Action: edited Changed field: body Original value: """ - fixed self imports to allow any other Python stuff use `sssd` Python package - transformed `sssd` Pyth

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-11-23 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ > Thank you for the update. In general, I agree with the patches. But I think > the proper location require a team discussion about our future plans with

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-02 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @pbrezina, hi, no problem. The original patch( 1e4d2ebc4ad0d69afa00ab3d2bb481a8f5ddef80) moved `sss_analyze` into sbindir, is it ok? """

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-06 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @pbrezina, you may want to read: https://ocs.python.org/3/library/sysconfig.html#installation-paths > Each scheme is itself composed of a series of paths a

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-06 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @pbrezina, you may want to read: https://docs.python.org/3/library/sysconfig.html#installation-paths > Each scheme is itself composed of a series of paths a

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-10 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ Is FHS enough reason? https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html#usrlibLibrariesForProgrammingAndPa > 4.6. /usr/lib : Libraries for programming

[SSSD] [sssd PR#5845][synchronized] sss-analyze: Fix self imports

2021-12-13 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Author: stanislavlevin Title: #5845: sss-analyze: Fix self imports Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5845/head:pr5845 git checkout pr5845 From

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-13 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @justin-stephenson, how can I interpret the deletion of your comment? ack or reject or I don't know? :-) Rebased (hope finally). ""&qu

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-14 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @justin-stephenson, `sss_analyze.py` is the module lived in site-packages, while `sss_analyze` is just a wrapper over that module. Do you want to

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-14 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @justin-stephenson, thank you for your patience :) """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @justin-stephenson, please, be aware that this PR and #5913 will cause a merge conflict. I suggest merging #5913 first and I can rebase this one then. "&quo

[SSSD] [sssd PR#5913][comment] Analyzer: Remove python-click dependency

2021-12-15 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5913 Title: #5913: Analyzer: Remove python-click dependency stanislavlevin commented: """ @alexey-tikhonov, yes, it does. """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5845][synchronized] sss-analyze: Fix self imports

2021-12-16 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Author: stanislavlevin Title: #5845: sss-analyze: Fix self imports Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5845/head:pr5845 git checkout pr5845 From

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-16 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @justin-stephenson, there is the circular import on the recent change exposed with this PR: ``` [root@master1 /]# sssctl analyze NOTE: Tevent chain ID support m

[SSSD] [sssd PR#5845][synchronized] sss-analyze: Fix self imports

2021-12-16 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Author: stanislavlevin Title: #5845: sss-analyze: Fix self imports Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5845/head:pr5845 git checkout pr5845 From

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-16 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ - added a workaround for this, but the sources should be reorganized. """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-16 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ @justin-stephenson, - I can drop that workaround part, and then you could open another PR - I can cherry your commit - you can cherry or push (if you have corre

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-12-16 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ superseded by https://github.com/SSSD/sssd/pull/5863 """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5845][closed] sss-analyze: Fix self imports

2021-12-16 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Author: stanislavlevin Title: #5845: sss-analyze: Fix self imports Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5845/head:pr5845 git checkout pr5845

[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements

2021-12-17 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements stanislavlevin commented: """ ``` [root@master1 /]# sssctl analyze request list -v NOTE: Tevent chain ID support missing, request analysis will be limited. It is rec

[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements

2021-12-17 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements stanislavlevin commented: """ cherry-pick is OK. """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements

2021-12-17 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements stanislavlevin commented: """ Are there corresponding tests? Can't find them. """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements

2021-12-17 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements stanislavlevin commented: """ > ``` > [root@master1 /]# sssctl analyze request list -v > NOTE: Tevent chain ID support missing, request analysis

[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements

2021-12-17 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements stanislavlevin commented: """ @justin-stephenson, I saw the message, thank you. Since there is no strict requirement on that version of libtevent I assumed the tool

[SSSD] [sssd PR#688][opened] Allow non-privileged sssd user connect to private dbus

2018-11-01 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/688 Author: stanislavlevin Title: #688: Allow non-privileged sssd user connect to private dbus Action: opened PR body: """ During startup SSSD monitor launches the children and stands on a private dbus to waiting for a reply from them.

[SSSD] [sssd PR#688][comment] Allow non-privileged sssd user connect to private dbus

2018-11-01 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/688 Title: #688: Allow non-privileged sssd user connect to private dbus stanislavlevin commented: """ We have faced with this issue during an upgrade SSSD from 1.x to 2.x. Please, review. If it is an appropriate way to fix, I can add

[SSSD] [sssd PR#624][opened] Fix "test-find-uid" and "find_uid-tests" tests

2018-07-26 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/624 Author: stanislavlevin Title: #624: Fix "test-find-uid" and "find_uid-tests" tests Action: opened PR body: """ Handle a "hidepid=1" mount option for procfs. One of the affects - this option makes impe

[SSSD] [sssd PR#624][comment] Fix "test-find-uid" and "find_uid-tests" tests

2018-08-13 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/624 Title: #624: Fix "test-find-uid" and "find_uid-tests" tests stanislavlevin commented: """ I'm sorry, i had a vacation. Thank you for a fix up and merging! """ See the full comment at https