[SSSD] [sssd PR#967][comment] util/watchdog: fixed watchdog implementation (sssd-1-16)
URL: https://github.com/SSSD/sssd/pull/967 Title: #967: util/watchdog: fixed watchdog implementation (sssd-1-16) mzidek-rh commented: """ Just opening separate PR for 1.16 """ See the full comment at https://github.com/SSSD/sssd/pull/967#issuecomment-565668220 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#967][edited] util/watchdog: fixed watchdog implementation (sssd-1-16)
URL: https://github.com/SSSD/sssd/pull/967 Author: mzidek-rh Title: #967: util/watchdog: fixed watchdog implementation (sssd-1-16) Action: edited Changed field: title Original value: """ util/watchdog: fixed watchdog implementation """ ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#967][opened] util/watchdog: fixed watchdog implementation
URL: https://github.com/SSSD/sssd/pull/967
Author: mzidek-rh
Title: #967: util/watchdog: fixed watchdog implementation
Action: opened
PR body:
"""
In case watchdog detected locked process and this process was parent
process it just sent SIGTERM to the whole group of processes, including
itself.
This handling was wrong: generic `server_setup()` installs custom
libtevent handler for SIGTERM signal so this signal is only processed
in the context of tevent mainloop. But if tevent mainloop is stuck
(exactly the case that triggers WD) then event is not processed
and this made watchdog useless.
`watchdog_handler()` and `watchdog_detect_timeshift()` were amended to do
unconditional `_exit()` after optionally sending a signal to the group.
Resolves: https://pagure.io/SSSD/sssd/issue/4089
Reviewed-by: Sumit Bose
(cherry picked from commit 2c13d8bd00f1e8ff30e9fc81f183f6450303ac30)
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/967/head:pr967
git checkout pr967
From d56fc76f370c75c05b51462d818559f70e7f7d4f Mon Sep 17 00:00:00 2001
From: Alexey Tikhonov
Date: Wed, 11 Dec 2019 18:42:49 +0100
Subject: [PATCH] util/watchdog: fixed watchdog implementation
In case watchdog detected locked process and this process was parent
process it just sent SIGTERM to the whole group of processes, including
itself.
This handling was wrong: generic `server_setup()` installs custom
libtevent handler for SIGTERM signal so this signal is only processed
in the context of tevent mainloop. But if tevent mainloop is stuck
(exactly the case that triggers WD) then event is not processed
and this made watchdog useless.
`watchdog_handler()` and `watchdog_detect_timeshift()` were amended to do
unconditional `_exit()` after optionally sending a signal to the group.
Resolves: https://pagure.io/SSSD/sssd/issue/4089
Reviewed-by: Sumit Bose
(cherry picked from commit 2c13d8bd00f1e8ff30e9fc81f183f6450303ac30)
---
src/util/util_watchdog.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/util/util_watchdog.c b/src/util/util_watchdog.c
index 20a8b89679..599b7fc40a 100644
--- a/src/util/util_watchdog.c
+++ b/src/util/util_watchdog.c
@@ -54,9 +54,8 @@ static void watchdog_detect_timeshift(void)
if (write(watchdog_ctx.pipefd[1], "1", 1) != 1) {
if (getpid() == getpgrp()) {
kill(-getpgrp(), SIGTERM);
-} else {
-_exit(1);
}
+_exit(1);
}
}
}
@@ -75,9 +74,8 @@ static void watchdog_handler(int sig)
if (__sync_add_and_fetch(_ctx.ticks, 1) > WATCHDOG_MAX_TICKS) {
if (getpid() == getpgrp()) {
kill(-getpgrp(), SIGTERM);
-} else {
-_exit(1);
}
+_exit(1);
}
}
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#964][closed] util/watchdog: fixed watchdog implementation
URL: https://github.com/SSSD/sssd/pull/964 Author: alexey-tikhonov Title: #964: util/watchdog: fixed watchdog implementation Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/964/head:pr964 git checkout pr964 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#964][-branch: sssd-1-16] util/watchdog: fixed watchdog implementation
URL: https://github.com/SSSD/sssd/pull/964 Title: #964: util/watchdog: fixed watchdog implementation Label: -branch: sssd-1-16 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#964][+Pushed] util/watchdog: fixed watchdog implementation
URL: https://github.com/SSSD/sssd/pull/964 Title: #964: util/watchdog: fixed watchdog implementation Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#964][-Accepted] util/watchdog: fixed watchdog implementation
URL: https://github.com/SSSD/sssd/pull/964 Title: #964: util/watchdog: fixed watchdog implementation Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#964][comment] util/watchdog: fixed watchdog implementation
URL: https://github.com/SSSD/sssd/pull/964 Title: #964: util/watchdog: fixed watchdog implementation mzidek-rh commented: """ master: 2c13d8bd00f1e8ff30e9fc81f183f6450303ac30 """ See the full comment at https://github.com/SSSD/sssd/pull/964#issuecomment-565667557 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#963][+Pushed] Backport recent CI changes to sssd-1-16
URL: https://github.com/SSSD/sssd/pull/963 Title: #963: Backport recent CI changes to sssd-1-16 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#963][comment] Backport recent CI changes to sssd-1-16
URL: https://github.com/SSSD/sssd/pull/963 Title: #963: Backport recent CI changes to sssd-1-16 mzidek-rh commented: """ sssd-1-16: ec8f5fd5e040772a5a073dc839f8c630b523d1aa bcb79f67683a861fead3e626cdacdb8f41a486fb b9d419f844dcf40d4affcebce56015ed69af67db 7e6ab55b2678ccfb2314416d62c209f3db9f5233 d8eec7173e4095ba2187fdd191f7f77607fd47ce """ See the full comment at https://github.com/SSSD/sssd/pull/963#issuecomment-565666993 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#963][closed] Backport recent CI changes to sssd-1-16
URL: https://github.com/SSSD/sssd/pull/963 Author: mzidek-rh Title: #963: Backport recent CI changes to sssd-1-16 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/963/head:pr963 git checkout pr963 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#963][-Accepted] Backport recent CI changes to sssd-1-16
URL: https://github.com/SSSD/sssd/pull/963 Title: #963: Backport recent CI changes to sssd-1-16 Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#962][comment] nss: use real primary gid if the value is overriden (sssd-1-16)
URL: https://github.com/SSSD/sssd/pull/962 Title: #962: nss: use real primary gid if the value is overriden (sssd-1-16) mzidek-rh commented: """ sssd-1-16 80e6f714f6134a9ef7972fa5024d0d8c8e57c8d0 """ See the full comment at https://github.com/SSSD/sssd/pull/962#issuecomment-565666429 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#960][-Accepted] server/be: fix incorrect handling of SIGTERM
URL: https://github.com/SSSD/sssd/pull/960 Title: #960: server/be: fix incorrect handling of SIGTERM Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#960][closed] server/be: fix incorrect handling of SIGTERM
URL: https://github.com/SSSD/sssd/pull/960 Author: alexey-tikhonov Title: #960: server/be: fix incorrect handling of SIGTERM Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/960/head:pr960 git checkout pr960 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#960][+Pushed] server/be: fix incorrect handling of SIGTERM
URL: https://github.com/SSSD/sssd/pull/960 Title: #960: server/be: fix incorrect handling of SIGTERM Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#960][comment] server/be: fix incorrect handling of SIGTERM
URL: https://github.com/SSSD/sssd/pull/960 Title: #960: server/be: fix incorrect handling of SIGTERM mzidek-rh commented: """ master: 3f52de891cba55230730602d41c3811cf1b17d96 e41e9b37e4d3fcd8544fb6c591dafbaef0954438 1d4a7ffdcf8b303a40058db49d5e1be4bfb8271a """ See the full comment at https://github.com/SSSD/sssd/pull/960#issuecomment-565664899 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#965][comment] certmap: mention special regex characters in man page
URL: https://github.com/SSSD/sssd/pull/965 Title: #965: certmap: mention special regex characters in man page mzidek-rh commented: """ master: 21cb9fb28db1f2eb4ee770eb029bfe20233e4392 """ See the full comment at https://github.com/SSSD/sssd/pull/965#issuecomment-565663728 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#965][-Accepted] certmap: mention special regex characters in man page
URL: https://github.com/SSSD/sssd/pull/965 Title: #965: certmap: mention special regex characters in man page Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#965][closed] certmap: mention special regex characters in man page
URL: https://github.com/SSSD/sssd/pull/965 Author: sumit-bose Title: #965: certmap: mention special regex characters in man page Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/965/head:pr965 git checkout pr965 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#965][+Pushed] certmap: mention special regex characters in man page
URL: https://github.com/SSSD/sssd/pull/965 Title: #965: certmap: mention special regex characters in man page Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#958][closed] ldap_child: do not try PKINIT
URL: https://github.com/SSSD/sssd/pull/958 Author: sumit-bose Title: #958: ldap_child: do not try PKINIT Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/958/head:pr958 git checkout pr958 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#958][comment] ldap_child: do not try PKINIT
URL: https://github.com/SSSD/sssd/pull/958 Title: #958: ldap_child: do not try PKINIT mzidek-rh commented: """ master: * 580d61884b6c0a81357d8f9fa69fe69d1f017185 """ See the full comment at https://github.com/SSSD/sssd/pull/958#issuecomment-565662911 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#958][-Accepted] ldap_child: do not try PKINIT
URL: https://github.com/SSSD/sssd/pull/958 Title: #958: ldap_child: do not try PKINIT Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#958][+Pushed] ldap_child: do not try PKINIT
URL: https://github.com/SSSD/sssd/pull/958 Title: #958: ldap_child: do not try PKINIT Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#911][-Changes requested] Update pam_sss.8.xml
URL: https://github.com/SSSD/sssd/pull/911 Title: #911: Update pam_sss.8.xml Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#911][+Waiting for review] Update pam_sss.8.xml
URL: https://github.com/SSSD/sssd/pull/911 Title: #911: Update pam_sss.8.xml Label: +Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#960][-Waiting for review] server/be: fix incorrect handling of SIGTERM
URL: https://github.com/SSSD/sssd/pull/960 Title: #960: server/be: fix incorrect handling of SIGTERM Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#960][+Accepted] server/be: fix incorrect handling of SIGTERM
URL: https://github.com/SSSD/sssd/pull/960 Title: #960: server/be: fix incorrect handling of SIGTERM Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#960][comment] server/be: fix incorrect handling of SIGTERM
URL: https://github.com/SSSD/sssd/pull/960 Title: #960: server/be: fix incorrect handling of SIGTERM mzidek-rh commented: """ ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/960#issuecomment-565660393 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#965][comment] certmap: mention special regex characters in man page
URL: https://github.com/SSSD/sssd/pull/965 Title: #965: certmap: mention special regex characters in man page mzidek-rh commented: """ ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/965#issuecomment-565598155 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#965][+Accepted] certmap: mention special regex characters in man page
URL: https://github.com/SSSD/sssd/pull/965 Title: #965: certmap: mention special regex characters in man page Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#962][comment] nss: use real primary gid if the value is overriden (sssd-1-16)
URL: https://github.com/SSSD/sssd/pull/962 Title: #962: nss: use real primary gid if the value is overriden (sssd-1-16) mzidek-rh commented: """ CI passed. Just adding accepted label so I do not forget to push it later. """ See the full comment at https://github.com/SSSD/sssd/pull/962#issuecomment-565004008 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#962][+Accepted] nss: use real primary gid if the value is overriden (sssd-1-16)
URL: https://github.com/SSSD/sssd/pull/962 Title: #962: nss: use real primary gid if the value is overriden (sssd-1-16) Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#963][comment] Backport recent CI changes to sssd-1-16
URL: https://github.com/SSSD/sssd/pull/963 Title: #963: Backport recent CI changes to sssd-1-16 mzidek-rh commented: """ @alexey-tikhonov I think it does not need additional review, I will just add accepted label to not forget to push it. """ See the full comment at https://github.com/SSSD/sssd/pull/963#issuecomment-565003436 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#963][+Accepted] Backport recent CI changes to sssd-1-16
URL: https://github.com/SSSD/sssd/pull/963 Title: #963: Backport recent CI changes to sssd-1-16 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#961][-Accepted] INI: sssctl config-check command error messages
URL: https://github.com/SSSD/sssd/pull/961 Title: #961: INI: sssctl config-check command error messages Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#961][closed] INI: sssctl config-check command error messages
URL: https://github.com/SSSD/sssd/pull/961 Author: thalman Title: #961: INI: sssctl config-check command error messages Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/961/head:pr961 git checkout pr961 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#961][+Pushed] INI: sssctl config-check command error messages
URL: https://github.com/SSSD/sssd/pull/961 Title: #961: INI: sssctl config-check command error messages Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#961][comment] INI: sssctl config-check command error messages
URL: https://github.com/SSSD/sssd/pull/961 Title: #961: INI: sssctl config-check command error messages mzidek-rh commented: """ master: b626651847e188e89a332b8ac4bfaaa5047e1b3d """ See the full comment at https://github.com/SSSD/sssd/pull/961#issuecomment-564624452 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#959][closed] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/959 Author: alexey-tikhonov Title: #959: tests: fix race confition in enumeration tests Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/959/head:pr959 git checkout pr959 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#963][opened] Backport recent CI changes to sssd-1-16
URL: https://github.com/SSSD/sssd/pull/963
Author: mzidek-rh
Title: #963: Backport recent CI changes to sssd-1-16
Action: opened
PR body:
"""
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/963/head:pr963
git checkout pr963
From c2345a65ac542300385b414e2d3fcc78cca686df Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
Date: Wed, 4 Dec 2019 13:42:36 +0100
Subject: [PATCH 1/5] ci: add rhel7
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Reviewed-by: Michal Židek
---
Jenkinsfile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Jenkinsfile b/Jenkinsfile
index fc43db1ae2..cf4189ceab 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -10,6 +10,7 @@ def systems = [
'fedora30',
'fedora31',
'fedora-rawhide',
+ 'rhel7',
'debian10',
]
From 42ee5b827297753b2976b653c16536a88acc936e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
Date: Wed, 4 Dec 2019 13:44:37 +0100
Subject: [PATCH 2/5] ci: set sssd-ci notification to pending state when job is
started
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Reviewed-by: Michal Židek
---
Jenkinsfile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Jenkinsfile b/Jenkinsfile
index cf4189ceab..eec944bbdc 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -299,6 +299,8 @@ try {
}
stage('Prepare systems') {
+notification.notify('PENDING', 'Pending.')
+
/* Notify that all systems are pending. */
for (system in systems) {
notification.notify('PENDING', 'Awaiting executor', system)
From 69e21c88396c4d710a4227a12e4b0ecab9eed0ae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
Date: Thu, 5 Dec 2019 14:36:26 +0100
Subject: [PATCH 3/5] ci: archive ci-mock-result
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Reviewed-by: Michal Židek
---
contrib/test-suite/test-suite.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/test-suite/test-suite.yml b/contrib/test-suite/test-suite.yml
index 2b091349f6..49763fa4b6 100644
--- a/contrib/test-suite/test-suite.yml
+++ b/contrib/test-suite/test-suite.yml
@@ -8,4 +8,5 @@
- ci-*.log
- ci-build-debug/ci-*.log
- ci-build-debug/test-suite.log
+ - ci-build-debug/ci-mock-result/*.log
timeout: 6 hours
From 0b318323789140ed161cededcca20a617b2d5ff6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?=
Date: Wed, 9 Aug 2017 07:59:41 +0200
Subject: [PATCH 4/5] INTG: Increase the sleep() time so the changes are
reflected on SSSD
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Those tests have been failing a lot recently and it does happen becase
the time to reflect the changes on SSSD is not enough for the machine
where the tests are running.
There's no reasonable explanation in the code why 4 seconds is used as
INTERACTIVE_TIMEOUT, neither a reasonable explanation why 2 seconds is
used as the time waited in order to have those changes reflected on
SSSD (neither in the code nor in the commit messages).
This patch uses the most simple empiric way to determine a better value
for this timeout, which was "run the tests a considerable amount of time
and check that there were no failures".
So, in order to avoid failures and our tests giving us more reliable
information, let's give more time so the changes are reflected on SSSD.
Resolves:
https://pagure.io/SSSD/sssd/issue/3463
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Michal Židek
Reviewed-by: Alexey Tikhonov
---
src/tests/intg/test_enumeration.py | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/src/tests/intg/test_enumeration.py b/src/tests/intg/test_enumeration.py
index c105c6df02..c25588a566 100644
--- a/src/tests/intg/test_enumeration.py
+++ b/src/tests/intg/test_enumeration.py
@@ -33,6 +33,15 @@
from util import *
LDAP_BASE_DN = "dc=example,dc=com"
+
+# There is no explation neither in the code nor in the commit message that
+# introduced this timeout why 4 was chosen as value. The very same happens
+# with respect to why the time we should wait in order to have the changes
+# reflected on SSSD is INTERACTIVE_TIMEOUT/2.
+# Having INTERACTIVE_TIMEOUT/2 has been causing a lot of failures in some of
+# our CI tests, so it's been changed to INTERACTIVE_TIMEOUT and the way it's
+# been tested was just empirically by running or CI several times and checking
+# whether a failure happened or not.
INTERACTIVE_TIMEOUT = 4
@@ -412,7 +421,7 @@ def user_and_groups_rfc2307_bis(request, ldap_conn):
def test_add_remove_user(ldap_conn, blank_rfc2307):
"""Test user addition and removal are reflected by SSSD"""
e = ldap_ent.user(ldap_conn.ds_inst.base_dn, "user", 2001, 2000)
-time.sleep(INTERACTIVE_
[SSSD] [sssd PR#959][+Pushed] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/959 Title: #959: tests: fix race confition in enumeration tests Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#959][-Accepted] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/959 Title: #959: tests: fix race confition in enumeration tests Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#959][comment] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/959 Title: #959: tests: fix race confition in enumeration tests mzidek-rh commented: """ master: 116b144bc27d1eb8cd29813ed7eb7e674e8e189c 3477f2c28c5707cd90bccc6ebe81135fd49a2cde """ See the full comment at https://github.com/SSSD/sssd/pull/959#issuecomment-564596784 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#954][closed] nss: use real primary gid if the value is overriden
URL: https://github.com/SSSD/sssd/pull/954 Author: pbrezina Title: #954: nss: use real primary gid if the value is overriden Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/954/head:pr954 git checkout pr954 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#957][closed] ci: add RHEL 7
URL: https://github.com/SSSD/sssd/pull/957 Author: pbrezina Title: #957: ci: add RHEL 7 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/957/head:pr957 git checkout pr957 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#957][+Pushed] ci: add RHEL 7
URL: https://github.com/SSSD/sssd/pull/957 Title: #957: ci: add RHEL 7 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#957][comment] ci: add RHEL 7
URL: https://github.com/SSSD/sssd/pull/957 Title: #957: ci: add RHEL 7 mzidek-rh commented: """ master: c861a3909595566aedf14081e79597cafc8d172a 63c38d6131ad1ef9253d98ca5cf6f2318a740e55 97c96fd0667fead15ce45e336a052e4ed6faa754 """ See the full comment at https://github.com/SSSD/sssd/pull/957#issuecomment-564588100 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#957][-Accepted] ci: add RHEL 7
URL: https://github.com/SSSD/sssd/pull/957 Title: #957: ci: add RHEL 7 Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#954][comment] nss: use real primary gid if the value is overriden
URL: https://github.com/SSSD/sssd/pull/954 Title: #954: nss: use real primary gid if the value is overriden mzidek-rh commented: """ 1.16 PR: https://github.com/SSSD/sssd/pull/962 """ See the full comment at https://github.com/SSSD/sssd/pull/954#issuecomment-564555656 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#962][comment] nss: use real primary gid if the value is overriden (sssd-1-16)
URL: https://github.com/SSSD/sssd/pull/962 Title: #962: nss: use real primary gid if the value is overriden (sssd-1-16) mzidek-rh commented: """ This is cherry picked from master and applies cleanly on 1.16 branch. Re-submitting as sssd-1-16 PR to run it through CI. """ See the full comment at https://github.com/SSSD/sssd/pull/962#issuecomment-564555025 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#962][opened] nss: use real primary gid if the value is overriden (sssd-1-16)
URL: https://github.com/SSSD/sssd/pull/962
Author: mzidek-rh
Title: #962: nss: use real primary gid if the value is overriden (sssd-1-16)
Action: opened
PR body:
"""
SYSDB_PRIMARY_GROUP_GIDNUM contains original primary group id from AD
because any possible override may not be known at the time of storing
the user.
Now we try to lookup group by its originalADgidNumber and if it is found
we will replace the original id with real primary group id.
Steps to reproduce:
1. Enroll SSSD to IPA domain with AD trust
2. Add ID override to Domain Users `ipa idoverridegroup-add 'Default Trust
View' "Domain us...@ad.vm" --gid=4000`
3. On IPA server: Remove cache for the overrides to apply immediately and
restart SSSD `sssctl cache-remove --stop --start`
4. On IPA server: Resolve user `id administra...@ad.vm`
There will be visible both new and old gids without the patch.
Resolves:
https://pagure.io/SSSD/sssd/issue/4124
Reviewed-by: Sumit Bose
(cherry picked from commit 03bc96247cbd567ad11a4c693c1d90580f903bb7)
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/962/head:pr962
git checkout pr962
From 80e6f714f6134a9ef7972fa5024d0d8c8e57c8d0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
Date: Tue, 3 Dec 2019 13:29:00 +0100
Subject: [PATCH] nss: use real primary gid if the value is overriden
SYSDB_PRIMARY_GROUP_GIDNUM contains original primary group id from AD
because any possible override may not be known at the time of storing
the user.
Now we try to lookup group by its originalADgidNumber and if it is found
we will replace the original id with real primary group id.
Steps to reproduce:
1. Enroll SSSD to IPA domain with AD trust
2. Add ID override to Domain Users `ipa idoverridegroup-add 'Default Trust View' "Domain us...@ad.vm" --gid=4000`
3. On IPA server: Remove cache for the overrides to apply immediately and restart SSSD `sssctl cache-remove --stop --start`
4. On IPA server: Resolve user `id administra...@ad.vm`
There will be visible both new and old gids without the patch.
Resolves:
https://pagure.io/SSSD/sssd/issue/4124
Reviewed-by: Sumit Bose
(cherry picked from commit 03bc96247cbd567ad11a4c693c1d90580f903bb7)
---
src/db/sysdb.h | 7 +
src/db/sysdb_ops.c | 40 --
src/responder/nss/nss_protocol_grent.c | 14 +
3 files changed, 52 insertions(+), 9 deletions(-)
diff --git a/src/db/sysdb.h b/src/db/sysdb.h
index f8a2c87ae1..0e6e9266b5 100644
--- a/src/db/sysdb.h
+++ b/src/db/sysdb.h
@@ -208,6 +208,7 @@
#define SYSDB_GRNAM_FILTER "(&("SYSDB_GC")(|("SYSDB_NAME_ALIAS"=%s)("SYSDB_NAME_ALIAS"=%s)("SYSDB_NAME"=%s)))"
#define SYSDB_GRGID_FILTER "(&("SYSDB_GC")("SYSDB_GIDNUM"=%lu))"
+#define SYSDB_GRORIGGID_FILTER "(&("SYSDB_GC")("ORIGINALAD_PREFIX SYSDB_GIDNUM"=%lu))"
#define SYSDB_GRSID_FILTER "(&("SYSDB_GC")("SYSDB_SID_STR"=%s))"
#define SYSDB_GRENT_FILTER "("SYSDB_GC")"
#define SYSDB_GRNAM_MPG_FILTER "(&("SYSDB_MPGC")(|("SYSDB_NAME_ALIAS"=%s)("SYSDB_NAME_ALIAS"=%s)("SYSDB_NAME"=%s)))"
@@ -974,6 +975,12 @@ int sysdb_search_group_by_gid(TALLOC_CTX *mem_ctx,
const char **attrs,
struct ldb_message **msg);
+int sysdb_search_group_by_origgid(TALLOC_CTX *mem_ctx,
+ struct sss_domain_info *domain,
+ gid_t gid,
+ const char **attrs,
+ struct ldb_message **msg);
+
int sysdb_search_group_by_sid_str(TALLOC_CTX *mem_ctx,
struct sss_domain_info *domain,
const char *sid_str,
diff --git a/src/db/sysdb_ops.c b/src/db/sysdb_ops.c
index 262e123802..b51c821aec 100644
--- a/src/db/sysdb_ops.c
+++ b/src/db/sysdb_ops.c
@@ -763,14 +763,13 @@ int sysdb_search_group_by_name(TALLOC_CTX *mem_ctx,
return sysdb_search_by_name(mem_ctx, domain, name, SYSDB_GROUP, attrs, msg);
}
-/* Please note that sysdb_search_group_by_gid() is not aware of MPGs. If MPG
- * support is needed either the caller must handle it or sysdb_getgrgid() or
- * sysdb_getgrgid_attrs() should be used. */
-int sysdb_search_group_by_gid(TALLOC_CTX *mem_ctx,
- struct sss_domain_info *domain,
- gid_t gid,
- const char **attrs,
- struct ldb_message **msg)
+static int
+sysdb_search_group_by_id(TALLOC_CTX *mem_ctx,
+ struct sss_domain_info *domain,
+ const char *filterfmt,
+
[SSSD] [sssd PR#954][+Pushed] nss: use real primary gid if the value is overriden
URL: https://github.com/SSSD/sssd/pull/954 Title: #954: nss: use real primary gid if the value is overriden Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#954][-Accepted] nss: use real primary gid if the value is overriden
URL: https://github.com/SSSD/sssd/pull/954 Title: #954: nss: use real primary gid if the value is overriden Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#954][comment] nss: use real primary gid if the value is overriden
URL: https://github.com/SSSD/sssd/pull/954 Title: #954: nss: use real primary gid if the value is overriden mzidek-rh commented: """ master: 03bc96247cbd567ad11a4c693c1d90580f903bb7 """ See the full comment at https://github.com/SSSD/sssd/pull/954#issuecomment-564552101 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#944][+Pushed] 1.16: backport recent sudo improvements
URL: https://github.com/SSSD/sssd/pull/944 Title: #944: 1.16: backport recent sudo improvements Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#944][-Accepted] 1.16: backport recent sudo improvements
URL: https://github.com/SSSD/sssd/pull/944 Title: #944: 1.16: backport recent sudo improvements Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#944][closed] 1.16: backport recent sudo improvements
URL: https://github.com/SSSD/sssd/pull/944 Author: pbrezina Title: #944: 1.16: backport recent sudo improvements Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/944/head:pr944 git checkout pr944 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#944][comment] 1.16: backport recent sudo improvements
URL: https://github.com/SSSD/sssd/pull/944 Title: #944: 1.16: backport recent sudo improvements mzidek-rh commented: """ Added 8 commits to sssd-1-16: 634c1e0e439783fb11ec58994a97b1412bf3c0fb fd8865e802661ebc799d3d99dfc9c40137998c66 a1be9af749d08af2fd2f9d0c33b28836b7893072 19e8a02b0e1ddd57784200e519fc5c59141952ee fb2c54b69e7cc7990f50a93084e5f79fc6216102 3f370ad8c0d2d168a439e37b92c0b7a932e87050 38d00c4b44e18db950fc3d98757fa19cce8454a8 638431001164eeace976ed0d9db62a837a1ee426 """ See the full comment at https://github.com/SSSD/sssd/pull/944#issuecomment-564538064 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#961][+Accepted] INI: sssctl config-check command error messages
URL: https://github.com/SSSD/sssd/pull/961 Title: #961: INI: sssctl config-check command error messages Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#961][-Waiting for review] INI: sssctl config-check command error messages
URL: https://github.com/SSSD/sssd/pull/961 Title: #961: INI: sssctl config-check command error messages Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#961][comment] INI: sssctl config-check command error messages
URL: https://github.com/SSSD/sssd/pull/961 Title: #961: INI: sssctl config-check command error messages mzidek-rh commented: """ ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/961#issuecomment-564461714 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][closed] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Author: pbrezina Title: #956: tests: fix race confition in enumeration tests Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/956/head:pr956 git checkout pr956 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][comment] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Title: #956: tests: fix race confition in enumeration tests mzidek-rh commented: """ Superseeded in favor of #959 """ See the full comment at https://github.com/SSSD/sssd/pull/956#issuecomment-564093224 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][+superseded] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Title: #956: tests: fix race confition in enumeration tests Label: +superseded ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][-Changes requested] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Title: #956: tests: fix race confition in enumeration tests Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#959][-Waiting for review] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/959 Title: #959: tests: fix race confition in enumeration tests Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#959][+Accepted] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/959 Title: #959: tests: fix race confition in enumeration tests Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#959][comment] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/959 Title: #959: tests: fix race confition in enumeration tests mzidek-rh commented: """ I will add my additional ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/959#issuecomment-564088256 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][comment] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Title: #956: tests: fix race confition in enumeration tests mzidek-rh commented: """ Ok. So, let's go with the INTERACTIVE_TIMEOUT=2*ENUMERATION_TIMEOUT it is then. @pbrezina , can you make the change? """ See the full comment at https://github.com/SSSD/sssd/pull/956#issuecomment-563229817 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][+Changes requested] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Title: #956: tests: fix race confition in enumeration tests Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][comment] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Title: #956: tests: fix race confition in enumeration tests mzidek-rh commented: """ In other words, you think it is safer to have INTERACTIVE_TIMEOUT*2 where the previous /2 was? I think it makes sense. As I mentioned previously, I think that this may have been the original intention, even though practically INTERACTIVE_TIMEOUT may be good enough as well, but it is harder to justify. Removing the accepted label and adding changes requested. @pbrezina Will you please change the /2 to *2 (instead of just removing the /2) and re-run the tests a few times? """ See the full comment at https://github.com/SSSD/sssd/pull/956#issuecomment-562243930 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][-Accepted] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Title: #956: tests: fix race confition in enumeration tests Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#957][comment] ci: add RHEL 7
URL: https://github.com/SSSD/sssd/pull/957 Title: #957: ci: add RHEL 7 mzidek-rh commented: """ ACK. @pbrezina Just a comment. Do you know about a way to put the mock results into a subfolder or maybe prefix them with some string (for example mock-). It looks a but messy with all the artifacts on one level. Even if not, it is still an ack. """ See the full comment at https://github.com/SSSD/sssd/pull/957#issuecomment-562206060 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#957][+Accepted] ci: add RHEL 7
URL: https://github.com/SSSD/sssd/pull/957 Title: #957: ci: add RHEL 7 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][comment] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Title: #956: tests: fix race confition in enumeration tests mzidek-rh commented: """ In case we do clean the cache (rm) before each test run, the problem may be that the changes in LDAP were kind of slow to propagate after the fixture with function scope made them... so we need to wait for some time for the changes to take effect before we start requesting something from LDAP again. """ See the full comment at https://github.com/SSSD/sssd/pull/956#issuecomment-562199694 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][comment] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Title: #956: tests: fix race confition in enumeration tests mzidek-rh commented: """ The problem with these tests is that ldap_conn has scope=module and the fixture that fills the ldap contents before the test has scope=function (default), so there can be leftovers from previous test run in the passwd result (enumeration) after the fixture with function scope was executed, but the enumeration results are still cached in SSSD. I really do not know why we decided to go with INTERACTIVE_TIMEOUT/2 and I wonder if it was supposed to be INTERACTIVE_TIMEOUT*2 instead, which would make much more sense to me. However INTERACTIVE_TIMEOUT is probably ok as well, unless something slows SSSD really a lot. Now, of course we can speculate what number would be actually good... if this function fails in the future again, we can change it to INTERACTIVE_TIMEOUT * 2, but again, I do not have good explanation or justification other then "maybe sometimes SSSD will need more time for the cached enumeration result to actualy time out, despite the timeout being INTERACTIVE_TIMEOUT in the sssd.conf". Also the way we picked the INTERACTIVE_TIMEOUT was kind of "this seems to work" method. IIRC in the first version it was 2, but that turned out to not be enough in some cases and caused the tests to fail "sometimes". """ See the full comment at https://github.com/SSSD/sssd/pull/956#issuecomment-562197555 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#944][+Accepted] 1.16: backport recent sudo improvements
URL: https://github.com/SSSD/sssd/pull/944 Title: #944: 1.16: backport recent sudo improvements Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#944][comment] 1.16: backport recent sudo improvements
URL: https://github.com/SSSD/sssd/pull/944 Title: #944: 1.16: backport recent sudo improvements mzidek-rh commented: """ I think the changes are OK as they were reviewed before and only backported to 1.16, the patches were tested by a user, some very basic sanity testing was done and no issues were discovered. ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/944#issuecomment-562153805 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][+Accepted] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Title: #956: tests: fix race confition in enumeration tests Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#956][comment] tests: fix race confition in enumeration tests
URL: https://github.com/SSSD/sssd/pull/956 Title: #956: tests: fix race confition in enumeration tests mzidek-rh commented: """ I agree with the reasoning for this patch. ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/956#issuecomment-562150939 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#944][comment] 1.16: backport recent sudo improvements
URL: https://github.com/SSSD/sssd/pull/944 Title: #944: 1.16: backport recent sudo improvements mzidek-rh commented: """ I will do some sanity testing before ACKing as not all the changes here are covered by the integration tests in 1.16. Assigning to myself for now. """ See the full comment at https://github.com/SSSD/sssd/pull/944#issuecomment-559813939 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#946][+Accepted] INI: sssctl config-check giving the wrong message
URL: https://github.com/SSSD/sssd/pull/946 Title: #946: INI: sssctl config-check giving the wrong message Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#946][-Waiting for review] INI: sssctl config-check giving the wrong message
URL: https://github.com/SSSD/sssd/pull/946 Title: #946: INI: sssctl config-check giving the wrong message Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#946][comment] INI: sssctl config-check giving the wrong message
URL: https://github.com/SSSD/sssd/pull/946 Title: #946: INI: sssctl config-check giving the wrong message mzidek-rh commented: """ ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/946#issuecomment-559803241 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#946][+Changes requested] INI: sssctl config-check giving the wrong message
URL: https://github.com/SSSD/sssd/pull/946 Title: #946: INI: sssctl config-check giving the wrong message Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#946][comment] INI: sssctl config-check giving the wrong message
URL: https://github.com/SSSD/sssd/pull/946
Title: #946: INI: sssctl config-check giving the wrong message
mzidek-rh commented:
"""
This refactoring looks overall good to me. Few comments and nitpicks:
1. The last parameter in sss_ini_read_sssd_conf is always
CONFDB_FALLBACK_CONFIG. I do not think we need a parameter for something that
will always have the same value.
2. You have additional space between ! and sss_ini_exists
```
if (! sss_ini_exists(init_data)) {
```
3. You use macro PRINT for strings that cannot be translated. For example,
nobody can translate "%s\n":
```
-while (ref_array_get(ra, i, ) != NULL) {
-printf("%s\n", msg);
+while (ref_array_get(ra_success, i, ) != NULL) {
+PRINT("%s\n", msg);
i++;
}
```
This is not really a big issue, but it will result in unnecessary changes in
the pot files, so I think it is better to avoid using PRINT macro for
untranslatable strings. There are more PRINTs like this in this patch.
4. I think it would be good to add sssctl config-check integration test for the
case when no sssd.conf is present and there are some snippets into the
src/tests/intg/test_sssctl.py , but I will leave this to you.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/946#issuecomment-559352983
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#941][+Accepted] ipa: add failover to access checks and override lookups
URL: https://github.com/SSSD/sssd/pull/941 Title: #941: ipa: add failover to access checks and override lookups Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#941][comment] ipa: add failover to access checks and override lookups
URL: https://github.com/SSSD/sssd/pull/941 Title: #941: ipa: add failover to access checks and override lookups mzidek-rh commented: """ ACK. Sorry for the delay in review. I think this version is OK, the comments make it clear what should be changed in the future and backporting this will be definitely easier. """ See the full comment at https://github.com/SSSD/sssd/pull/941#issuecomment-559344793 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#941][comment] ipa: add failover to access checks and override lookups
URL: https://github.com/SSSD/sssd/pull/941 Title: #941: ipa: add failover to access checks and override lookups mzidek-rh commented: """ I plan to review this tomorrow. If somebody already started the review or wants to review this, feel free to re-assign. """ See the full comment at https://github.com/SSSD/sssd/pull/941#issuecomment-555980023 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#940][+Accepted] files_ops: Remove unused functions parameter
URL: https://github.com/SSSD/sssd/pull/940 Title: #940: files_ops: Remove unused functions parameter Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#940][comment] files_ops: Remove unused functions parameter
URL: https://github.com/SSSD/sssd/pull/940 Title: #940: files_ops: Remove unused functions parameter mzidek-rh commented: """ ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/940#issuecomment-555965564 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#939][+Accepted] sudo: use objectCategory instead of objectClass in ad sudo provider
URL: https://github.com/SSSD/sssd/pull/939 Title: #939: sudo: use objectCategory instead of objectClass in ad sudo provider Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#939][comment] sudo: use objectCategory instead of objectClass in ad sudo provider
URL: https://github.com/SSSD/sssd/pull/939 Title: #939: sudo: use objectCategory instead of objectClass in ad sudo provider mzidek-rh commented: """ ACK. Sorry, for the delay. I have not measured any performance improvement, but the ability to configure the parameter is a welcome one and according to the docs, there should be performance improvement at least in some cases. """ See the full comment at https://github.com/SSSD/sssd/pull/939#issuecomment-555962526 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#939][comment] sudo: use objectCategory instead of objectClass in ad sudo provider
URL: https://github.com/SSSD/sssd/pull/939 Title: #939: sudo: use objectCategory instead of objectClass in ad sudo provider mzidek-rh commented: """ I will try to review this tomorrow. Assigning to myself for now. """ See the full comment at https://github.com/SSSD/sssd/pull/939#issuecomment-553935620 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#940][comment] files_ops: Remove unused functions parameter
URL: https://github.com/SSSD/sssd/pull/940 Title: #940: files_ops: Remove unused functions parameter mzidek-rh commented: """ I will try to review this tomorrow. Assigning to myself for now. """ See the full comment at https://github.com/SSSD/sssd/pull/940#issuecomment-553934723 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#937][+Rejected] Unify the indentation to 4 spaces
URL: https://github.com/SSSD/sssd/pull/937 Title: #937: Unify the indentation to 4 spaces Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#938][+Rejected] Don't use tabs for indentation
URL: https://github.com/SSSD/sssd/pull/938 Title: #938: Don't use tabs for indentation Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#937][comment] Unify the indentation to 4 spaces
URL: https://github.com/SSSD/sssd/pull/937 Title: #937: Unify the indentation to 4 spaces mzidek-rh commented: """ Hi @miztake, I will NACK this for the same reason as stated here https://github.com/SSSD/sssd/pull/938 """ See the full comment at https://github.com/SSSD/sssd/pull/937#issuecomment-553821469 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
