[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-23 Thread lslebodn
  URL: https://github.com/SSSD/sssd/pull/514
Title: #514: Backport several UPN related patches to sssd-1-13

lslebodn commented:
"""
sssd-1-13:
* 99afca8926fb211774de457e750dea27da8ac3a9
* 42dbd7ee691ffef8b136fc310128aadfd91fd70c
* f6afb6f9418735bcfd125eb2bb2ffeeb5cc07d99
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/514#issuecomment-367949323
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-23 Thread lslebodn
  URL: https://github.com/SSSD/sssd/pull/514
Title: #514: Backport several UPN related patches to sssd-1-13

lslebodn commented:
"""
Thank you very much for additional info in commit messages.
ACK
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/514#issuecomment-367948868
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-22 Thread jhrozek
  URL: https://github.com/SSSD/sssd/pull/514
Title: #514: Backport several UPN related patches to sssd-1-13

jhrozek commented:
"""
Hi @lslebodn could you take a look at the patches no later than Monday? I'm on 
PTO the rest of the next week and I'd like the patches to be merged downstream 
sooner.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/514#issuecomment-367784874
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-22 Thread jhrozek
  URL: https://github.com/SSSD/sssd/pull/514
Title: #514: Backport several UPN related patches to sssd-1-13

jhrozek commented:
"""
It doesn't make much sense to backport commit afadeb1 because it fixes an issue 
that was only uncovered by the way cache-req evaluates results.

It looks like the patches from PR#496 don't conflict here, so I just amended 
the commit messages.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/514#issuecomment-367612479
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-21 Thread lslebodn
  URL: https://github.com/SSSD/sssd/pull/514
Title: #514: Backport several UPN related patches to sssd-1-13

lslebodn commented:
"""
As part of backporting patches for sanitizing sysdb filters, we found out that 
we might consider backporting also afadeb1a530ff010a2f9a7552562576b843c874b.

You might need to wait for CVE backport to avoid conflicts
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/514#issuecomment-367377399
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-15 Thread jhrozek
  URL: https://github.com/SSSD/sssd/pull/514
Title: #514: Backport several UPN related patches to sssd-1-13

jhrozek commented:
"""
Kind of a bit of both. If the cherry-pick conflict couldn't be resolved 
trivially, I just opened the code from master and adjusted sssd-1-13 to match 
the behaviour in master.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/514#issuecomment-365969076
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-15 Thread lslebodn
  URL: https://github.com/SSSD/sssd/pull/514
Title: #514: Backport several UPN related patches to sssd-1-13

lslebodn commented:
"""
The commits "Fix iterating to next domain for initgroup lookups" and "Make 
get_object_from_cache() aware of UPN searches" does not have any info about 
commits in other/newer branches.

Were they written from scratch? or you just forgot to mention that in commit 
message.
If it is just a subset of change from bigger patch in master then it would 
still be good to mention that in commit message. (or at least ticket partially 
fix that in master) 
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/514#issuecomment-365856535
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org