Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-09-08 Thread Pavel Reichl
On 09/08/2015 04:28 PM, Petr Cech wrote: On 09/04/2015 04:32 PM, Pavel Reichl wrote: On 08/28/2015 04:31 PM, Petr Cech wrote: + "Got request for [%#x][%s][%d][%s]\n", type, be_req2str(type), + attr_type, filter); Petr do you think it could be useful to print attr_type as

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-09-08 Thread Petr Cech
On 09/04/2015 04:32 PM, Pavel Reichl wrote: On 08/28/2015 04:31 PM, Petr Cech wrote: + "Got request for [%#x][%s][%d][%s]\n", type, be_req2str(type), + attr_type, filter); Petr do you think it could be useful to print attr_type as a string? We talked about it offline. It

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-09-04 Thread Pavel Reichl
On 08/28/2015 04:31 PM, Petr Cech wrote: + "Got request for [%#x][%s][%d][%s]\n", type, be_req2str(type), + attr_type, filter); Petr do you think it could be useful to print attr_type as a string? ___ sssd-devel mailing list

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-28 Thread Petr Cech
On 08/27/2015 01:26 PM, Lukas Slebodnik wrote: Petr, what do you think about small simplification. #include providers/data_provider_req.h +#define be_req_to_str(req_type, be_req_t) \ +((req_type) BE_REQ_FAST) \ +? FAST #be_req_t \ +: #be_req_t + const char

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-24 Thread Pavel Reichl
[snip] On 08/21/2015 05:10 PM, Pavel Reichl wrote: ACK Just adding link to passed ci (with exception of test test_ldap_id_cleanup which is false positive (and already fixed and acked on list)): http://sssd-ci.duckdns.org/logs/job/23/73/summary.html

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-21 Thread Pavel Reichl
On 08/21/2015 03:40 PM, Petr Cech wrote: On 08/21/2015 01:08 PM, Pavel Reichl wrote: Hello Petr, make dict check fails: /workspace/ci/label/rhel7/ci-build-debug/sssd-1.13.1/_inst/share/locale\ -g3 -O2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-21 Thread Petr Cech
On 08/21/2015 05:10 PM, Pavel Reichl wrote: Petr can you change data_provider_req.c to include providers/data_provider_req.h instead of providers/data_provider.h ? I originally thought that you will be able to include solely data_provider_req.h from responder_dp.c but I see that

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-21 Thread Pavel Reichl
On 08/21/2015 05:49 PM, Petr Cech wrote: On 08/21/2015 05:10 PM, Pavel Reichl wrote: Petr can you change data_provider_req.c to include providers/data_provider_req.h instead of providers/data_provider.h ? I originally thought that you will be able to include solely data_provider_req.h

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-18 Thread Petr Cech
On 08/05/2015 11:23 AM, Jakub Hrozek wrote: B) While writing a patch Lukas noticed another similar logging messages [sssd[pam]] [sss_dp_get_account_msg] (0x0400): Creating request for [LDAP][3][1][name=mof_user6] I investigated it. This is the same thing -- BE_REQ_*, but it is no longer

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-05 Thread Pavel Reichl
On 07/15/2015 08:53 AM, Petr Cech wrote: Hi, I investigated the situation around the log message, which mentioned Lukas. I prepared this patch. The result is that the original message [sssd[be[cygnus.dev]]] [be_get_account_info] (0x0200): Got request for [0x1001][1][name=celestian]

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-05 Thread Jakub Hrozek
On Wed, Aug 05, 2015 at 10:03:30AM +0200, Pavel Reichl wrote: On 07/15/2015 08:53 AM, Petr Cech wrote: Hi, I investigated the situation around the log message, which mentioned Lukas. I prepared this patch. The result is that the original message [sssd[be[cygnus.dev]]]

[SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-07-15 Thread Petr Cech
Hi, I investigated the situation around the log message, which mentioned Lukas. I prepared this patch. The result is that the original message [sssd[be[cygnus.dev]]] [be_get_account_info] (0x0200): Got request for [0x1001][1][name=celestian] changed to [sssd[be[cygnus.dev]]]