Re: [SSSD] [PATCH] Monitor: Show service pings at debug level 8

[Lukas Slebodnik]

On (27/10/15 15:41), Petr Cech wrote:
>On 10/27/2015 02:58 PM, Stephen Gallagher wrote:
>>SSSDBG_CONF_SETTINGS is reserved for configuration information. These
>>pings are generally just noise (when they fail, this is logged at
>>SSDBG_FATAL_FAILURE). We should only log these at SSSDBG_TRACE_INTERNAL.
>
>Hi Stephen,
>
>CI tests are right:
>http://sssd-ci.duckdns.org/logs/job/31/44/summary.html
>
>=> ACK
>
+DEBUG(SSSDBG_TRACE_INTERNAL,"Pinging %s\n", svc->name);
 ^
I hope you don't mind that I fixed missing space
before pushing.

master:
* 284c22c191963f11e5c07ba6d14dcd8dc7e494fe

It reduce "a noise" in log files and it's trvivila change therefore:
sssd-1-13:
* 6f6622cfe0fdfa5a3522566cd83217e6d628e924

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Monitor: Show service pings at debug level 8

[Petr Cech]

On 10/27/2015 02:58 PM, Stephen Gallagher wrote:

SSSDBG_CONF_SETTINGS is reserved for configuration information. These
pings are generally just noise (when they fail, this is logged at
SSDBG_FATAL_FAILURE). We should only log these at SSSDBG_TRACE_INTERNAL.


Hi Stephen,

CI tests are right:
http://sssd-ci.duckdns.org/logs/job/31/44/summary.html

=> ACK

Petr
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] Monitor: Show service pings at debug level 8

[Stephen Gallagher]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

SSSDBG_CONF_SETTINGS is reserved for configuration information. These
pings are generally just noise (when they fail, this is logged at
SSDBG_FATAL_FAILURE). We should only log these at SSSDBG_TRACE_INTERNAL.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iEYEARECAAYFAlYvgvQACgkQeiVVYja6o6NeVQCgocyUqrHud6p+KyyDULRdtx+/
Vj0AoIEfXJAbEgwDEgAmDJBuRLNv0v+n
=h2IT
-END PGP SIGNATURE-
>From 9a53c342335ce68ec8196c5d05fecf8e12197411 Mon Sep 17 00:00:00 2001
From: Stephen Gallagher 
Date: Tue, 27 Oct 2015 09:55:11 -0400
Subject: [PATCH] Monitor: Show service pings at debug level 8

SSSDBG_CONF_SETTINGS is reserved for configuration information. These
pings are generally just noise (when they fail, this is logged at
SSDBG_FATAL_FAILURE). We should only log these at SSSDBG_TRACE_INTERNAL.
---
 src/monitor/monitor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
index 3776caba4ea8644e57bde098c7a6895093cbb9d3..9a634340424debd64080588ba814b9189ea16d04 100644
--- a/src/monitor/monitor.c
+++ b/src/monitor/monitor.c
@@ -2528,11 +2528,11 @@ static int service_send_ping(struct mt_svc *svc)
 if (!svc->conn) {
 DEBUG(SSSDBG_TRACE_INTERNAL, "Service not yet initialized\n");
 return ENXIO;
 }
 
-DEBUG(SSSDBG_CONF_SETTINGS,"Pinging %s\n", svc->name);
+DEBUG(SSSDBG_TRACE_INTERNAL,"Pinging %s\n", svc->name);
 
 /*
  * Set up identity request
  * This should be a well-known path and method
  * for all services
@@ -2590,11 +2590,11 @@ static void ping_check(DBusPendingCall *pending, void *data)
 switch (type) {
 case DBUS_MESSAGE_TYPE_METHOD_RETURN:
 /* ok peer replied,
  * make sure we reset the failure counter in the service structure */
 
-DEBUG(SSSDBG_CONF_SETTINGS,"Service %s replied to ping\n", svc->name);
+DEBUG(SSSDBG_TRACE_INTERNAL,"Service %s replied to ping\n", svc->name);
 
 svc->failed_pongs = 0;
 break;
 
 case DBUS_MESSAGE_TYPE_ERROR:
-- 
2.5.0



0001-Monitor-Show-service-pings-at-debug-level-8.patch.sig
Description: PGP signature
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel