Re: [SSSD] [PATCH] PAM: only allow missing user name for certificate

2015-10-02 Thread Lukas Slebodnik
On (02/10/15 12:11), Lukas Slebodnik wrote: >On (02/10/15 10:21), Sumit Bose wrote: >>On Thu, Oct 01, 2015 at 03:12:06PM +0200, Pavel Reichl wrote: >>> >>> >>diff --git a/src/responder/pam/pamsrv_cmd.c >>> >>b/src/responder/pam/pamsrv_cmd.c >>> >>index >>>

Re: [SSSD] [PATCH] PAM: only allow missing user name for certificate

2015-10-02 Thread Lukas Slebodnik
On (02/10/15 10:21), Sumit Bose wrote: >On Thu, Oct 01, 2015 at 03:12:06PM +0200, Pavel Reichl wrote: >> >> >>diff --git a/src/responder/pam/pamsrv_cmd.c >> >>b/src/responder/pam/pamsrv_cmd.c >> >>index >> >>27dddcf43c1ff6eb465e1cb58d6dddf21413dcc4..978c637e22b03d3be1e07e8dc713aa01c4bb22e5 >>

Re: [SSSD] [PATCH] PAM: only allow missing user name for certificate

2015-10-02 Thread Sumit Bose
On Thu, Oct 01, 2015 at 03:12:06PM +0200, Pavel Reichl wrote: > > >>diff --git a/src/responder/pam/pamsrv_cmd.c b/src/responder/pam/pamsrv_cmd.c > >>index > >>27dddcf43c1ff6eb465e1cb58d6dddf21413dcc4..978c637e22b03d3be1e07e8dc713aa01c4bb22e5 > >> 100644 > >>--- a/src/responder/pam/pamsrv_cmd.c >

Re: [SSSD] [PATCH] PAM: only allow missing user name for certificate

2015-10-01 Thread Pavel Reichl
diff --git a/src/responder/pam/pamsrv_cmd.c b/src/responder/pam/pamsrv_cmd.c index 27dddcf43c1ff6eb465e1cb58d6dddf21413dcc4..978c637e22b03d3be1e07e8dc713aa01c4bb22e5 100644 --- a/src/responder/pam/pamsrv_cmd.c +++ b/src/responder/pam/pamsrv_cmd.c @@ -957,11 +957,13 @@ static errno_t

Re: [SSSD] [PATCH] PAM: only allow missing user name for certificate

2015-10-01 Thread Lukas Slebodnik
On (01/10/15 10:57), Sumit Bose wrote: >Hi, > >this patch aims to fix https://fedorahosted.org/sssd/ticket/2811. It >occurs if the client of sssd_pam does not provide a user name during >pre-auth and certificate/Smartcard authentication is not enabled. > >I relaxed the user name check when adding

[SSSD] [PATCH] PAM: only allow missing user name for certificate

2015-10-01 Thread Sumit Bose
Hi, this patch aims to fix https://fedorahosted.org/sssd/ticket/2811. It occurs if the client of sssd_pam does not provide a user name during pre-auth and certificate/Smartcard authentication is not enabled. I relaxed the user name check when adding the Smartcard support and added tests as well