Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-16 Thread Jakub Hrozek
On Mon, Nov 16, 2015 at 08:12:06AM +0100, Petr Cech wrote: > >+struct be_sbus_reply_data { > >+dbus_uint16_t err_maj; > >+dbus_uint32_t err_min; > >+const char *err_msg; > >+}; > >+ > >+#define BE_SBUS_REPLY_DATA_INIT { .err_maj = DP_ERR_FATAL, \ >

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-16 Thread Pavel Březina
On 11/11/2015 02:28 PM, Jakub Hrozek wrote: Hi, I think one of the prime reasons for #2861 was copy-pasting code. The two attached patches reduce the code duplication and hopefully will make future additions to Data Provider safer. Ideas on different solutions are welcome! +static errno_t

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-15 Thread Petr Cech
On 11/11/2015 02:28 PM, Jakub Hrozek wrote: Hi, I think one of the prime reasons for #2861 was copy-pasting code. The two attached patches reduce the code duplication and hopefully will make future additions to Data Provider safer. Ideas on different solutions are welcome! Hello Jakub, I

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-14 Thread Jakub Hrozek
On Fri, Nov 13, 2015 at 08:29:42AM +0100, Petr Cech wrote: > On 11/12/2015 01:08 PM, Jakub Hrozek wrote: > >On Thu, Nov 12, 2015 at 01:03:33PM +0100, Petr Cech wrote: > >>>On 11/11/2015 02:28 PM, Jakub Hrozek wrote: > >Hi, > > > >I think one of the prime reasons for #2861 was

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-12 Thread Petr Cech
On 11/11/2015 02:28 PM, Jakub Hrozek wrote: Hi, I think one of the prime reasons for #2861 was copy-pasting code. The two attached patches reduce the code duplication and hopefully will make future additions to Data Provider safer. Ideas on different solutions are welcome! Hi Jakub, I am

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-12 Thread Jakub Hrozek
On Thu, Nov 12, 2015 at 01:03:33PM +0100, Petr Cech wrote: > On 11/11/2015 02:28 PM, Jakub Hrozek wrote: > >Hi, > > > >I think one of the prime reasons for #2861 was copy-pasting code. The > >two attached patches reduce the code duplication and hopefully will make > >future additions to Data

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-12 Thread Petr Cech
On 11/12/2015 01:08 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 01:03:33PM +0100, Petr Cech wrote: >On 11/11/2015 02:28 PM, Jakub Hrozek wrote: > >Hi, > > > >I think one of the prime reasons for #2861 was copy-pasting code. The > >two attached patches reduce the code duplication and

[SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-11 Thread Jakub Hrozek
Hi, I think one of the prime reasons for #2861 was copy-pasting code. The two attached patches reduce the code duplication and hopefully will make future additions to Data Provider safer. Ideas on different solutions are welcome! >From f6e929d4132a23d23a9016e43f4b870780c53032 Mon Sep 17 00:00:00