Re: [SSSD] [PATCH] TESTS: Removing part of responder_cache_req-tests

2015-08-31 Thread Jakub Hrozek
On Thu, Aug 27, 2015 at 01:05:00PM +0200, Lukas Slebodnik wrote: > On (24/08/15 16:09), Michal Židek wrote: > >On 08/21/2015 04:55 PM, Petr Cech wrote: > >>On 08/21/2015 02:35 PM, Michal Židek wrote: > >>>Hi, > >>> > >>>some of the tests you deleted are valid and > >>>should not be deleted. > >>>

Re: [SSSD] [PATCH] TESTS: Removing part of responder_cache_req-tests

2015-08-31 Thread Michal Židek
On 08/31/2015 06:29 PM, Jakub Hrozek wrote: On Thu, Aug 27, 2015 at 01:05:00PM +0200, Lukas Slebodnik wrote: On (24/08/15 16:09), Michal Židek wrote: On 08/21/2015 04:55 PM, Petr Cech wrote: On 08/21/2015 02:35 PM, Michal Židek wrote: Hi, some of the tests you deleted are valid and should

Re: [SSSD] [PATCH] TESTS: Removing part of responder_cache_req-tests

2015-08-27 Thread Lukas Slebodnik
On (24/08/15 16:09), Michal Židek wrote: On 08/21/2015 04:55 PM, Petr Cech wrote: On 08/21/2015 02:35 PM, Michal Židek wrote: Hi, some of the tests you deleted are valid and should not be deleted. Only those tests that rely on time(NULL) being the same as the time of request creation are

Re: [SSSD] [PATCH] TESTS: Removing part of responder_cache_req-tests

2015-08-24 Thread Michal Židek
On 08/21/2015 04:55 PM, Petr Cech wrote: On 08/21/2015 02:35 PM, Michal Židek wrote: Hi, some of the tests you deleted are valid and should not be deleted. Only those tests that rely on time(NULL) being the same as the time of request creation are invalid. All those that test old entries or

Re: [SSSD] [PATCH] TESTS: Removing part of responder_cache_req-tests

2015-08-21 Thread Petr Cech
On 08/21/2015 02:35 PM, Michal Židek wrote: Hi, some of the tests you deleted are valid and should not be deleted. Only those tests that rely on time(NULL) being the same as the time of request creation are invalid. All those that test old entries or nonexistent entries are OK. See comments