Re: [SSSD] [PATCH] sudo: print message if old protocol is used

2012-11-29 Thread Jakub Hrozek
On Thu, Nov 15, 2012 at 05:54:26PM +0100, Pavel Březina wrote: Nitpicking, but for this kind of situations I think a switch/case statement would be much more clear (also avoids adding a variable as you use it once): switch(cli_ctx-cli_protocol_version-version) { case 0: DEBUG(..);

[SSSD] [PATCH] sudo: print message if old protocol is used

2012-11-15 Thread Pavel Březina
I believe the patch explains itself. From ba7b4bf8d7c97f43d286728000a6f30c713f7a1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrez...@redhat.com Date: Tue, 13 Nov 2012 13:31:56 +0100 Subject: [PATCH 1/3] sudo: print message if old protocol is used ---

Re: [SSSD] [PATCH] sudo: print message if old protocol is used

2012-11-15 Thread Simo Sorce
On Thu, 2012-11-15 at 12:13 +0100, Pavel Březina wrote: @@ -185,9 +186,14 @@ static int sudosrv_cmd(enum sss_sudo_type type, struct cli_ctx *cli_ctx) } /* if protocol is invalid return */ -if (cli_ctx-cli_protocol_version-version != SSS_SUDO_PROTOCOL_VERSION) { -