Re: [SSSD] [PATCH 5/5] Use an entry type mask macro to filter entry types

2012-11-29 Thread Pavel Březina
Ack, but I'd like to consider using macro for: (ar-entry_type BE_REQ_TYPE_MASK) Something like: BE_GET_REQ_TYPE(request) (request BE_REQ_TYPE_MASK) ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH 5/5] Use an entry type mask macro to filter entry types

2012-11-29 Thread Simo Sorce
On Thu, 2012-11-29 at 11:48 +0100, Pavel Březina wrote: Ack, but I'd like to consider using macro for: (ar-entry_type BE_REQ_TYPE_MASK) Something like: BE_GET_REQ_TYPE(request) (request BE_REQ_TYPE_MASK) Good idea, I'll add that. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH 5/5] Use an entry type mask macro to filter entry types

2012-11-27 Thread Pavel Březina
Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH 5/5] Use an entry type mask macro to filter entry types

2012-11-23 Thread Simo Sorce
Avoids hardcoding magic numbers everywhere and self documents why a mask is being applied. --- src/providers/data_provider.h |1 + src/providers/ipa/ipa_id.c|2 +- src/providers/ipa/ipa_subdomains_id.c |2 +- src/providers/ldap/ldap_id.c |2 +-

[SSSD] [PATCH 5/5] Use an entry type mask macro to filter entry types

2012-11-07 Thread Simo Sorce
Avoids hardcoding magic numbers everywhere and self documents why a mask is being applied. --- src/providers/data_provider.h |1 + src/providers/ipa/ipa_id.c|2 +- src/providers/ipa/ipa_subdomains_id.c |2 +- src/providers/ldap/ldap_id.c |2 +-

Re: [SSSD] [PATCH 5/5] Use an entry type mask macro to filter entry types

2012-11-06 Thread Jakub Hrozek
On Wed, Oct 31, 2012 at 06:37:35PM -0400, Simo Sorce wrote: Avoids hardcodinf magic numbers everywhere and selfdocuments why a mask is being applied. --- src/providers/data_provider.h |1 + src/providers/ipa/ipa_id.c|2 +- src/providers/ipa/ipa_subdomains_id.c |

[SSSD] [PATCH 5/5] Use an entry type mask macro to filter entry types

2012-10-31 Thread Simo Sorce
Avoids hardcodinf magic numbers everywhere and selfdocuments why a mask is being applied. --- src/providers/data_provider.h |1 + src/providers/ipa/ipa_id.c|2 +- src/providers/ipa/ipa_subdomains_id.c |2 +- src/providers/ldap/ldap_id.c |2 +-

[SSSD] [PATCH 5/5] Use an entry type mask macro to filter entry types

2012-10-23 Thread Simo Sorce
Avoids hardcodinf magic numbers everywhere and selfdocuments why a mask is being applied. Signed-off-by: Simo Sorce s...@redhat.com --- src/providers/data_provider.h | 1 + src/providers/ipa/ipa_id.c| 2 +- src/providers/ipa/ipa_subdomains_id.c | 2 +-