[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Umm sorry, the ranges are not so nice, let's list the commits * master: * 25699846bd1c9f8bb513b6271eb4366ab682fbd2 * 49d3f0a487d55571b2bdc9d3f8280b304b964b9d *

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ sssd-1-4: ec1829d..c1f3b29 """ See the full comment at https://github.com/SSSD/sssd/pull/57#issuecomment-257277120 ___

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ * master: * cbee11e..2569984 """ See the full comment at https://github.com/SSSD/sssd/pull/57#issuecomment-257273464

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/56/05/summary.html Coverity also didn't find any errors. For some reason, re-running just the tests that failed previously

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Thank you, this version reads better to me and still works fine (adding and removing the global group as well..) So far ACK, I will push the patch once I'm able

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-25 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users sumit-bose commented: """ On Fri, Oct 21, 2016 at 01:22:08AM -0700, Jakub Hrozek wrote: > Hmm, looks like github ate my mail, so let's paste the comment again (and > sorry if it arrives

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-25 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users lslebodn commented: """ On (21/10/16 01:22), Jakub Hrozek wrote: >Hmm, looks like github ate my mail, so let's paste the comment again (and >sorry if it arrives twice). Coverity detected

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-25 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Thanks for the changes, at least with the previous version all the tests with the domain-local groups were working for me and the internal ad_forest test didn't

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-25 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users lslebodn commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/57#issuecomment-255969624 ___

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Hmm, looks like github ate my mail, so let's paste the comment again (and sorry if it arrives twice). Coverity detected some warnings: ``` Error: COMPILER_WARNING: