[SSSD] [sssd PR#5945][comment] INTG: Restrict smartcard in sc auth tests

2022-01-18 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests sumit-bose commented: """ Hi, thank you. ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5945#issuecomment-1015169276

[SSSD] [sssd PR#5945][comment] INTG: Restrict smartcard in sc auth tests

2022-01-17 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests justin-stephenson commented: """ > Hi, > > thanks, I'm still fine with the patches. I'd just like to ask to split out > the change to `pamsrv_p11.c` into an extra patch? The change is not only

[SSSD] [sssd PR#5945][comment] INTG: Restrict smartcard in sc auth tests

2022-01-17 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests sumit-bose commented: """ Hi, thanks, I'm still fine with the patches. I'd just like to ask to split out the change to `pamsrv_p11.c` into an extra patch? The change is not only related to the

[SSSD] [sssd PR#5945][comment] INTG: Restrict smartcard in sc auth tests

2022-01-14 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests justin-stephenson commented: """ > Please hold off on pushing this, I found that pam-srv-tests unit tests are > failing also for the same reason. I'd like to add a commit here to fix this. I

[SSSD] [sssd PR#5945][comment] INTG: Restrict smartcard in sc auth tests

2022-01-14 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests justin-stephenson commented: """ Please hold off on pushing this, I found that pam-srv-tests unit tests are failing also for the same reason. I'd like to add a commit here to fix this. """ See

[SSSD] [sssd PR#5945][comment] INTG: Restrict smartcard in sc auth tests

2022-01-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5945 Title: #5945: INTG: Restrict smartcard in sc auth tests sumit-bose commented: """ Hi, thanks for the patch, it should make the Smartcard auth unit tests more resilient. ACK bye, Sumit """ See the full comment at