[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out fidencio commented: """ master: 4937f2c """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-411796606 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/ZHERZWWLVPGY7BA6SQ2CSTJ7CXPRPNME/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out fidencio commented: """ We agreed on merging the PR during our team meeting. """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-411795873 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/EW2YI7GYU4GWVODRRB4MHHIADGTZFIZE/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out fidencio commented: """ I see. We'll have a phone call Today and discuss this patch within SSSD team. Although we don't have nor follow any "governance", I do believe that nowadays we would be able to have an agreement based on https://libvirt.org/governance.html#roughconsensus :-) I'll update the status of the patch based on our phone call later Today. """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-411704304 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/44RNHZU6DM5OR366P66JPOOOG76R6SSA/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out fidencio commented: """ I see. We'll have a phone call Today and discuss this patch within SSSD team. Although we don't have nor follow any "governance", I do believe that nowadays would be able to have an agreement based on https://libvirt.org/governance.html#roughconsensus :-) I'll update the status of the patch based on our phone call later Today. """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-411704304 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/7QWGDRYMCJCO5OANWOODXBAQJ3DOIWB7/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out asheplyakov commented: """ @fidencio > would you have a cache dump, logs or even a machine that you could give us > access Unfortunately no. That was a client's machine, and we had no permission to copy any logs in first place. We couldn't reproduce the problem locally, perhaps it takes some tricky AD setup (and we had no permission examine their AD configuration). """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-411689819 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/UX6MHI62RTDA3EDMT6IMHYFGL5JNT2JC/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out fidencio commented: """ Although the patch looks good, after a conversation with @jhrozek ... I have my mind made that we may be just papering over a more critical bug. I'm removing the "Accepted" label but keeping the PR opened. @asheplyakov, would you have a cache dump, logs or even a machine that you could give us access (via tmate) so we could nail this issue down and find out why we have incomplete groups in the first place? """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-411658336 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/LYH27LZVCJYOAVFBOTOUN2RUZ2KX3NVP/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out jhrozek commented: """ I'm not against this patch (I just had no time so far to do any test) but my primary question is why do we have the incomplete groups in the cache? I thought if we could only read the SID from the tokengroups but then not resolve the SID then we would have a group name stored with name=sid. So I don't think there's anything wrong with the patch, I just wonder if we would be papering over another bug with it. """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-405348786 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/HFZ5ANXXVU6CPO2UIE7GVNHT6JCIMXRQ/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out fidencio commented: """ Adding the "Accepted" label. I'll push on Wednesday, in order to give @jhrozek some time to answer as well. Thanks a lot for your contribution and quick response @asheplyakov. """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-405286334 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/LSRRWL6SVVAWRR75EANNCDTDOYSCTQGK/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out asheplyakov commented: """ @fidencio: I'm OK with the proposed commit message change """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-405263666 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/JA6INQYEPNAGFSRSJYN63QHLGXDA6FQJ/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out fidencio commented: """ CI results were okay, apart from the known issues. @asheplyakov, there's one nitpick about the patch that I'd like to ask your permission to fix it locally before pushing. Our commit template is something towards the lines of: ``` component: subject explanation reference to the issue solved (when there's a bz/issue about that) ``` If you agree, I'd like to do a: `s/nss_protocol_fill_initgr/nss/` in the component part of your patch. Please, mind that you don't have to re-submit the patch for this change, just gimme your ack that I'll do it before pushing. """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-405200329 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/V2KU2MUPB4H6723NV6PUHFQN5N4HV7CT/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out fidencio commented: """ @asheplyakov, thanks for the contribution. This patch does look correct to me. I'll just fire a run of our internal CI (for the sake of the process) and as soon as I get the results the "Accepted" label will be added. @jhrozek, please, feel free to step up if you think I'm missing something here. """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-405158872 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/VFCTRBEH5YOEMFUUWIY5A63KJ2YFKQE3/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out fidencio commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-403871241 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/FN76ZGEDZGY3Z4KLN47UCWRKZFYSRUKG/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-403867722 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/B2M54BM4ZWTT5FWAZ7OVOFEO2ICFHSY2/
[SSSD] [sssd PR#614][comment] nss_protocol_fill_initgr: skip incomplete groups instead of bailing out
URL: https://github.com/SSSD/sssd/pull/614 Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of bailing out centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/614#issuecomment-403867723 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/KCE4AR22AQXEKR2NKISVFLTE3NTX44Z2/
