[SSSD] [sssd PR#631][comment] nss: remove unused label

2018-08-10 Thread fidencio
  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

fidencio commented:
"""
master:
 e8b417e
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/631#issuecomment-412120488
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/I76MPRW362XEL3RT7B4C4KSBTWDK3QWR/


[SSSD] [sssd PR#631][comment] nss: remove unused label

2018-08-10 Thread sumit-bose
  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

sumit-bose commented:
"""
Ok, CI passed with an unrealated issue. ACK.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/631#issuecomment-412110512
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/YWI6V25LUEMJO2JSKKUISAEJT4T4AQ3D/


[SSSD] [sssd PR#631][comment] nss: remove unused label

2018-08-10 Thread sumit-bose
  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

sumit-bose commented:
"""
Thanks, I've started a CI run.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/631#issuecomment-411987087
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/3OF63SC5LCHMCZL2ZGAA5QRF24RFPEHZ/


[SSSD] [sssd PR#631][comment] nss: remove unused label

2018-08-09 Thread fidencio
  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

fidencio commented:
"""
@sumit-bose, I've changed my mind and fully adopted your suggestion in one 
single patch.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/631#issuecomment-411858930
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/VGHBDCXDYU37XN4YLSJZAEVZBVP43AG2/


[SSSD] [sssd PR#631][comment] nss: remove unused label

2018-08-09 Thread fidencio
  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

fidencio commented:
"""
I agree with your comment (but maybe I would prefer to have your suggestion as 
a separate patch of this very same PR).

Would you mind pushing this as it is in order to fix the breakage asap?

(sorry for the typos and for not doing the change now, I am commiting without 
access to my laptop).
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/631#issuecomment-411817670
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/QKTDZ2DKIDNBAAZSYDXRJHLGBSX7GPIT/


[SSSD] [sssd PR#631][comment] nss: remove unused label

2018-08-09 Thread sumit-bose
  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

sumit-bose commented:
"""
I had a minor comment (see inline), please let me know if you agree or if you 
think that it would be safer to keep this patch minimal.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/631#issuecomment-411814461
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/VPTPRTINAHTG3E5ZADVQNMGCVWMJBTDP/