[SSSD] [sssd PR#700][comment] LDAP: Only authenticate the auth connection if we need to look up user information

2018-11-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/700 Title: #700: LDAP: Only authenticate the auth connection if we need to look up user information jhrozek commented: """ btw I opened https://pagure.io/SSSD/sssd/issue/3889 to track the additional hardening. Maybe it would be a nice task for one of the

[SSSD] [sssd PR#700][comment] LDAP: Only authenticate the auth connection if we need to look up user information

2018-11-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/700 Title: #700: LDAP: Only authenticate the auth connection if we need to look up user information jhrozek commented: """ * sssd-1-16: 1a7c6ab6efce3720d27def426aad49ee99eb339d

[SSSD] [sssd PR#700][comment] LDAP: Only authenticate the auth connection if we need to look up user information

2018-11-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/700 Title: #700: LDAP: Only authenticate the auth connection if we need to look up user information jhrozek commented: """ * master: * 6f113c7ddeaa5c82558e10118b499d22bf7a2b14

[SSSD] [sssd PR#700][comment] LDAP: Only authenticate the auth connection if we need to look up user information

2018-11-26 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/700 Title: #700: LDAP: Only authenticate the auth connection if we need to look up user information sumit-bose commented: """ thank, I'm fine with the current version, so ACK in Acepted are still valid. About "If we want to do additional hardening, we

[SSSD] [sssd PR#700][comment] LDAP: Only authenticate the auth connection if we need to look up user information

2018-11-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/700 Title: #700: LDAP: Only authenticate the auth connection if we need to look up user information jhrozek commented: """ thanks, I added your newest patch version to this PR """ See the full comment at

[SSSD] [sssd PR#700][comment] LDAP: Only authenticate the auth connection if we need to look up user information

2018-11-26 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/700 Title: #700: LDAP: Only authenticate the auth connection if we need to look up user information sumit-bose commented: """ Thanks, yes, I'm fine with the changes. However, I just came across ldap_tls_inplace() which we already use and I guess it more

[SSSD] [sssd PR#700][comment] LDAP: Only authenticate the auth connection if we need to look up user information

2018-11-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/700 Title: #700: LDAP: Only authenticate the auth connection if we need to look up user information jhrozek commented: """ Thank you, this is nice. I added your patch to the PR, fixed one typo and one minor style issue. If you're OK with the fixes, I

[SSSD] [sssd PR#700][comment] LDAP: Only authenticate the auth connection if we need to look up user information

2018-11-26 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/700 Title: #700: LDAP: Only authenticate the auth connection if we need to look up user information sumit-bose commented: """ ah sorry, I just realized that I didn't paste the latest version of my debug call. Here it is: ``` diff --git

[SSSD] [sssd PR#700][comment] LDAP: Only authenticate the auth connection if we need to look up user information

2018-11-26 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/700 Title: #700: LDAP: Only authenticate the auth connection if we need to look up user information sumit-bose commented: """ Thank you, the patches are looking good and worked well in my tests, ACK. I added the following call while testing the patches

[SSSD] [sssd PR#700][comment] LDAP: Only authenticate the auth connection if we need to look up user information

2018-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/700 Title: #700: LDAP: Only authenticate the auth connection if we need to look up user information jhrozek commented: """ I chose this approach because it only touches the ldap auth code. The other approach I was considering was to not force off the

[SSSD] [sssd PR#700][comment] LDAP: Only authenticate the auth connection if we need to look up user information

2018-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/700 Title: #700: LDAP: Only authenticate the auth connection if we need to look up user information jhrozek commented: """ I chose this approach because it only touches the ldap auth code. The other approach I was considering was to not force off the