[SSSD] Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-12-11 Thread Jakub Hrozek
On Thu, Dec 10, 2015 at 01:52:48PM +0100, Petr Cech wrote: > Thank you for review. > I prefer one return point per function. > > Petr > > PS: New patch is attached. ACK ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-12-11 Thread Lukas Slebodnik
On (11/12/15 12:41), Jakub Hrozek wrote: >On Thu, Dec 10, 2015 at 01:52:48PM +0100, Petr Cech wrote: >> Thank you for review. >> I prefer one return point per function. >> >> Petr >> >> PS: New patch is attached. > >ACK master: * 565e6d91814884054ec0dc4d770804d7bf472d3f sssd-1-13: *

[SSSD] Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-12-10 Thread Lukas Slebodnik
On (10/12/15 11:26), Jakub Hrozek wrote: >On Tue, Dec 08, 2015 at 04:57:02PM +0100, Petr Cech wrote: >> On 12/07/2015 03:43 PM, Jakub Hrozek wrote: >> >On Fri, Dec 04, 2015 at 04:33:51PM +0100, Petr Cech wrote: >> >>So, I have choose the 2) option and the patch is attached. >> > >> >I think this

[SSSD] Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-12-10 Thread Jakub Hrozek
On Tue, Dec 08, 2015 at 04:57:02PM +0100, Petr Cech wrote: > On 12/07/2015 03:43 PM, Jakub Hrozek wrote: > >On Fri, Dec 04, 2015 at 04:33:51PM +0100, Petr Cech wrote: > >>So, I have choose the 2) option and the patch is attached. > > > >I think this patch goes in the right direction, but still

[SSSD] Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-12-10 Thread Petr Cech
On 12/10/2015 11:33 AM, Lukas Slebodnik wrote: On (10/12/15 11:26), Jakub Hrozek wrote: On Tue, Dec 08, 2015 at 04:57:02PM +0100, Petr Cech wrote: On 12/07/2015 03:43 PM, Jakub Hrozek wrote: On Fri, Dec 04, 2015 at 04:33:51PM +0100, Petr Cech wrote: One style nitpick and then we can push

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-12-08 Thread Petr Cech
On 12/07/2015 03:43 PM, Jakub Hrozek wrote: On Fri, Dec 04, 2015 at 04:33:51PM +0100, Petr Cech wrote: So, I have choose the 2) option and the patch is attached. I think this patch goes in the right direction, but still needs more work. See inline. Hello Jakub, thank you for careful review.

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-12-07 Thread Jakub Hrozek
On Fri, Dec 04, 2015 at 04:33:51PM +0100, Petr Cech wrote: > So, I have choose the 2) option and the patch is attached. I think this patch goes in the right direction, but still needs more work. See inline. > And something more: > a.bak ... log before patch > b.bak ... log after patch > >

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-12-04 Thread Petr Cech
On 12/03/2015 05:26 PM, Jakub Hrozek wrote: On Tue, Dec 01, 2015 at 05:02:39PM +0100, Petr Cech wrote: On 11/27/2015 10:35 AM, Jakub Hrozek wrote: On Thu, Nov 19, 2015 at 05:57:56PM +0100, Petr Cech wrote: On 11/12/2015 06:04 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 04:54:21PM +0100,

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-12-03 Thread Jakub Hrozek
On Tue, Dec 01, 2015 at 05:02:39PM +0100, Petr Cech wrote: > On 11/27/2015 10:35 AM, Jakub Hrozek wrote: > >On Thu, Nov 19, 2015 at 05:57:56PM +0100, Petr Cech wrote: > >>On 11/12/2015 06:04 PM, Jakub Hrozek wrote: > >>>On Thu, Nov 12, 2015 at 04:54:21PM +0100, Petr Cech wrote: > >On

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-12-01 Thread Petr Cech
On 11/27/2015 10:35 AM, Jakub Hrozek wrote: On Thu, Nov 19, 2015 at 05:57:56PM +0100, Petr Cech wrote: On 11/12/2015 06:04 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 04:54:21PM +0100, Petr Cech wrote: On 11/11/2015 02:42 PM, Jakub Hrozek wrote: Hi, I think it's a good idea to only say

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-11-27 Thread Jakub Hrozek
On Thu, Nov 19, 2015 at 05:57:56PM +0100, Petr Cech wrote: > On 11/12/2015 06:04 PM, Jakub Hrozek wrote: > >On Thu, Nov 12, 2015 at 04:54:21PM +0100, Petr Cech wrote: > >>>On 11/11/2015 02:42 PM, Jakub Hrozek wrote: > >Hi, I think it's a good idea to only say we don't handle services for >

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-11-23 Thread Petr Cech
On 11/19/2015 05:57 PM, Petr Cech wrote: On 11/12/2015 06:04 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 04:54:21PM +0100, Petr Cech wrote: >On 11/11/2015 02:42 PM, Jakub Hrozek wrote: > >Hi, I think it's a good idea to only say we don't handle services for > >IPA subdomains. But I also

[SSSD]Re: [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-11-19 Thread Petr Cech
On 11/12/2015 06:04 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 04:54:21PM +0100, Petr Cech wrote: >On 11/11/2015 02:42 PM, Jakub Hrozek wrote: > >Hi, I think it's a good idea to only say we don't handle services for > >IPA subdomains. But I also think it would be better to shortcut the >