[SSSD] Re: [PATCH] sssd_netgroup.py: Resolve nested netgroups

2016-08-24 Thread Lukas Slebodnik
On (24/08/16 13:51), Petr Cech wrote: >On 08/24/2016 09:33 AM, Petr Cech wrote: >> Hi Lukas, >> >> I didn't run CI tests because your new code is not used yet. >> But I run my tests for nested_group with your updated version. >> Everything works how we expected. >> Code LGTM. >> >> => ACK > >CI

[SSSD] Re: [PATCH] sssd_netgroup.py: Resolve nested netgroups

2016-08-24 Thread Petr Cech
On 08/24/2016 09:33 AM, Petr Cech wrote: Hi Lukas, I didn't run CI tests because your new code is not used yet. But I run my tests for nested_group with your updated version. Everything works how we expected. Code LGTM. => ACK CI passed with my patches:

[SSSD] Re: [PATCH] sssd_netgroup.py: Resolve nested netgroups

2016-08-24 Thread Petr Cech
On 08/24/2016 07:30 AM, Lukas Slebodnik wrote: On (19/08/16 12:35), Petr Cech wrote: On 08/19/2016 11:42 AM, Petr Cech wrote: On 08/19/2016 11:24 AM, Lukas Slebodnik wrote: On (19/08/16 08:55), Petr Cech wrote: On 08/18/2016 12:22 PM, Petr Cech wrote: On 08/18/2016 12:19 PM, Lukas Slebodnik

[SSSD] Re: [PATCH] sssd_netgroup.py: Resolve nested netgroups

2016-08-23 Thread Lukas Slebodnik
On (19/08/16 12:35), Petr Cech wrote: >On 08/19/2016 11:42 AM, Petr Cech wrote: >> On 08/19/2016 11:24 AM, Lukas Slebodnik wrote: >> > On (19/08/16 08:55), Petr Cech wrote: >> > > On 08/18/2016 12:22 PM, Petr Cech wrote: >> > > > On 08/18/2016 12:19 PM, Lukas Slebodnik wrote: >> > > > > ehlo, >> >

[SSSD] Re: [PATCH] sssd_netgroup.py: Resolve nested netgroups

2016-08-19 Thread Petr Cech
On 08/19/2016 11:42 AM, Petr Cech wrote: On 08/19/2016 11:24 AM, Lukas Slebodnik wrote: On (19/08/16 08:55), Petr Cech wrote: On 08/18/2016 12:22 PM, Petr Cech wrote: On 08/18/2016 12:19 PM, Lukas Slebodnik wrote: ehlo, python wrapper for retrieving netgroups was push to early. Attached

[SSSD] Re: [PATCH] sssd_netgroup.py: Resolve nested netgroups

2016-08-19 Thread Petr Cech
On 08/19/2016 11:24 AM, Lukas Slebodnik wrote: On (19/08/16 08:55), Petr Cech wrote: On 08/18/2016 12:22 PM, Petr Cech wrote: On 08/18/2016 12:19 PM, Lukas Slebodnik wrote: ehlo, python wrapper for retrieving netgroups was push to early. Attached patch fixes it. LS Thanks, Lukas. I will

[SSSD] Re: [PATCH] sssd_netgroup.py: Resolve nested netgroups

2016-08-19 Thread Lukas Slebodnik
On (19/08/16 08:55), Petr Cech wrote: >On 08/18/2016 12:22 PM, Petr Cech wrote: >> On 08/18/2016 12:19 PM, Lukas Slebodnik wrote: >> > ehlo, >> > >> > python wrapper for retrieving netgroups was push to early. >> > Attached patch fixes it. >> > >> > LS >> >> Thanks, Lukas. I will take a look >>

[SSSD] Re: [PATCH] sssd_netgroup.py: Resolve nested netgroups

2016-08-19 Thread Petr Cech
On 08/18/2016 12:22 PM, Petr Cech wrote: On 08/18/2016 12:19 PM, Lukas Slebodnik wrote: ehlo, python wrapper for retrieving netgroups was push to early. Attached patch fixes it. LS Thanks, Lukas. I will take a look and I will try it with my tests :-) Hi Lukas, your patch works how we

[SSSD] Re: [PATCH] sssd_netgroup.py: Resolve nested netgroups

2016-08-18 Thread Petr Cech
On 08/18/2016 12:19 PM, Lukas Slebodnik wrote: ehlo, python wrapper for retrieving netgroups was push to early. Attached patch fixes it. LS Thanks, Lukas. I will take a look and I will try it with my tests :-) Reards -- Petr^4 Čech ___ sssd-devel