URL: https://github.com/SSSD/sssd/pull/32
Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/32
Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138
fidencio commented:
"""
This PR doesn't make sense anymore in the state that this branch is.
I'm closing the PR and a new one will be re-open by whoever ends up working on
this in the
URL: https://github.com/SSSD/sssd/pull/32
Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138
Label: +Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/309
Author: jhrozek
Title: #309: HBAC: Do not rely on originalMemberOf, use the sysdb memberof
links instead (sssd-1-13 backprot)
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd
URL: https://github.com/SSSD/sssd/pull/309
Title: #309: HBAC: Do not rely on originalMemberOf, use the sysdb memberof
links instead (sssd-1-13 backprot)
jhrozek commented:
"""
* sssd-1-13: 88f6d8ad4eef4b4fa032fd451ad732cf8201b0bf
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/307
Title: #307: IPA: Only attempt migration for the joined domain
jhrozek commented:
"""
Sure, just type in a wrong password when authenticating as a user from an
IPA-AD trust. With the patch, you will see the migration being tried as well,
without the
URL: https://github.com/SSSD/sssd/pull/309
Title: #309: HBAC: Do not rely on originalMemberOf, use the sysdb memberof
links instead (sssd-1-13 backprot)
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe
URL: https://github.com/SSSD/sssd/pull/340
Title: #340: SPEC: Use language file for sssd-kcm
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/340
Title: #340: SPEC: Use language file for sssd-kcm
fidencio commented:
"""
ACK!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/340#issuecomment-318279599
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/295
Title: #295: MAN: Document that the secrets provider can only be specified in a
per-client section
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe
URL: https://github.com/SSSD/sssd/pull/339
Title: #339: UTIL: Create custom abort function for talloc_get_type_abort()
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/339
Title: #339: UTIL: Create custom abort function for talloc_get_type_abort()
fidencio commented:
"""
@amitkumar50: The patch you updated doesn't match with the description you
wrote.
I'm adding "Changes Requested" label for now. Please, update the PR
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
celestian commented:
"""
@fidencio Oh, I see -- now I understand what are you looking for. Maybe it is
little confusing, there on github, that it is not visible that my patch is
already
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
celestian commented:
"""
@fidencio I am totally out of scope of this PR. I just assume that I addressed
@frozencemetery 's comment from Mar 28. The conditional setting was subject of
URL: https://github.com/SSSD/sssd/pull/237
Title: #237: providers: Move hostid from ipa to sdap
fidencio commented:
"""
retest this, please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/237#issuecomment-318271653
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/32
Author: fidencio
Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/32/head:pr32
git checkout pr32
URL: https://github.com/SSSD/sssd/pull/189
Title: #189: SELINUX: Use getseuserbyname to get IPA seuser
fidencio commented:
"""
@lslebodn, @justin-stephenson: What's the state of this PR? Is this still valid?
In case it's still valid, @justin-stephenson, may I ask you to rebase the
patches
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
fidencio commented:
"""
retest this, please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/214#issuecomment-318278533
___
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
fidencio commented:
"""
@celestian: basically I'm trying to figure out whether his comments are still
valid and I misunderstood the last patch. Because looks like the last patch
addresses
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
fidencio commented:
"""
@frozencemetery: is your comment still valid for the latest version of this
patch? I'm not sure whether @celestian updated this patch after your comment or
not and
URL: https://github.com/SSSD/sssd/pull/136
Title: #136: Tlog integration
spbnick commented:
"""
Woo-hoo :D! Thanks a lot for all the work, Pavel, Lukas and Jakub :)!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/136#issuecomment-318342564
URL: https://github.com/SSSD/sssd/pull/301
Author: fidencio
Title: #301: Introduce sysdb_search_by_orig_dn()
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/301/head:pr301
git checkout pr301
From
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/301
Title: #301: Introduce sysdb_search_by_orig_dn()
fidencio commented:
"""
Patch set has been updated.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/301#issuecomment-318327223
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/237
Title: #237: providers: Move hostid from ipa to sdap
fidencio commented:
"""
Removing the "Changes requested" label as the patch has been updated (v2).
"""
See the full comment at
https://github.com/SSSD/sssd/pull/237#issuecomment-318329098
URL: https://github.com/SSSD/sssd/pull/340
Author: lslebodn
Title: #340: SPEC: Use language file for sssd-kcm
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/340/head:pr340
git checkout pr340
URL: https://github.com/SSSD/sssd/pull/340
Title: #340: SPEC: Use language file for sssd-kcm
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/338
Author: jhrozek
Title: #338: MAN: Don't tell the user to autostart sssd-kcm.service; it's
socket-enabled
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/338/head:pr338
git
URL: https://github.com/SSSD/sssd/pull/202
Title: #202: T3315 infopipe group users master
celestian commented:
"""
The issue was that getent shows user test_user in test_group, but dbus call
doesn't.
How I did it is described in my description. But I don't know if it is still
valid. It was
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
justin-stephenson commented:
"""
Thank you for the review @mzidek-rh - I will make the changes and update the PR.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/136
Author: spbnick
Title: #136: Tlog integration
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/136/head:pr136
git checkout pr136
___
URL: https://github.com/SSSD/sssd/pull/339
Title: #339: UTIL: Create custom abort function for talloc_get_type_abort()
fidencio commented:
"""
Talked privately to @amitkumar50 and this PR actually should be part of #231.
I'm closing this PR and @amitkumar50 will update #231 when all the
URL: https://github.com/SSSD/sssd/pull/339
Title: #339: UTIL: Create custom abort function for talloc_get_type_abort()
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/339
Author: amitkumar50
Title: #339: UTIL: Create custom abort function for talloc_get_type_abort()
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/339/head:pr339
git checkout pr339
URL: https://github.com/SSSD/sssd/pull/339
Title: #339: UTIL: Create custom abort function for talloc_get_type_abort()
Label: +Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/202
Title: #202: T3315 infopipe group users master
mzidek-rh commented:
"""
@fidencio , sorry but I do not know what is the issue. I was probably not clear
in my previous comments, but IMO the reproducer is wrong because it does not
describe any issue. I
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
fidencio commented:
"""
I basically agree with @lslebodn here. 'SSSDBG_CONF_SETTINGS' seems the
appropriate debug level to use.
Also, a review about the commit short-log and the
URL: https://github.com/SSSD/sssd/pull/225
Author: jhrozek
Title: #225: SECRETS: Apply separate quotas for cn=secrets and cn=kcm
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/225/head:pr225
git checkout pr225
From
URL: https://github.com/SSSD/sssd/pull/338
Title: #338: MAN: Don't tell the user to autostart sssd-kcm.service; it's
socket-enabled
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/338
Title: #338: MAN: Don't tell the user to autostart sssd-kcm.service; it's
socket-enabled
jhrozek commented:
"""
* master: 47f73fbf39b75b1a6c816206c384f83f78535677
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/237
Title: #237: providers: Move hostid from ipa to sdap
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/295
Title: #295: MAN: Document that the secrets provider can only be specified in a
per-client section
justin-stephenson commented:
"""
I think it could be useful to add something like "The secrets responder is
configured with a global [secrets] section
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
mzidek-rh commented:
"""
There is a tabulator instead of space after '=' sign
in Makefile.am:
```
458
459 dist_sbin_SCRIPTS = contrib/tools/sss_debuglevel
460
```
But as Lukas mentioned
URL: https://github.com/SSSD/sssd/pull/136
Title: #136: Tlog integration
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/136
Title: #136: Tlog integration
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/136
Title: #136: Tlog integration
jhrozek commented:
"""
Since we released 1.15.3 (finally!) ealier this week, I merged the patches:
* 27c30eb5f046d6c43276b139706110906cdacb9b
* 53a4219e2f51cd0443931aa931505bf0b4bf5a45
*
URL: https://github.com/SSSD/sssd/pull/136
Title: #136: Tlog integration
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/333
Title: #333: Move header files consumed by both server and client to special
folder
fidencio commented:
"""
Although we may not do it properly, we try our best to keep our files grouped
together and alphabetically ordered.
So, please, group together
URL: https://github.com/SSSD/sssd/pull/333
Title: #333: Move header files consumed by both server and client to special
folder
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/225
Title: #225: SECRETS: Apply separate quotas for cn=secrets and cn=kcm
jhrozek commented:
"""
I squashed in @fidencio's fixup and pushed new version of the patches..
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/225
Title: #225: SECRETS: Apply separate quotas for cn=secrets and cn=kcm
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/4
Title: #4: Added small tweaks to enable SSSD to be compiled with the musl libc
fidencio commented:
"""
@lejonet, @lslebodn, does this PR still make sense?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/4#issuecomment-318327689
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
frozencemetery commented:
"""
@fidencio it looks like it's been addressed. Thanks for checking!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/214#issuecomment-318387652
URL: https://github.com/SSSD/sssd/pull/326
Title: #326: IPA: check if IPA hostname is a FQDN
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/326
Title: #326: IPA: check if IPA hostname is a FQDN
fidencio commented:
"""
@amitkumar50: I've tested the patch, it works, but I'll request some changes in
it.
Let me write you here a few general recommendations based on a few different
parts of the
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/214
Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet
fidencio commented:
"""
@frozencemetery. thanks for checking it out. I'll take over the review in the
next few days (unless I have an ACK from you ;-)).
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an
URL: https://github.com/SSSD/sssd/pull/325
Title: #325: MAN: Improve description of 'trusted domain section' in
sssd.conf's man page
fidencio commented:
"""
I'm adding "Changes Requested" label as per my review.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/237
Title: #237: providers: Move hostid from ipa to sdap
hvenev commented:
"""
When this patch is applied to 1.15.3, all tests are passing and things seem to
be working fine when using ldap.
"""
See the full comment at
61 matches
Mail list logo
