[SSSD] [sssd PR#451][comment] BUILD: Disable tests with know failures

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/451 Title: #451: BUILD: Disable tests with know failures lslebodn commented: """ On (16/11/17 12:40), mzidek-rh wrote: >Here is the branch if interested to look at the scope, but as I said I need to >run it in the environment where it was failing before

[SSSD] Design document: Using the Global Catalog to speed up lookups by ID

2017-11-16 Thread Jakub Hrozek
Hi, below you can find the design proposal for ticket https://pagure.io/SSSD/sssd/issue/3468 I also submitted a Pagure PR: https://pagure.io/SSSD/docs/pull-request/56 Using the Global Catalog to speed up lookups by ID == Related ticket(s):

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-11-16 Thread mrniranjan
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework mrniranjan commented: """ +1 from me for team """ See the full comment at https://github.com/SSSD/sssd/pull/139#issuecomment-344963921 ___ sssd-devel

[SSSD] [sssd PR#454][opened] TESTS: Order list of entries in some lists

2017-11-16 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/454 Author: mzidek-rh Title: #454: TESTS: Order list of entries in some lists Action: opened PR body: """ Some tests started to fail becuase we depended on specific order users in groups or messages in ldb results to be returned and that order changed.

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format jhrozek commented: """ btw which platforms use 64bit id_t? """ See the full comment at https://github.com/SSSD/sssd/pull/448#issuecomment-344953635

[SSSD] [sssd PR#451][comment] BUILD: Disable tests with know failures

2017-11-16 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/451 Title: #451: BUILD: Disable tests with know failures mzidek-rh commented: """ Here is the PR: https://github.com/SSSD/sssd/pull/454 """ See the full comment at https://github.com/SSSD/sssd/pull/451#issuecomment-344992710

[SSSD] [sssd PR#452][comment] SPEC: Reduce build time dependencies

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/452 Title: #452: SPEC: Reduce build time dependencies fidencio commented: """ @lslebodn, just one question (trying to learn a little bit here) why did you choose your approach over BuildRequires: pkgconfig(gdm-pam-extensions) ? """ See the full comment

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-16 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/424 Title: #424: TOOLS: Add a new sssctl command access-report pbrezina commented: """ Ack to Jakub's part of the patch set. """ See the full comment at https://github.com/SSSD/sssd/pull/424#issuecomment-344927528

[SSSD] [sssd PR#452][comment] SPEC: Reduce build time dependencies

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/452 Title: #452: SPEC: Reduce build time dependencies fidencio commented: """ I'd like to ask a mention in the commit message the commit you filed that ended up with the gdm-pam-extensions-devel creation. Anyways, obvious ACK! """ See the full comment

[SSSD] [sssd PR#451][comment] BUILD: Disable tests with know failures

2017-11-16 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/451 Title: #451: BUILD: Disable tests with know failures mzidek-rh commented: """ Sorry I forgot about this. I do have a patch for https://pagure.io/SSSD/sssd/issue/3563 in ordererd-string-arrays (I just pushed the branch to gh). But I only tested it on

[SSSD] [sssd PR#399][comment] Backport of PR#57 to SSSD-1.13

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/399 Title: #399: Backport of PR#57 to SSSD-1.13 lslebodn commented: """ @sumit-bose I prepared rebased version of PR + I squashed last commit to previous original ommit. Reason: it would be really good to have git bisect working even on 1.13 branch.

[SSSD] [sssd PR#451][comment] BUILD: Disable tests with know failures

2017-11-16 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/451 Title: #451: BUILD: Disable tests with know failures mzidek-rh commented: """ @lslebodn yeah I see (just tried the patch)... the tests need to be modified and that part in the branch may not be even necessary... so forget the branch, I will push new

[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req

2017-11-16 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req amitkumar50 commented: """ @jhrozek Thanks for comments. So Shall I not work on this patch as of now? Or instead of EOK define `ERR_UID_OUTSIDE_RANGE` in `./src/util/util_errors.h` and return.

[SSSD] [sssd PR#451][comment] BUILD: Disable tests with know failures

2017-11-16 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/451 Title: #451: BUILD: Disable tests with know failures mzidek-rh commented: """ Here is the branch if interested to look at the scope, but as I said I need to run it in the environment where it was failing before submitting PR

[SSSD] [sssd PR#454][comment] TESTS: Order list of entries in some lists

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/454 Title: #454: TESTS: Order list of entries in some lists lslebodn commented: """ On (16/11/17 17:12), mzidek-rh wrote: >Some tests started to fail becuase we depended on specific >order users in groups or messages in ldb results to be >returned and that

[SSSD] [sssd PR#448][+Pushed] common: Correction of cache_req debug string ID format

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format lslebodn commented: """ master: * d25646c64a7117a6551468256efa82d01647751e """ See the full comment at https://github.com/SSSD/sssd/pull/448#issuecomment-344886324

[SSSD] [sssd PR#448][closed] common: Correction of cache_req debug string ID format

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/448 Author: amitkumar50 Title: #448: common: Correction of cache_req debug string ID format Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/448/head:pr448 git checkout pr448

[SSSD] [sssd PR#451][opened] BUILD: Disable tests with know failures

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/451 Author: lslebodn Title: #451: BUILD: Disable tests with know failures Action: opened PR body: """ Temporary workaround for: https://pagure.io/SSSD/sssd/issue/3563 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd

[SSSD] [sssd PR#451][comment] BUILD: Disable tests with know failures

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/451 Title: #451: BUILD: Disable tests with know failures fidencio commented: """ Although the patch looks good and there's a strong motivation behind this (having our internal CI tests passing), I'd like to hear from @mzidek-rh about what's the status of

[SSSD] [sssd PR#452][opened] SPEC: Reduce build time dependencies

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/452 Author: lslebodn Title: #452: SPEC: Reduce build time dependencies Action: opened PR body: """ Total download size: 139 M Installed size: 465 M vs Total size: 11 k """ To pull the PR as Git branch: git remote add ghsssd

[SSSD] [sssd PR#451][comment] BUILD: Disable tests with know failures

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/451 Title: #451: BUILD: Disable tests with know failures fidencio commented: """ Unfortunately, as PR #454 is not passing our CI and also has some comments to be addressed (which most likely won't happen till next week), let's have this PR merged ASAP

[SSSD] [sssd PR#451][+Accepted] BUILD: Disable tests with know failures

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/451 Title: #451: BUILD: Disable tests with know failures Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#451][closed] BUILD: Disable tests with know failures

2017-11-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/451 Author: lslebodn Title: #451: BUILD: Disable tests with know failures Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/451/head:pr451 git checkout pr451

[SSSD] [sssd PR#451][comment] BUILD: Disable tests with know failures

2017-11-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/451 Title: #451: BUILD: Disable tests with know failures jhrozek commented: """ * master: .44bc6e8f49eec9e7ab9a952845bffcc0fd3b3a44 """ See the full comment at https://github.com/SSSD/sssd/pull/451#issuecomment-345060225

[SSSD] [sssd PR#451][+Pushed] BUILD: Disable tests with know failures

2017-11-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/451 Title: #451: BUILD: Disable tests with know failures Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#454][+Changes requested] TESTS: Order list of entries in some lists

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/454 Title: #454: TESTS: Order list of entries in some lists Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#454][comment] TESTS: Order list of entries in some lists

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/454 Title: #454: TESTS: Order list of entries in some lists fidencio commented: """ @mzidek-rh, please, also revert 44bc6e8f49ee in the next iteration of this PR. """ See the full comment at https://github.com/SSSD/sssd/pull/454#issuecomment-345075914

[SSSD] [sssd PR#405][comment] WATCHDOG: Restart providers with SIGUSR2 after time drift

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/405 Title: #405: WATCHDOG: Restart providers with SIGUSR2 after time drift fidencio commented: """ @lslebodn, not yet. When I make some time I'll run all the downstream tests (as per your recommendation) and I'll finish the review of this patch. """ See

[SSSD] [sssd PR#405][comment] WATCHDOG: Restart providers with SIGUSR2 after time drift

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/405 Title: #405: WATCHDOG: Restart providers with SIGUSR2 after time drift fidencio commented: """ OTOH, if you have spare cycles, please, feel free to run the tests and give the ACK to this patch. """ See the full comment at

[SSSD] [sssd PR#448][synchronized] common: Correction of cache_req debug string ID format

2017-11-16 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/448 Author: amitkumar50 Title: #448: common: Correction of cache_req debug string ID format Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/448/head:pr448 git checkout pr448 From

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format lslebodn commented: """ >This is not fixed. Although it seems nitpicking to me as gid_t, uid_t and id_t >as all of those ended up being defined as u32 type anyways ... all of those

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-16 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format amitkumar50 commented: """ @fidencio Thanks I read inttypes.h convention here goes PRIuN. Done. """ See the full comment at

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format fidencio commented: """ @lslebodn, hmm. makes sense, thanks for the explanation. Seems that @amitkumar50 new PR is okay with your suggestion, but I'd like to hear it from you. """

[SSSD] [sssd PR#450][opened] sysdb: do not use objectClass for users and groups

2017-11-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/450 Author: sumit-bose Title: #450: sysdb: do not use objectClass for users and groups Action: opened PR body: """ The majority of the object in the SSSD cache are users and groups. If there are many user and groups in the cache the index objects of the

[SSSD] [sssd PR#448][-Changes requested] common: Correction of cache_req debug string ID format

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#443][comment] NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout()

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/443 Title: #443: NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout() lslebodn commented: """ > I didn't. As I said in the first comment, I was not able to reproduce the > issue at all, even with the steps you mentioned in the bugzilla. I

[SSSD] [sssd PR#443][comment] NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout()

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/443 Title: #443: NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout() fidencio commented: """ @lslebodn: feel free to add more info there in case you think there's something missing in the description. """ See the full comment at

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-11-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework jhrozek commented: """ OK, I added @mrniranjan to commit group for https://pagure.io/SSSD/docs/ Then I created the tag "tests" in pagure and added @mrniranjan to the main pagure repo with

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework fidencio commented: """ I really like the idea of having the team there. So, +1 from me. """ See the full comment at https://github.com/SSSD/sssd/pull/139#issuecomment-344871272

[SSSD] [sssd PR#443][comment] NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout()

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/443 Title: #443: NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout() fidencio commented: """ @lslebodn: https://pagure.io/SSSD/sssd/issue/3575 has been created. """ See the full comment at