[SSSD] [sssd PR#457][comment] ipa: Removal of umask(0) in selinux_child

2017-11-24 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/457 Title: #457: ipa: Removal of umask(0) in selinux_child lslebodn commented: """ On (23/11/17 12:45), Petr Lautrbach wrote: >I guess it's related to the change of SElinux module store location in >/var/lib/selinux which happened in Release 2015-02-02

[SSSD] [sssd PR#455][comment] mmap_cache: make checks independent of input size

2017-11-24 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/455 Title: #455: mmap_cache: make checks independent of input size lslebodn commented: """ On (24/11/17 07:10), sumit-bose wrote: >I kept the memchr() check mainly for the initgroups cache data. For passwd and >group the first element in the string/data

[SSSD] [sssd PR#455][comment] mmap_cache: make checks independent of input size

2017-11-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/455 Title: #455: mmap_cache: make checks independent of input size sumit-bose commented: """ latest version has memchr() removed. """ See the full comment at https://github.com/SSSD/sssd/pull/455#issuecomment-346856048

[SSSD] [sssd PR#455][-Changes requested] mmap_cache: make checks independent of input size

2017-11-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/455 Title: #455: mmap_cache: make checks independent of input size Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#455][comment] mmap_cache: make checks independent of input size

2017-11-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/455 Title: #455: mmap_cache: make checks independent of input size sumit-bose commented: """ I agree this is nitpicking and artificial, but I think strcmp() can run outside the data table. If the last slot in the data table is the last of an initgr

[SSSD] [sssd PR#455][synchronized] mmap_cache: make checks independent of input size

2017-11-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/455 Author: sumit-bose Title: #455: mmap_cache: make checks independent of input size Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/455/head:pr455 git checkout pr455 From