URL: https://github.com/SSSD/sssd/pull/470
Title: #470: IPA: Enable periodic subdomains refresh only after
responder-induced refresh finishes
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe
URL: https://github.com/SSSD/sssd/pull/470
Title: #470: IPA: Enable periodic subdomains refresh only after
responder-induced refresh finishes
pbrezina commented:
"""
But responders perform GetDomains call on initial start up regardless whether a
user have been requested or not. So if this is
URL: https://github.com/SSSD/sssd/pull/477
Author: fidencio
Title: #477: SYSDB: Return EOK in case a non-fatal issue happened
Action: opened
PR body:
"""
There may be the case where we aren't able to merge the timestamps from
the fast ts db, which are treated as non-fatal issues. In case it
URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
@pbrezina, @jhrozek: This PR has been updated and is read to be reviewed &
possibly merged.
I've opened two issues related to this PR:
URL: https://github.com/SSSD/sssd/pull/378
Author: fidencio
Title: #378: [RFC] Use GNULIB's compiler warning code
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/378/head:pr378
git checkout pr378
From
URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
I've fired a CI build and I'm waiting for its results.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/378#issuecomment-351739766
URL: https://github.com/SSSD/sssd/pull/477
Author: fidencio
Title: #477: SYSDB: Return EOK in case a non-fatal issue happened
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/477/head:pr477
git checkout pr477
From
URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
CI: http://vm-031.abc.idm.lab.eng.brq.redhat.com/logs/job/82/70/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/378#issuecomment-351793009
URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
@pbrezina, @jhrozek: This PR has been updated and is ready to be reviewed &
possibly merged.
I've opened two issues related to this PR:
URL: https://github.com/SSSD/sssd/pull/470
Title: #470: IPA: Enable periodic subdomains refresh only after
responder-induced refresh finishes
jhrozek commented:
"""
Yes, a delay was another option I was considering. I just wasn't sure if this
would maybe provide a race between the delayed
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
As per @lslebodn's comments I understand that SSSD project has **no** interest
on this PR at the moment.
I've opened https://pagure.io/SSSD/sssd/issue/3605 and I'm closing this PR.
"""
See
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
On (14/12/17 10:08), fidencio wrote:
>As per @lslebodn's comments I understand that SSSD project has **no** interest
>on this PR at the moment.
>
Please do not put words to my mouth. I have
URL: https://github.com/SSSD/sssd/pull/474
Title: #474: p11_child: properly check results of CERT_VerifyCertificateNow
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/474
Author: sumit-bose
Title: #474: p11_child: properly check results of CERT_VerifyCertificateNow
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/474/head:pr474
git checkout pr474
URL: https://github.com/SSSD/sssd/pull/474
Title: #474: p11_child: properly check results of CERT_VerifyCertificateNow
lslebodn commented:
"""
master:
* 787ba9c882f1d7ff9ea4f2745e779c5fb04dfafc
* c221b5fb4d3fc511cebcae2f042e43fb1c577bc7
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/470
Title: #470: IPA: Enable periodic subdomains refresh only after
responder-induced refresh finishes
pbrezina commented:
"""
Ah, it is about a case when a trust was establish during sssd runtime. Discard
my previous comment. Delay may work here.
"""
URL: https://github.com/SSSD/sssd/pull/474
Title: #474: p11_child: properly check results of CERT_VerifyCertificateNow
fidencio commented:
"""
Ack! spoore has verified that this patch properly solves the issue.
I'm waiting for our internal CI results ...
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
From
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
I have updated the patch set and fired a CI build.
I'd really appreciate if we can have this one pushed as soon as our internal CI
passes and then avoid having to fix pep8 issues in the
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
On (14/12/17 08:47), fidencio wrote:
>We **really** have to have a better way to handle PRs as it's not the first
>time it happens ...
>
pep8 is only about coding style it does not make code
URL: https://github.com/SSSD/sssd/pull/474
Title: #474: p11_child: properly check results of CERT_VerifyCertificateNow
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/474
Title: #474: p11_child: properly check results of CERT_VerifyCertificateNow
fidencio commented:
"""
CI: http://vm-031.abc.idm.lab.eng.brq.redhat.com/logs/job/82/60/summary.html
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
Hmm. And seems that I will have to re-work these patches as more new issues
have been added meanwhile this patch was stuck. :-/
We **really** have to have a better way to handle PRs as it's
URL: https://github.com/SSSD/sssd/pull/470
Title: #470: IPA: Enable periodic subdomains refresh only after
responder-induced refresh finishes
pbrezina commented:
"""
@sumit-bose Do you remember why do we have periodic subdomain refresh in
backend? Responders keep refreshing it anyway.
"""
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
Well, when a PR is not reviewed and the comments come with:
"Coding style was never a priority and I cannot see a reason why
core developer need to sped a time with fixing coding style issues
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
cigarette
"""
See the full comment at
https://github.com/SSSD/sssd/pull/379#issuecomment-351685924
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
cigarette
"""
See the full comment at
https://github.com/SSSD/sssd/pull/379#issuecomment-351685924
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: +Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
tiran commented:
"""
As a software developer with over 20 years of coding experience and involved in
lots of Open Source projects written in C, Go and Python, I have to disagree
with you. A consistent code style and
31 matches
Mail list logo