[SSSD] [sssd PR#483][comment] Password change with two factor authentication

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/483 Title: #483: Password change with two factor authentication jhrozek commented: """ * master: * a409fd64abcf67159a69eba7971231e0901b4e8c

[SSSD] [sssd PR#483][closed] Password change with two factor authentication

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/483 Author: sumit-bose Title: #483: Password change with two factor authentication Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/483/head:pr483 git checkout pr483

[SSSD] [sssd PR#483][+Pushed] Password change with two factor authentication

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/483 Title: #483: Password change with two factor authentication Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#483][comment] Password change with two factor authentication

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/483 Title: #483: Password change with two factor authentication jhrozek commented: """ Coverity passed, CI "passed" (except a known failure because of valgrind on Debian) and downstream test for "ipa passwd" did not produce new failures either (job ID

[SSSD] [sssd PR#483][+Accepted] Password change with two factor authentication

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/483 Title: #483: Password change with two factor authentication Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#472][closed] Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/472 Author: fidencio Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/472/head:pr472 git

[SSSD] [sssd PR#472][+Pushed] Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/472 Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#472][comment] Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/472 Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA jhrozek commented: """ * master: * 56f015ef6a161e01681f79e4ea0d1b642f9737b4

[SSSD] [sssd PR#501][opened] SDAP: Improve a DEBUG message about GC detection

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/501 Author: jhrozek Title: #501: SDAP: Improve a DEBUG message about GC detection Action: opened PR body: """ It was not entirely clear what the message means. We should improve the debug message to make it clear that all or none attributes should be

[SSSD] [sssd PR#501][+Changes requested] SDAP: Improve a DEBUG message about GC detection

2018-01-23 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/501 Title: #501: SDAP: Improve a DEBUG message about GC detection Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#501][comment] SDAP: Improve a DEBUG message about GC detection

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/501 Title: #501: SDAP: Improve a DEBUG message about GC detection jhrozek commented: """ Probably yes, please add Changes Requested. """ See the full comment at https://github.com/SSSD/sssd/pull/501#issuecomment-359749467

[SSSD] [sssd PR#501][comment] SDAP: Improve a DEBUG message about GC detection

2018-01-23 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/501 Title: #501: SDAP: Improve a DEBUG message about GC detection fidencio commented: """ Adding the "Changes Requested" as it's probably worth to have a mention in the manpages as well. """ See the full comment at

[SSSD] [sssd PR#501][comment] SDAP: Improve a DEBUG message about GC detection

2018-01-23 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/501 Title: #501: SDAP: Improve a DEBUG message about GC detection fidencio commented: """ Out of curiosity, isn't worth a mention in the manpage as well? """ See the full comment at https://github.com/SSSD/sssd/pull/501#issuecomment-359749067

[SSSD] [sssd PR#500][opened] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/500 Author: jhrozek Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs Action: opened PR body: """ Related to: https://pagure.io/SSSD/sssd/issue/3431 There was a typo in code that read the UPN suffixes from

[SSSD] [sssd PR#500][+Accepted] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

2018-01-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/500 Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email

[SSSD] [sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/500 Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs jhrozek commented: """ Yes, I'm still working on the downstream report for sssd-1-13. Sadly, even my latest backport didn't help, so I'll check if maybe

[SSSD] [sssd PR#493][+Accepted] nss-idmap: check timed muted return code

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/493 Title: #493: nss-idmap: check timed muted return code Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#493][comment] nss-idmap: check timed muted return code

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/493 Title: #493: nss-idmap: check timed muted return code jhrozek commented: """ CI: http://sssd-ci.$IDM:8080/job/ci/8310/ """ See the full comment at https://github.com/SSSD/sssd/pull/493#issuecomment-359909334

[SSSD] [sssd PR#502][opened] BUILD: Add missing libs found by -Wl,-z,defs

2018-01-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/502 Author: lslebodn Title: #502: BUILD: Add missing libs found by -Wl,-z,defs Action: opened PR body: """ It is not possible to fully build sssd with -Wl,-z,defs because we are using sssd_be as a "library" in some cases e.g.

[SSSD] [sssd PR#500][+Pushed] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

2018-01-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/500 Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

2018-01-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/500 Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs lslebodn commented: """ master: * a8a3fcbf6f75a7c2665e8bf503c186e07dfab333 sssd-1-14: * 76957f07f79fb30634d2b5b4bed56cf30307c079 """ See the full comment

[SSSD] [sssd PR#500][closed] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

2018-01-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/500 Author: jhrozek Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/500/head:pr500 git

[SSSD] [sssd PR#502][comment] BUILD: Add missing libs found by -Wl,-z,defs

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/502 Title: #502: BUILD: Add missing libs found by -Wl,-z,defs jhrozek commented: """ btw here is the specfile diff: ``` @@ -31,7 +31,7 @@ Name: sssd Version: 1.16.0 -Release: 7%{?dist} +Release: 7%{?dist}.2 Group: Applications/System Summary: System

[SSSD] [sssd PR#502][comment] BUILD: Add missing libs found by -Wl,-z,defs

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/502 Title: #502: BUILD: Add missing libs found by -Wl,-z,defs jhrozek commented: """ How should I test this? I tried to revert (err, comment out) the sed that removes the -z flag from linker flags, then apply the two patches, but the fedora build on

[SSSD] [sssd PR#499][comment] dyndns_tests: Fix unit test with missing features in nsupdate

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/499 Title: #499: dyndns_tests: Fix unit test with missing features in nsupdate jhrozek commented: """ I 'reverse-reviewed' the patch by reverting it from Fedora and indeed I saw: ``` FAIL dyndns-tests (exit status: 4) ``` """ See the full comment at

[SSSD] [sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

2018-01-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/500 Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs lslebodn commented: """ The patch does not apply to 1.13 branch (probably due to missing other patch :-) IIRC we have some ticket which should fix UPN

[SSSD] [sssd PR#499][comment] dyndns_tests: Fix unit test with missing features in nsupdate

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/499 Title: #499: dyndns_tests: Fix unit test with missing features in nsupdate jhrozek commented: """ I'll just run CI before Accepting the patch.. """ See the full comment at https://github.com/SSSD/sssd/pull/499#issuecomment-359922035

[SSSD] [sssd PR#475][comment] AD: Use the right sdap_domain for the forest root

2018-01-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/475 Title: #475: AD: Use the right sdap_domain for the forest root lslebodn commented: """ Sure I'll run regression tests. Sorry for late reply. BTW I had an assumption that current version of PR is not final

[SSSD] [sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

2018-01-23 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/500 Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs lslebodn commented: """ That's a really nice catch. LGTM We might file a ticket to extract 167 lines from for loop to separate function to prevent such

[SSSD] [sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

2018-01-23 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/500 Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs sumit-bose commented: """ Yes, this is a typo which should be fixed. """ See the full comment at

[SSSD] [sssd PR#488][comment] Two fixes for certificates in idoverrides

2018-01-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/488 Title: #488: Two fixes for certificates in idoverrides jhrozek commented: """ The patches need to be rebased but the rebase seems easy. Can you help me check if I test the patches properly? I added a cert to default trust view (that's the only view