[SSSD] [sssd PR#508][comment] Fix/suppress few gcc8 warnings

2018-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings fidencio commented: """ CI: http://vm-031.${abc}/logs/job/83/77/summary.html There's a failure on rawhide, but it's been happening for a while and is not related to this patch. I am sorry it took so long to

[SSSD] [sssd PR#508][comment] Fix/suppress few gcc8 warnings

2018-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings fidencio commented: """ Btw, I am from the mobile now a days I didn't find a way to add the Accepted label. If someone else can do that for me, that would be appreciated. """ See the full comment at https:/

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 fidencio commented: """ ping! I either need a second reviewer here or a word saying that just my review is enough! """ See the full comment at https://github.com/SSSD/sssd/pull/496

[SSSD] [sssd PR#508][+Accepted] Fix/suppress few gcc8 warnings

2018-02-13 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#508][closed] Fix/suppress few gcc8 warnings

2018-02-13 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/508 Author: lslebodn Title: #508: Fix/suppress few gcc8 warnings Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/508/head:pr508 git checkout pr508 __

[SSSD] [sssd PR#508][comment] Fix/suppress few gcc8 warnings

2018-02-13 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings lslebodn commented: """ master: * bd5f48540b25dae81c43feb1d6aba4175da52098 * fcf6a9f34c475b9bbae54311703e87acd5fb8d1a * c53997720b231ad61af435a3124c7ecd731fc99b * 2951a9a84bd85f384213a3e071ffc167907df2d7 * 187

[SSSD] [sssd PR#508][+Pushed] Fix/suppress few gcc8 warnings

2018-02-13 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#475][comment] AD: Use the right sdap_domain for the forest root

2018-02-13 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/475 Title: #475: AD: Use the right sdap_domain for the forest root lslebodn commented: """ I ran tests twice in clean environment and it is fixed. I had to mix something up yesterday. ACK Thank you very much for fixing this regression and sorry for long i

[SSSD] [sssd PR#475][+Accepted] AD: Use the right sdap_domain for the forest root

2018-02-13 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/475 Title: #475: AD: Use the right sdap_domain for the forest root Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahos

[SSSD] [sssd PR#475][comment] AD: Use the right sdap_domain for the forest root

2018-02-13 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/475 Title: #475: AD: Use the right sdap_domain for the forest root lslebodn commented: """ master: * 9ac071272ce0152eb293d3181a5c12b395655521 """ See the full comment at https://github.com/SSSD/sssd/pull/475#issuecomment-365294269

[SSSD] [sssd PR#475][closed] AD: Use the right sdap_domain for the forest root

2018-02-13 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/475 Author: jhrozek Title: #475: AD: Use the right sdap_domain for the forest root Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/475/head:pr475 git checkout pr475

[SSSD] [sssd PR#475][+Pushed] AD: Use the right sdap_domain for the forest root

2018-02-13 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/475 Title: #475: AD: Use the right sdap_domain for the forest root Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 fidencio commented: """ @jhrozek, @pbrezina, @mzidek-rh ... may I ask you guys for a review of this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/496#issueco

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 jhrozek commented: """ I put it on my todo list, but only after some authselect reviews, so if anyone beats me to the review, I won't be mad. """ See the full comment at https://gi

[SSSD] [sssd PR#498][synchronized] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/498 Author: fidencio Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/498/head:pr498 git checkout pr498 From 0a2b0848a4491

[SSSD] [sssd PR#498][comment] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/498 Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE fidencio commented: """ @simo5, updated the patches according to your suggestion and did a local test here and it works like a charm. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#498][comment] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-02-13 Thread simo5
URL: https://github.com/SSSD/sssd/pull/498 Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE simo5 commented: """ I cannot set labels, but ACK """ See the full comment at https://github.com/SSSD/sssd/pull/498#issuecomment-365428458 ___ sssd-d

[SSSD] [sssd PR#498][comment] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-02-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/498 Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE fidencio commented: """ Thanks for the review, @simo5. I'll add the accepted label (per your review) as soon as I hear back from Oliver (from FleetCommander) that his tests passed as well. """