[SSSD] [sssd PR#634][comment] P11: Don't return int failure from a bool function

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function fidencio commented: """ master: 7225bab """ See the full comment at https://github.com/SSSD/sssd/pull/634#issuecomment-412120291 ___

[SSSD] [sssd PR#634][+Pushed] P11: Don't return int failure from a bool function

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#631][-Accepted] nss: remove unused label

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of

[SSSD] [sssd PR#631][comment] nss: remove unused label

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label fidencio commented: """ master: e8b417e """ See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-412120488 ___ sssd-devel mailing list --

[SSSD] [sssd PR#634][-Accepted] P11: Don't return int failure from a bool function

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#634][+Accepted] P11: Don't return int failure from a bool function

2018-08-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#634][comment] P11: Don't return int failure from a bool function

2018-08-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function sumit-bose commented: """ ACK from me as well. """ See the full comment at https://github.com/SSSD/sssd/pull/634#issuecomment-412103322 ___

[SSSD] [sssd PR#630][comment] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/630 Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder fidencio commented: """ @jhrozek, I found out a few more issues related to the last patch of the latest series,

[SSSD] [sssd PR#631][comment] nss: remove unused label

2018-08-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label sumit-bose commented: """ Ok, CI passed with an unrealated issue. ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-412110512 ___

[SSSD] [sssd PR#631][+Accepted] nss: remove unused label

2018-08-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of

[SSSD] [sssd PR#631][+Pushed] nss: remove unused label

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of

[SSSD] [sssd PR#631][closed] nss: remove unused label

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/631 Author: fidencio Title: #631: nss: remove unused label Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/631/head:pr631 git checkout pr631

[SSSD] [sssd PR#601][-Changes requested] sbus: integrate sssd with sbus2

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#634][closed] P11: Don't return int failure from a bool function

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/634 Author: jhrozek Title: #634: P11: Don't return int failure from a bool function Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/634/head:pr634 git checkout pr634

[SSSD] [sssd PR#632][-Accepted] tests: fix sss_nss_idmap-tests

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/632 Title: #632: tests: fix sss_nss_idmap-tests Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora

[SSSD] [sssd PR#632][closed] tests: fix sss_nss_idmap-tests

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/632 Author: sumit-bose Title: #632: tests: fix sss_nss_idmap-tests Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/632/head:pr632 git checkout pr632

[SSSD] [sssd PR#632][comment] tests: fix sss_nss_idmap-tests

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/632 Title: #632: tests: fix sss_nss_idmap-tests fidencio commented: """ master: da9e34e """ See the full comment at https://github.com/SSSD/sssd/pull/632#issuecomment-412119927 ___ sssd-devel mailing list --

[SSSD] [sssd PR#632][+Pushed] tests: fix sss_nss_idmap-tests

2018-08-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/632 Title: #632: tests: fix sss_nss_idmap-tests Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code

[SSSD] [sssd PR#630][-Changes requested] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder

2018-08-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/630 Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder Label: -Changes requested ___ sssd-devel mailing list --

[SSSD] [sssd PR#630][comment] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder

2018-08-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/630 Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder jhrozek commented: """ Thank you for the review, I hope all comments were addressed (modulo those where I asked what

[SSSD] [sssd PR#632][comment] tests: fix sss_nss_idmap-tests

2018-08-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/632 Title: #632: tests: fix sss_nss_idmap-tests sumit-bose commented: """ @panlinux, thank you for the feedback. @fidencio, please wait a bit before commiting the patch, I'm evaluating a change atm. """ See the full comment at

[SSSD] [sssd PR#631][comment] nss: remove unused label

2018-08-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label sumit-bose commented: """ Thanks, I've started a CI run. """ See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-411987087 ___ sssd-devel mailing

[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-08-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option sumit-bose commented: """ @fidencio, yes, I'm currently reviewing @lslebodn patch. """ See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-411987368

[SSSD] [sssd PR#634][opened] P11: Don't return int failure from a bool function

2018-08-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/634 Author: jhrozek Title: #634: P11: Don't return int failure from a bool function Action: opened PR body: """ The functions return bool as per their prototype, but returning EINVAL on failure meant that EINVAL (typically 22) was converted to 'true', so

[SSSD] [sssd PR#634][comment] P11: Don't return int failure from a bool function

2018-08-10 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function pbrezina commented: """ Obvious ack. """ See the full comment at https://github.com/SSSD/sssd/pull/634#issuecomment-412081632 ___ sssd-devel

[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2

2018-08-10 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 pbrezina commented: """ Right. The problem was when reading the keytab as you wrote in the mail. I did not notice it because my test keytab is readable by all. I moved `become_user` after the point where

[SSSD][sssd PR#633][opened] nss_protocol_fill_initgr: fix label ‘done’ defined but not used

2018-08-10 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/633 Author: pbrezina Title: #633: nss_protocol_fill_initgr: fix label ‘done’ defined but not used Action: opened PR body: """ CC src/responder/nss/nss_protocol_netgr.o /home/pbrezina/workspace/sssd/src/responder/nss/nss_protocol_grent.c: In

[SSSD] [sssd PR#601][+Changes requested] sbus: integrate sssd with sbus2

2018-08-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2

2018-08-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 jhrozek commented: """ Another issue revelaed by tests is that starting with `user=sssd` does not work at the moment.. """ See the full comment at

[SSSD][sssd PR#633][comment] nss_protocol_fill_initgr: fix label ‘done’ defined but not used

2018-08-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/633 Title: #633: nss_protocol_fill_initgr: fix label ‘done’ defined but not used sumit-bose commented: """ @pbrezina, there is already https://github.com/SSSD/sssd/pull/631 by @fidencio. """ See the full comment at

[SSSD][sssd PR#633][comment] nss_protocol_fill_initgr: fix label ‘done’ defined but not used

2018-08-10 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/633 Title: #633: nss_protocol_fill_initgr: fix label ‘done’ defined but not used pbrezina commented: """ Right. """ See the full comment at https://github.com/SSSD/sssd/pull/633#issuecomment-412061435 ___

[SSSD][sssd PR#633][closed] nss_protocol_fill_initgr: fix label ‘done’ defined but not used

2018-08-10 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/633 Author: pbrezina Title: #633: nss_protocol_fill_initgr: fix label ‘done’ defined but not used Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/633/head:pr633 git checkout pr633