Re: [SSSD] [WIKI] Contribute and DevelTips are duplicate

2015-08-17 Thread Petr Cech
On 07/17/2015 01:26 PM, Petr Cech wrote: Hi, I have read the wiki pages. And I have the edited version. It would be difficult to send the diff, so I started a new pages where you can view the result. Original pages: [ 1] https://fedorahosted.org/sssd/wiki/Contribute [ 2] https

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-18 Thread Petr Cech
to discussion. I look forward to your views. Petr From 511224743e8d8e788e9701f0fb3db418ca12b506 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Tue, 18 Aug 2015 06:59:31 -0400 Subject: [PATCH] DATA_PROVIDER: BE_REQ as string in log message Add be_req2str() for translation BE_REQ

Re: [SSSD] [PATCH] TESTS: Removing part of responder_cache_req-tests

2015-08-21 Thread Petr Cech
inline. I agree. Those tests have another logic. So I returned them back. Petr From 63defe03797a8a9038e49400089a732bd35efaca Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Fri, 21 Aug 2015 16:44:37 +0200 Subject: [PATCH] TESTS: Removing part of responder_cache_req-tests If you call

Re: [SSSD] [PATCH] sssd: incorrect checks on length values during packet, decoding

2015-08-21 Thread Petr Cech
On 07/23/2015 02:44 PM, Michal Židek wrote: Hi, see the attached patch for ticket https://fedorahosted.org/sssd/ticket/1697 I think this is a candidate to include in our coding guidelines. I agree. It is a candidate. Thanks, Michal ___

[SSSD]Re: Re: [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-21 Thread Petr Cech
of changes in source files that require both of them. Thanks. There is repaired patch attached. Petr From 7f154378f56a01ca65bfeba9985c605214d628b8 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Tue, 18 Aug 2015 06:59:31 -0400 Subject: [PATCH] DATA_PROVIDER: BE_REQ as string in log

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-21 Thread Petr Cech
aebda5def026d7a0fc40c4034ef18ba97ada5f36 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Tue, 18 Aug 2015 06:59:31 -0400 Subject: [PATCH] DATA_PROVIDER: BE_REQ as string in log message Add be_req2str() for translation BE_REQ to string. So we will have || Got request for [0x1001][FAST

[SSSD]Re: Re: [PATCH] TESTS: ldap_id_cleanup timeouts

2015-08-21 Thread Petr Cech
On 08/21/2015 01:33 PM, Michal Židek wrote: On 08/20/2015 01:50 PM, Petr Cech wrote: On 08/19/2015 08:26 PM, Michal Židek wrote: Hi! This is another patch to avoid failing tests in the CI (make-check-valgrind). This time the ldap_id_cleanup tests. Looks like the one second cache timeout

Re: [SSSD] [PATCH] TESTS: ldap_id_cleanup timeouts

2015-08-20 Thread Petr Cech
On 08/19/2015 08:26 PM, Michal Židek wrote: Hi! This is another patch to avoid failing tests in the CI (make-check-valgrind). This time the ldap_id_cleanup tests. Looks like the one second cache timeout was too short and the tests sometimes failed because they expected the entries to be still

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-08-18 Thread Petr Cech
On 08/13/2015 11:11 AM, Lukas Slebodnik wrote: From a93e36f11759cf9a748942e7632d4a07a088b098 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Wed, 8 Jul 2015 07:17:28 -0400 Subject: [PATCH] UTIL: Function 2string for enum sss_cli_command Improvement of debug messages. Instead

Re: [SSSD] [WIP] [TEST]: Observation patch

2015-08-17 Thread Petr Cech
On 08/17/2015 08:52 AM, Lukas Slebodnik wrote: From c871c97862997df4e724647f1a0ce7297f2f059b Mon Sep 17 00:00:00 2001 From: Petr Cechpc...@redhat.com Date: Fri, 14 Aug 2015 13:17:22 +0200 Subject: [PATCH] TEST: Fix for responder_cache_req-tests Tests, that do not pass, have a problem with

[SSSD] [PATCH] BUILD: Repair dependecies on deprecated libraries

2015-07-28 Thread Petr Cech
From: Petr Cech pc...@redhat.com Date: Mon, 27 Jul 2015 12:52:49 -0400 Subject: [PATCH] BUILD: Repair dependecies on deprecated libraries From systemd version 209 up, there are no modules -login and -journal. M4 macro can switch the libraries due to systemd version. Resolves: https

Re: [SSSD] [PATCH] BUILD: Repair dependecies on deprecated libraries

2015-07-28 Thread Petr Cech
On 07/28/2015 01:34 PM, Lukas Slebodnik wrote: On (28/07/15 11:58), Petr Cech wrote: From fcf895ad8df932403dfc554a34ff0d8ceac72785 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Mon, 27 Jul 2015 12:52:49 -0400 Subject: [PATCH] BUILD: Repair dependecies on deprecated libraries

Re: [SSSD] [PATCH] SDAP: rename SDAP_CACHE_PURGE_TIMEOUT

2015-07-30 Thread Petr Cech
On 07/29/2015 08:51 PM, Jakub Hrozek wrote: On Wed, Jul 29, 2015 at 10:19:33AM +0200, Pavel Reichl wrote: Hello, please see trivial patch attached. While I was investigating case I found that to access value of 'ldap_purge_cache_timeout' option I need to use enum value

Re: [SSSD] [PATCH] SPEC: Update spec file for krb5_local_auth_plugin

2015-07-29 Thread Petr Cech
On 07/24/2015 09:46 AM, Lukas Slebodnik wrote: ehlo, patch is attached. LS 0001-SPEC-Update-spec-file-for-krb5_local_auth_plugin.patch From 9474dfc64cbd73ab25bf12660f6b55e5563fe14c Mon Sep 17 00:00:00 2001 From: Lukas Slebodniklsleb...@redhat.com Date: Fri, 24 Jul 2015 09:24:31 +0200

Re: [SSSD] IFP: use default limit if provided is 0

2015-08-14 Thread Petr Cech
On 08/13/2015 12:48 PM, Pavel Březina wrote: From eef083f774988fe8e6b6a5a8513a163fd7558b55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?=pbrez...@redhat.com Date: Thu, 13 Aug 2015 12:46:59 +0200 Subject: [PATCH] IFP: use default limit if provided is 0 Hi, CI:

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-14 Thread Petr Cech
ping :-) ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [WIP] [TEST]: Observation patch

2015-08-12 Thread Petr Cech
ATTACHMENTS: [1] cpu_braker.c [2] 0001-TEST-Observation-patch.patch From b58608eaadca863b28b0cc80b0588fa536d508b8 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Wed, 12 Aug 2015 15:41:03 +0200 Subject: [PATCH] [TEST]: Observation patch This patch is part of reproducer, nothing

Re: [SSSD] [WIP] [TEST]: Observation patch

2015-08-14 Thread Petr Cech
On 08/13/2015 07:49 AM, Lukas Slebodnik wrote: On (12/08/15 17:57), Petr Cech wrote: Hi, I have explored in detail why the test responder_cache_req-tests failed so often. I created a new VM with RHEL 6.7. OBSERVATION: How we know, CI machines are under pressure, so I wrote simple

[SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-07-24 Thread Petr Cech
] hbac_evaluate() ] Thanks. Petr From 2fcf13ef59f00b460afa77b27ef6cc2789b06393 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Fri, 24 Jul 2015 10:56:49 -0400 Subject: [PATCH] [HBAC]: Better libhbac debuging Added support for logging via external log function. Log provides information about

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-07-14 Thread Petr Cech
type as hexadecimal number. Maybe there are also other places. LS Petr From a93e36f11759cf9a748942e7632d4a07a088b098 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Wed, 8 Jul 2015 07:17:28 -0400 Subject: [PATCH] UTIL: Function 2string for enum sss_cli_command Improvement

[SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-07-15 Thread Petr Cech
-- be_get_account_info, the second is from src/responder/common/responder_dp -- sss_dp_get_account_msg Thanks. Petr From 78ba1b38af081001eaefae180adc4a45e8c673d9 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Wed, 15 Jul 2015 02:26:29 -0400 Subject: [PATCH] DATA_PROVIDER: BE_REQ as string

Re: [SSSD] [WIKI] Contribute and DevelTips are duplicate

2015-07-17 Thread Petr Cech
On 07/13/2015 11:02 PM, Jakub Hrozek wrote: On Fri, Jul 10, 2015 at 10:38:09AM +0200, Petr Cech wrote: Hi, Hi, sorry about the vacation-induced delay. This is a very useful proposal, see inline for my comments. I've read the wiki according to # https://fedorahosted.org/sssd/ticket/2706

Re: [SSSD] [PATCH] DEBUG: Preventing chown_debug_file if journald on

2015-10-21 Thread Petr Cech
On 10/05/2015 10:21 AM, Jakub Hrozek wrote: On Fri, Sep 25, 2015 at 02:05:14PM +0200, Petr Cech wrote: ping I can't start sssd as a service with this patch applied after switching from root to non-root: 1) add user=sssd to the [sssd] section 2) chown root.root /var/log/sssd/*.log

Re: [SSSD] [PATCH] DEBUG: Preventing chown_debug_file if journald on

2015-10-23 Thread Petr Cech
How to reproduce: Sumit wrote explanation to ticket comment. Better is if .log files missing. And you need run SSSD logging only to journal. Lukas wrote in soe mail above in thread, how to enable it. Thanks to all. Petr ___ sssd-devel mailing list

Re: [SSSD] [PATCH] DEBUG: Preventing chown_debug_file if journald on

2015-10-23 Thread Petr Cech
On 10/23/2015 02:18 PM, Petr Cech wrote: How to reproduce: Sumit wrote explanation to ticket comment. Better is if .log files missing. And you need run SSSD logging only to journal. Lukas wrote in soe mail above in thread, how to enable it. Thanks to all. Petr # sudo bash # systemctl stop

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-10-27 Thread Petr Cech
rom e3dd543eec09f6e4386bfe6f1505538575fe5356 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Fri, 2 Oct 2015 07:34:08 -0400 Subject: [PATCH 1/3] TEST: Add test_user_by_recent_filter_valid Test users_by_filter_valid() was removed in past. We will add two new tests instead of it. Logic

Re: [SSSD] [PATCH] Monitor: Show service pings at debug level 8

2015-10-27 Thread Petr Cech
On 10/27/2015 02:58 PM, Stephen Gallagher wrote: SSSDBG_CONF_SETTINGS is reserved for configuration information. These pings are generally just noise (when they fail, this is logged at SSDBG_FATAL_FAILURE). We should only log these at SSSDBG_TRACE_INTERNAL. Hi Stephen, CI tests are right:

Re: [SSSD] Review of umask() in SSSD

2015-10-21 Thread Petr Cech
On 10/12/2015 11:37 AM, Jakub Hrozek wrote: > From a15acee2495ee12190e711f3344e14c54fc73062 Mon Sep 17 00:00:00 2001 >From: Petr Cech<pc...@redhat.com> >Date: Wed, 7 Oct 2015 08:57:15 -0400 >Subject: [PATCH 10/11] KRB5_CHILD: More restrictive umask > >We could us

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-11-10 Thread Petr Cech
On 11/10/2015 08:29 AM, Pavel Reichl wrote: On 11/05/2015 05:29 PM, Petr Cech wrote: +void test_groups_by_recent_filter_valid(void **state) +{ +struct cache_req_test_ctx *test_ctx = NULL; +TALLOC_CTX *req_mem_ctx = NULL; +struct tevent_req *req = NULL; +const char

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-11-10 Thread Petr Cech
On 11/10/2015 08:37 AM, Lukas Slebodnik wrote: On (10/11/15 08:29), Pavel Reichl wrote: On 11/05/2015 05:29 PM, Petr Cech wrote: +void test_groups_by_recent_filter_valid(void **state) +{ +struct cache_req_test_ctx *test_ctx = NULL; +TALLOC_CTX *req_mem_ctx = NULL; +struct

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-11-10 Thread Petr Cech
On 11/09/2015 04:28 PM, Jakub Hrozek wrote: On Thu, Nov 05, 2015 at 05:29:25PM +0100, Petr Cech wrote: >On 11/04/2015 11:11 AM, Jakub Hrozek wrote: > >Hi, > > > >Sorry it took so long to get back to the review. I only have some minor > >comments, see inline.. >

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-11 Thread Petr Cech
On 11/11/2015 09:32 AM, Jakub Hrozek wrote: >Hi Jakub, > >I just sent the patch to the CI tests and they passed >http://sssd-ci.duckdns.org/logs/job/32/63/summary.html > > >Then I would prefer undocumented. It matches how we (don't) document the > >"command" option. >I agree with little

[SSSD] [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-11-09 Thread Petr Cech
Hello, please see first attempt of patch for: https://fedorahosted.org/sssd/ticket/2747 Regards Petr PS: # reproducer getent services -s sss l...@cygnus.dev >From 64d952f188e86a00c26ccbe26ad09231e6b6de2b Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Mon, 9 Nov 2

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-10 Thread Petr Cech
On 11/09/2015 07:17 PM, Stephen Gallagher wrote: There are problems inherent with passing the PID to the child process. There's no guarantee that the process still exists. In the worst-case, the PID could actually be reassigned to a new process and the output you got back from something like

Re: [SSSD] CONFIGURE: Bump AM_GNU_GETTEXT_VERSION

2015-11-12 Thread Petr Cech
On 11/10/2015 10:44 AM, Lukas Slebodnik wrote: ehlo, The function gettext was not detected properly with strict cflags even thought it was part of glibc. sh$ CFLAGS="-Werror" ./configure sh$ grep gt_cv_func_gnugettext config.log gt_cv_func_gnugettext1_libc=no gt_cv_func_gnugettext1_libintl=no

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-12 Thread Petr Cech
On 11/11/2015 12:25 PM, Jakub Hrozek wrote: On Wed, Nov 11, 2015 at 11:07:46AM +0100, Petr Cech wrote: >On 11/11/2015 09:32 AM, Jakub Hrozek wrote: > >>>Hi Jakub, > >>> > >>>I just sent the patch to the CI tests and they passed > >>>htt

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-12 Thread Petr Cech
On 11/11/2015 02:28 PM, Jakub Hrozek wrote: Hi, I think one of the prime reasons for #2861 was copy-pasting code. The two attached patches reduce the code duplication and hopefully will make future additions to Data Provider safer. Ideas on different solutions are welcome! Hi Jakub, I am

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-12 Thread Petr Cech
On 11/12/2015 01:08 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 01:03:33PM +0100, Petr Cech wrote: >On 11/11/2015 02:28 PM, Jakub Hrozek wrote: > >Hi, > > > >I think one of the prime reasons for #2861 was copy-pasting code. The > >two attached patches

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-12 Thread Petr Cech
On 11/12/2015 06:30 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 10:49:33AM +0100, Petr Cech wrote: >On 11/11/2015 12:25 PM, Jakub Hrozek wrote: > >On Wed, Nov 11, 2015 at 11:07:46AM +0100, Petr Cech wrote: > >>>On 11/11/2015 09:32 AM, Jakub Hrozek wrote:

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-11-12 Thread Petr Cech
bump ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-11-13 Thread Petr Cech
On 11/13/2015 11:32 AM, Jakub Hrozek wrote: On Fri, Nov 13, 2015 at 10:52:08AM +0100, Petr Cech wrote: >On 11/13/2015 10:30 AM, Petr Cech wrote: > >On 11/13/2015 10:27 AM, Petr Cech wrote: > >> > >>Patches are rebased now. I hope it will be ok now. > >>

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-11-13 Thread Petr Cech
On 11/13/2015 12:27 PM, Jakub Hrozek wrote: +req_mem_ctx = talloc_new(test_ctx->tctx); > >>+check_leaks_push(req_mem_ctx); > > > >I think the last question is whether we want to use this new context or > >just call check_leaks_push(test_ctx) recursively. I don't really mind > >too much,

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-13 Thread Petr Cech
On 11/13/2015 08:20 AM, Petr Cech wrote: >Hi Jakub, > >it works due to your reproducer. It is really need to have >setenforce == 1 You meant setenforce 0, right? Hi Jakub, yes, of course, I meant setenforce 1. It was mistake. --^-- 1 -->

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-11-13 Thread Petr Cech
On 11/13/2015 10:09 AM, Jakub Hrozek wrote: Hi, patch 003 doesn't apply cleanly for me, can you rebase? Patches are rebased now. I hope it will be ok now. Petr >From 3e43417db9b66bdb44d60b5f186156c5ac26ad4b Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Fri, 2 Oc

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-11-13 Thread Petr Cech
On 11/13/2015 10:27 AM, Petr Cech wrote: Patches are rebased now. I hope it will be ok now. Petr Sorry, now my local CI tests failed... I will rebase it again. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-15 Thread Petr Cech
On 11/11/2015 02:28 PM, Jakub Hrozek wrote: Hi, I think one of the prime reasons for #2861 was copy-pasting code. The two attached patches reduce the code duplication and hopefully will make future additions to Data Provider safer. Ideas on different solutions are welcome! Hello Jakub, I

Re: [SSSD] [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-11-12 Thread Petr Cech
00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Mon, 9 Nov 2015 09:51:05 -0500 Subject: [PATCH] IPA_PROVIDER: Explicit no handle of services Services for IPA subdomains aren't handled by SSSD. This patch add quick shortcut to avoid sending an LDAP query. Resolves: https://fedorahosted

Re: [SSSD] [PATCHES] UTIL: Fix memory leak in switch_creds

2015-11-10 Thread Petr Cech
On 11/11/2015 08:04 AM, Lukas Slebodnik wrote: On (11/11/15 07:58), Petr Cech wrote: >On 11/09/2015 08:06 AM, Lukas Slebodnik wrote: >>ehlo, >> >>You can see a leak in talloc report. >>But it was ignored. So we didn't notice it for long time. >>http://sssd-ci

Re: [SSSD] [PATCHES] UTIL: Fix memory leak in switch_creds

2015-11-10 Thread Petr Cech
On 11/09/2015 08:06 AM, Lukas Slebodnik wrote: ehlo, You can see a leak in talloc report. But it was ignored. So we didn't notice it for long time. http://sssd-ci.duckdns.org/logs/job/29/90/rhel7/ci-build-debug/src/tests/cwrap/become_user-tests.log The first patch fixes the leak and the last

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-11 Thread Petr Cech
On 11/10/2015 04:20 PM, Jakub Hrozek wrote: On Tue, Nov 10, 2015 at 01:22:54PM +0100, Lukas Slebodnik wrote: >On (10/11/15 13:15), Jakub Hrozek wrote: > >On Mon, Nov 09, 2015 at 11:32:30AM +0100, Petr Cech wrote: > >>On 11/04/2015 11:24 AM, Jakub Hrozek wrote: > &

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-09 Thread Petr Cech
On 11/04/2015 11:24 AM, Jakub Hrozek wrote: Hi, I created this patch to try to diagnose an issue where sssd would randomly restart on any of machines in a VM cluster without giving too much advise why. I think it might be useful to merge in general. Hi Jakub, I reviewed the patch. Code looks

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-11-01 Thread Petr Cech
On 10/27/2015 09:42 AM, Petr Cech wrote: The removed tests were: * users_by_filter_valid * users_by_filter_multiple_domains_valid * groups_by_filter_valid * groups_by_filter_multiple_domains_valid Hello, another patch set is attached. This patch set covers groups_by_filter_valid

Re: [SSSD] [PATCH] sudo: remove unused param name in sdap_sudo_get_usn()

2015-11-02 Thread Petr Cech
On 11/02/2015 03:09 PM, Petr Cech wrote: On 11/02/2015 03:03 PM, Pavel Reichl wrote: Hello, please see simple patch attached. Thanks! LGTM, I am waiting for CI :-) Petr CI tests passed: http://sssd-ci.duckdns.org/logs/job/31/85/summary.html => ACK P

Re: [SSSD] [PATCH] sudo: remove unused param name in sdap_sudo_get_usn()

2015-11-02 Thread Petr Cech
On 11/02/2015 03:03 PM, Pavel Reichl wrote: Hello, please see simple patch attached. Thanks! ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel LGTM, I am waiting for CI :-)

Re: [SSSD] Review of umask() in SSSD

2015-11-05 Thread Petr Cech
On 10/21/2015 03:19 PM, Petr Cech wrote: On 10/12/2015 11:37 AM, Jakub Hrozek wrote: > From a15acee2495ee12190e711f3344e14c54fc73062 Mon Sep 17 00:00:00 2001 >From: Petr Cech<pc...@redhat.com> >Date: Wed, 7 Oct 2015 08:57:15 -0400 >Subject: [PATCH 10/11] KRB5_CHILD: More restr

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-11-05 Thread Petr Cech
and resend in a single set. Thanks for the tests! > From e3dd543eec09f6e4386bfe6f1505538575fe5356 Mon Sep 17 00:00:00 2001 >From: Petr Cech<pc...@redhat.com> >Date: Fri, 2 Oct 2015 07:34:08 -0400 >Subject: [PATCH 1/3] TEST: Add test_user_by_recent_filter_valid > >Te

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-10-15 Thread Petr Cech
ping ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] Review of umask() in SSSD

2015-10-07 Thread Petr Cech
with Sumit (thanks). I'd like to ask about any special care at patch 0010-KRB5-CHILD. I investigated it, but second look will be better. Regards Petr >From 97f8c14b58f29cf3ce341ead29f17204faa60f3d Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Mon, 5 Oct 2015 09:38

Re: [SSSD] Review of umask() in SSSD

2015-10-13 Thread Petr Cech
On 10/12/2015 11:37 AM, Jakub Hrozek wrote: On Wed, Oct 07, 2015 at 03:55:17PM +0200, Petr Cech wrote: On 10/04/2015 09:39 PM, Jakub Hrozek wrote: Finally, because I'm a lazy reviewer, I would prefer: - a patch that converts 0177 to DFL, with a comment around the macro definition

Re: [SSSD] [PATCH] SDAP: rem warning - sizelimit exceeded in POSIX check

2015-10-13 Thread Petr Cech
Hi everyone, we just discussed 'function wrapper' topic offline. I agree that it is not ideal to add new parameter to the function. And I agree that in languages like C, we have return value model. On the other hand, we have clean code on our minds. So I think that wrappers like: # int

Re: [SSSD] [WIKI] Contribute and DevelTips are duplicate

2015-10-06 Thread Petr Cech
On 09/03/2015 04:02 PM, Petr Cech wrote: I just updated the wiki pages. I will send another mail for it. But in this thread, I would like to note, what is exactly done. Original pages: [ 1] https://fedorahosted.org/sssd/wiki/Contribute [ 2] https://fedorahosted.org/sssd/wiki/DevelTips [ 3

[SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-07-08 Thread Petr Cech
Hi! https://fedorahosted.org/sssd/ticket/2703 It's my first patch to this ticket. It is simple transforming of number of command to the string. Petr From ca782a1518480635ef60bc2cdf77d9b8644132b0 Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Wed, 8 Jul 2015 07:17:28 -0400

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-07-08 Thread Petr Cech
On 07/08/2015 02:46 PM, Pavel Reichl wrote: On 07/08/2015 02:13 PM, Petr Cech wrote: Hi! https://fedorahosted.org/sssd/ticket/2703 It's my first patch to this ticket. It is simple transforming of number of command to the string. Petr Hello Petr, thank for the patch! I haven't tested

[SSSD] [WIKI] Contribute and DevelTips are duplicate

2015-07-10 Thread Petr Cech
Hi, I've read the wiki according to # https://fedorahosted.org/sssd/ticket/2706 and I think that it could be helpful clean the page # https://fedorahosted.org/sssd/wiki/DevelTutorials from git topic and create new page for everything related to git. The motivation is, that: * Contribute

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-07-09 Thread Petr Cech
at 02:13:42PM +0200, Petr Cech wrote: Hi! https://fedorahosted.org/sssd/ticket/2703 It's my first patch to this ticket. It is simple transforming of number of command to the string. Hi Petr, welcome and thank you for your first patch. Besides Pavel's suggestions I have some general comments

Re: [SSSD] Code style -- for loop iterative variables initial declaration

2015-08-28 Thread Petr Cech
On 08/28/2015 09:18 AM, Lukas Slebodnik wrote: On (28/08/15 09:03), Petr Cech wrote: Hi everyone, I would like to ask you what you think about the initialization of iterative variables in forloops. I know that present code style does not allow it. But how I recognized, we use C99

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-28 Thread Petr Cech
On 08/28/2015 03:13 PM, Petr Cech wrote: I am doing code review for fixed patch now. Patch looks good to me and it works. I discussed the problem above (about fprintf vs. libpopt) with both offline. The libpopt solution starts here [1] and I agree it would not be straightforward. So I am

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-28 Thread Petr Cech
On 08/28/2015 12:25 PM, Pavel Březina wrote: I would be also curious why you need to provide hacks for printing argument description for autohelp. There is a much more elegant way how to do it with libpopt. (small hint POPT_ARGFLAG_DOC_HIDDEN in sss_tool_common_opts) Your curiosity is

Re: [SSSD] [PATCH] TESTS: ldap_id_cleanup timeouts

2015-08-28 Thread Petr Cech
On 08/27/2015 05:49 PM, Michal Židek wrote: I agree. Attached is the same patch that was already ACKed, just with the changed name and added const. Michal Yes, it is the same, with const. ACK again. Petr ___ sssd-devel mailing list

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-28 Thread Petr Cech
. There is improved patch attached. Petr From baf0f51e8444bb0862efe4347d245f0b01834cfc Mon Sep 17 00:00:00 2001 From: Petr Cech pc...@redhat.com Date: Tue, 18 Aug 2015 06:59:31 -0400 Subject: [PATCH] DATA_PROVIDER: BE_REQ as string in log message Add be_req2str() for translation BE_REQ to string. So

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-26 Thread Petr Cech
On 08/24/2015 03:45 PM, Pavel Reichl wrote: On 07/24/2015 06:20 PM, Petr Cech wrote: From 2fcf13ef59f00b460afa77b27ef6cc2789b06393 Mon Sep 17 00:00:00 2001 From: Petr Cechpc...@redhat.com Date: Fri, 24 Jul 2015 10:56:49 -0400 Subject: [PATCH] [HBAC]: Better libhbac debuging s/debuging

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-31 Thread Petr Cech
. I agree. On 08/26/2015 09:44 AM, Petr Cech wrote: 0001-TESTS-Fixing-of-uninitialized-pointer.patch Nice catch! Ci passed. ACK to this patch Thanks. 0002-HBAC-Better-libhbac-debugging.patch From 75d97a5336e2b66d4bb187ce024ad9be9b2702b9 Mon Sep 17 00:00:00 2001 From: Petr Cech

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-08-31 Thread Petr Cech
On 08/31/2015 01:32 PM, Pavel Reichl wrote: 0x2000 (Mon Aug 31 07:03:04 2015) [sssd[be[cygnus.dev]]] [hbac] (0x0100): [../src/providers/ipa/hbac_evaluator.c:152] [< hbac_evaluate() (Mon Aug 31 07:03:04 2015) [sssd[be[cygnus.dev]]] [hbac] (0x2000): [../src/providers/ipa/hbac_evaluator.c:409]

Re: [SSSD] Code style -- for loop iterative variables initial declaration

2015-08-31 Thread Petr Cech
On 08/31/2015 01:09 PM, Alexander Bokovoy wrote: On Mon, 31 Aug 2015, Lukas Slebodnik wrote: On (29/08/15 14:33), Alexander Bokovoy wrote: On Fri, 28 Aug 2015, Petr Cech wrote: Hi everyone, I would like to ask you what you think about the initialization of iterative variables in forloops

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

2015-09-01 Thread Petr Cech
sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel I am sorry. There is a fix attached. Petr >From 93dbe494d14df22b6e33d100d40a3665a2990e56 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Tue, 1 Sep 2015 02:40:36 -0400 Su

[SSSD] Wiki pages updated

2015-09-03 Thread Petr Cech
Hi, I just updated the wiki pages. I removed some duplicated and outdated info. I hope that the pages are now clearer. Petr PS: If you need more info, see thread "[SSSD] [WIKI] Contribute and DevelTips are duplicate". ___ sssd-devel mailing list

Re: [SSSD] [WIKI] Contribute and DevelTips are duplicate

2015-09-03 Thread Petr Cech
On 09/02/2015 05:47 PM, Jakub Hrozek wrote: On Wed, Sep 02, 2015 at 05:18:24PM +0200, Michal Židek wrote: On 08/17/2015 02:21 PM, Petr Cech wrote: On 07/17/2015 01:26 PM, Petr Cech wrote: Hi, I have read the wiki pages. And I have the edited version. It would be difficult to send the diff

[SSSD] Fix #2275 nested netgroups do not work in IPA provider

2015-09-02 Thread Petr Cech
Hi, reverting this commit "5e9bc89b28f1ac3ce573ecdece74fe9623580c28" fixed the problem for me. So is the original commit no longer valid? Regards, Petr >From 3a161789fc8ef82f4636e55369f4c5b04985f7c2 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Wed,

Re: [SSSD] Fix #2275 nested netgroups do not work in IPA provider

2015-09-04 Thread Petr Cech
On 09/04/2015 03:24 PM, Petr Cech wrote: On 09/03/2015 03:45 PM, Sumit Bose wrote: I tried both case. I used only originalMemberOf and I had right hostgroups, >no user groups. Then I used only memberOf and I had no hostgroups, right >user groups. > >So I did little hack, we co

Re: [SSSD] Fix #2275 nested netgroups do not work in IPA provider

2015-09-04 Thread Petr Cech
nes like: # { "ldap_user_member_of", "memberOf", SYSDB_ORIG_MEMBEROF, NULL } and it works for me. I hope that meaning of this patch is saving user/POSIX group memberOf attribute to originalMemberOf attribute. Regards, Petr >From a5b0e35de6a9cb6e9e1881deaae9fa55701aa33a

Re: [SSSD] [PATCH] UTIL: Alternative way for debug message initialisation

2015-09-08 Thread Petr Cech
On 09/08/2015 03:31 PM, Lukas Slebodnik wrote: I would rather used option d) than option a). (Do not change anything) Option b) does not require namespacing, because it is a local macro. Option c) is the most readable, but there is a collision with gnu gettext. So it cannot be used. LS Only

Re: [SSSD] Fix #2275 nested netgroups do not work in IPA provider

2015-09-03 Thread Petr Cech
On 09/03/2015 08:18 AM, Jakub Hrozek wrote: On Thu, Sep 03, 2015 at 06:15:24AM +0200, Lukas Slebodnik wrote: On (02/09/15 18:06), Petr Cech wrote: Hi, reverting this commit "5e9bc89b28f1ac3ce573ecdece74fe9623580c28" fixed the problem for me. So is the original commit no longer va

Re: [SSSD] Fix #2275 nested netgroups do not work in IPA provider

2015-09-03 Thread Petr Cech
On 09/03/2015 10:08 AM, Sumit Bose wrote: On Thu, Sep 03, 2015 at 09:54:51AM +0200, Jakub Hrozek wrote: On Thu, Sep 03, 2015 at 09:31:07AM +0200, Petr Cech wrote: On 09/03/2015 08:18 AM, Jakub Hrozek wrote: On Thu, Sep 03, 2015 at 06:15:24AM +0200, Lukas Slebodnik wrote: On (02/09/15 18:06

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-01 Thread Petr Cech
On 09/01/2015 11:00 AM, Pavel Reichl wrote: From 6b1c6cac7123e78a2c55c51019b66a6bcf97ec29 Mon Sep 17 00:00:00 2001 From: Petr Cech<pc...@redhat.com> Date: Fri, 24 Jul 2015 10:56:49 -0400 Subject: [PATCH 2/2] HBAC: Better libhbac debugging Added support for logging via external log fu

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-25 Thread Petr Cech
On 08/25/2015 01:00 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2758 Hi Pavel, I have 3 formal comments to coding style. Now I am running the tests. I will send you mail with results soon. Petr 0001-sss_override-document-debug-options.patch From

Re: [SSSD] [PATCH] sss_override: document --debug options

2015-08-25 Thread Petr Cech
On 08/25/2015 01:36 PM, Pavel Březina wrote: +static void sss_tool_print_common_opts(void) +{ +fprintf(stderr, _(Common options:\n)); +fprintf(stderr, -d, --debug=INT%s\n, +_(Enable debug at level)); I'm not sure, but is it habbit to indent to '('? I mean:

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-09-08 Thread Petr Cech
On 09/04/2015 04:32 PM, Pavel Reichl wrote: On 08/28/2015 04:31 PM, Petr Cech wrote: + "Got request for [%#x][%s][%d][%s]\n", type, be_req2str(type), + attr_type, filter); Petr do you think it could be useful to print attr_type as a string? We talked about

[SSSD] Review of umask() in SSSD

2015-09-10 Thread Petr Cech
Hi, I am reviewing umask() in our code according to https://fedorahosted.org/sssd/ticket/2424 There are many use like umask(DFL_RSP_UMASK): src/responder/autofs/autofssrv.c:223 src/responder/ifp/ifpsrv.c:401 src/responder/nss/nsssrv.c:589 src/responder/pac/pacsrv.c:232

[SSSD] [PATCH] DEBUG: Preventing chown_debug_file if journald on

2015-09-10 Thread Petr Cech
Hi, patch for https://fedorahosted.org/sssd/ticket/2493 is attached. Petr >From 1d87d8dd390c229ac603569a604d9cca656c3f1b Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Thu, 10 Sep 2015 10:05:59 -0400 Subject: [PATCH] DEBUG: Preventing chown_debug_file if

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-14 Thread Petr Cech
0.1.0 { +global: +hbac_evaluate; +} IPA_HBAC_0.0.1; -- >From 3b235cdc2c8d55dbaac9a78f82bef12576346b97 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Wed, 26 Aug 2015 02:50:26 -0400 Subject: [PATCH 1/2] TESTS: Fixing of uninitialized pointer. There was a bug with uninitialized pointer during solvin

Re: [SSSD] [PATCH] DEBUG: Preventing chown_debug_file if journald on

2015-09-14 Thread Petr Cech
variable debug_to_stderr. Petr >From 8cb0a4a6b59259e9096ae6f5926595b7b10d6b27 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Thu, 10 Sep 2015 10:05:59 -0400 Subject: [PATCH] DEBUG: Preventing chown_debug_file if journald on There is function chown_debug_file() which did

Re: [SSSD] [PATCH] cache_req: support UPN

2015-09-16 Thread Petr Cech
On 09/14/2015 01:34 PM, Pavel Březina wrote: On 09/14/2015 01:32 PM, Pavel Březina wrote: 0001: Use extra flag also in OOB request. 0002: Provide support for UPN. This add an improvement from NSS code, but I'm not sure if it is desired or not. If you have [domain/AD.PB] in sssd.conf and UPN

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-09-15 Thread Petr Cech
On 09/14/2015 03:25 PM, Jakub Hrozek wrote: On Mon, Sep 14, 2015 at 02:15:39PM +0200, Petr Cech wrote: From 4246d5cd91c4c34b8524be5bfce38c57163a6e2b Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik<lsleb...@redhat.com> Date: Fri, 11 Sep 2015 17:04:58 +0200 Subject: [PATCH] squ

Re: [SSSD] [PATCH] cache_req: support UPN

2015-09-17 Thread Petr Cech
Hi Pavel! There is some code between my last end and this continuation. I was read it and did't find anything wrong. On 09/16/2015 04:26 PM, Petr Cech wrote: 0003-cache_req-tests-reduce-code-duplication.patch From e41f96a47f2b0f8d3e07e34af83e9a516d29df34 Mon Sep 17 00:00:00 2001 From

Re: [SSSD] Review of umask() in SSSD

2015-09-15 Thread Petr Cech
On 09/11/2015 01:47 PM, Jakub Hrozek wrote: On Thu, Sep 10, 2015 at 12:27:17PM +0200, Petr Cech wrote: Hi, I am reviewing umask() in our code according to https://fedorahosted.org/sssd/ticket/2424 There are many use like umask(DFL_RSP_UMASK): src/responder/autofs/autofssrv.c:223 src/responder

Re: [SSSD] RFC: Improving the debug messages

2015-09-30 Thread Petr Cech
On 09/30/2015 11:15 AM, Jakub Hrozek wrote: On Wed, Sep 30, 2015 at 09:53:24AM +0200, Sumit Bose wrote: It's https://fedorahosted.org/sssd/ticket/2808 . Please add ideas and suggestions how those tags shall look like. Thanks, I ressurected https://fedorahosted.org/sssd/ticket/1372 from

Re: [SSSD] Review of umask() in SSSD

2015-10-01 Thread Petr Cech
On 10/01/2015 01:19 PM, Jakub Hrozek wrote: On Thu, Oct 01, 2015 at 12:38:49PM +0200, Petr Cech wrote: Bump. Thanks for reply, Jakub. Why was 077 changed for 0177? This change is something, which I think was discussed earlier in this thread. # pcech: # > I would like to ask you if

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

2015-10-01 Thread Petr Cech
On 09/18/2015 04:30 PM, Petr Cech wrote: Hello, there are fixed patches attached. Bump. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] Review of umask() in SSSD

2015-10-01 Thread Petr Cech
Bump. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] TEST: recent_valid filter testing

2015-10-02 Thread Petr Cech
will send whole patch. Regards Petr PS: I applied my patch after 000*-cache_req_*. Those patches are on list. >From aa0b0ab7c0a95ff47d5003907730c5432ff7bb85 Mon Sep 17 00:00:00 2001 From: Petr Cech <pc...@redhat.com> Date: Fri, 2 Oct 2015 07:34:08 -0400 Subject: [PATCH] TEST: recent_valid filte

  1   2   3   4   >