[SSSD] [PATCH] rework identification against DP too

2009-08-11 Thread Simo Sorce
Change the identification sense against DP too like I did in the previous patches against the monitor. Simo. 0001-Change-the-why-DP-clients-identify.patch Description: application/mbox ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] rework identification against DP too

2009-08-11 Thread Simo Sorce
On Tue, 2009-08-11 at 13:01 -0400, Simo Sorce wrote: Change the identification sense against DP too like I did in the previous patches against the monitor. Patch did not apply on master after the last push, attaching a fixed patch. Simo. 0001-Change-the-why-DP-clients-identify.patch

[SSSD] [PATCH] ticket#101

2009-08-12 Thread Simo Sorce
Apparently parent and member got reversed when I rewrote some of the functions. Simo. 0001-Fix-reversal-of-parent-and-member-in-groupmod.patch Description: application/mbox ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [Freeipa-devel] [PATCHES] one for INI another for ELAPI

2009-08-12 Thread Simo Sorce
On Wed, 2009-08-12 at 11:41 -0400, Dmitri Pal wrote: Ah! Ok, that makes sense. I opened a ticket (103) to review the collection, INI and ELAPI code about the use of errno. I tried not to make this mistake but it seems like I did and you caught it - good! But this grants a better, a more

[SSSD] RFC: Enumerations and sssd drivers

2009-08-13 Thread Simo Sorce
Hello all, during this month I have been slowly working on a set of patches to move from storing information in 2 different formats (legacy and member/memberOf based) to just one format (member/memberOf based). While doing this I had to address some problems that come up when you want to store a

Re: [SSSD] RFC: Enumerations and sssd drivers

2009-08-13 Thread Simo Sorce
On Thu, 2009-08-13 at 08:54 -0400, Stephen Gallagher wrote: One potential idea would be to have the SSSD automatically start an enumeration at startup time if the cache is stale. Then, instead of blocking updates waiting for subsequent enumerations, we could just go immediately to the cache

Re: [SSSD] [PATCH] Don't go to the backend for identical cache entry requests

2009-08-13 Thread Simo Sorce
On Thu, 2009-08-13 at 12:18 -0400, Stephen Gallagher wrote: Currently, if an additional request comes in for a cache entry while that same entry is already in the process of being refreshed, we start a duplicate cache update request. This patch adds allows the cache to maintain a hash table of

Re: [SSSD] [PATCH] Fix DP reconnection code [#101]

2009-08-17 Thread Simo Sorce
On Mon, 2009-08-17 at 09:10 -0400, Simo Sorce wrote: Fix reconnection mess caused by double reconnection code. Remove one of the reconnection facilities and make code more uniform. Fixes ticket 101 Attached patch that correctly applies on top of current master. Simo. 0001-Fix-reconnection

Re: [SSSD] [PATCH] Ensure that fds are only added once in the sbus

2009-08-26 Thread Simo Sorce
leave the toggle function and instead treat an add of an existing watch as a simple toggle. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] Fix usage of wrong structure

2009-08-26 Thread Simo Sorce
Patch FYI. Pushed under the one-liner rule. -- Simo Sorce * Red Hat, Inc * New York From 180f59a2a2985de243c98c0e650087ab04f5a9e1 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Wed, 26 Aug 2009 15:14:37 -0400 Subject: [PATCH] Use the correct structure. --- server/providers

Re: [SSSD] [PATCH] do not show server messages to user

2009-08-27 Thread Simo Sorce
On Wed, 2009-08-26 at 08:48 -0400, Simo Sorce wrote: On Wed, 2009-08-26 at 14:40 +0200, Sumit Bose wrote: with this patch the server messages indicating the reason of an authentication error are not displayed to the user anymore. But they are still send to syslog. Ack Pushed, Simo

Re: [SSSD] [PATCHES] remove legacy option

2009-08-27 Thread Simo Sorce
On Thu, 2009-08-27 at 14:33 +0200, Sumit Bose wrote: On Thu, Aug 27, 2009 at 12:58:41AM -0400, Simo Sorce wrote: The legacy option was introduced to speed up development. It is actually confusing and not necessary. From now on we store all using the member/memberof schema internally

Re: [SSSD] [PATCH] send SSSD_REALM and SSSD_KDCIP environment to the client

2009-08-28 Thread Simo Sorce
by the kerberos locator plugin they can be removed. bye, Sumit sorry, the previous version depended on another not submitted patch. This on will work with the current master. Ack, and pushed. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd

Re: [SSSD] [PATCH] check if gid attribute is empty

2009-08-28 Thread Simo Sorce
the group object. Good catch! Ack and pushed. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCHES] python bindings for managing users in local domains

2009-08-28 Thread Simo Sorce
operation and simply pass in the handle to the sync ones, so that multiple sync operations can be linked into a single transaction. Patch 3: - looks sane but I'd like a second look from one of ours python resident experts Simo. -- Simo Sorce * Red Hat, Inc * New York

[SSSD] [PATCH] Turn enumeration parameter to boolean

2009-08-31 Thread Simo Sorce
Since we enumerate in background and use the member/memberof scheme you can't do group enumerations without also doing a user enumeration first. So turn the enumeration option into a boolean with warnings if the old syntax is used. Simo. -- Simo Sorce * Red Hat, Inc * New York From

Re: [SSSD] [PATCH] check if libpcre version is above or below 7

2009-09-01 Thread Simo Sorce
On Tue, 2009-09-01 at 14:02 -0400, Dmitri Pal wrote: RHEL 5 has version 7.8 The latest package for RHEL was 6.6 you must have a custom package on your system. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel

Re: [SSSD] [PATCH] Move RPM specfiles into contrib/

2009-09-01 Thread Simo Sorce
On Tue, 2009-09-01 at 16:15 -0400, Stephen Gallagher wrote: Also create a new spec file for RHEL5 Ack, although later it may be worth considering if it makes sense to have just one spec file with conditionals. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] Fix proxy enumerations with newer tevent

2009-09-02 Thread Simo Sorce
On Wed, 2009-09-02 at 14:53 +0200, Sumit Bose wrote: On Tue, Sep 01, 2009 at 04:36:26PM -0400, Simo Sorce wrote: newer tevent versions (correctly) fail if loops are nested. fix the code to never nest loops. Simo. If during a enumeration an uid/gid is found which is not in the range

Re: [SSSD] [PATCH] Fix proxy enumerations with newer tevent

2009-09-02 Thread Simo Sorce
On Wed, 2009-09-02 at 09:07 -0400, Simo Sorce wrote: On Wed, 2009-09-02 at 14:53 +0200, Sumit Bose wrote: On Tue, Sep 01, 2009 at 04:36:26PM -0400, Simo Sorce wrote: newer tevent versions (correctly) fail if loops are nested. fix the code to never nest loops. Simo

Re: [SSSD] [PATCH] remove the concept of a backend name

2009-09-02 Thread Simo Sorce
provider the expansion of 'provider=files' is affected, too. So tests which uses 'provider=files' might fail if I have messed up the expansion. Ack and pushed! Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel

Re: [SSSD] [PATCH] honour enumerate in ldap backend

2009-09-02 Thread Simo Sorce
On Wed, 2009-09-02 at 14:45 +0200, Sumit Bose wrote: On Tue, Sep 01, 2009 at 04:35:14PM -0400, Simo Sorce wrote: On Tue, 2009-09-01 at 16:33 -0400, Simo Sorce wrote: When enumerate is set to flse we don't return entries on an enumerating getent but we still run the enumeration task

Re: [SSSD] [PATCH] Move RPM specfiles into contrib/

2009-09-02 Thread Simo Sorce
On Wed, 2009-09-02 at 09:41 -0400, Stephen Gallagher wrote: New version. I have combined the two spec files into one and cleared up some glitches in the earlier patch. Looks good to me, ack Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd

Re: [SSSD] [RFC][PATCH] adding domain-type config option

2009-09-03 Thread Simo Sorce
by the module we load and not listed in a a common file otherwise we cannot let external modules set their defaults ? Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman

Re: [SSSD] [PATCH] Remove shadow-utils support from tools

2009-09-08 Thread Simo Sorce
On Tue, 2009-09-08 at 16:10 +0200, Jakub Hrozek wrote: The attached patch applies on top of Simo's two patches. ack, patch seem to work fin on top of my latest ones too. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd

Re: [SSSD] Unpleasant warnings

2009-09-08 Thread Simo Sorce
, but in this case fill_grent will return an error, too. Yet this is bad, as the function is supposed to always return how many entries have been used, even in case of errors. Attached a patch to fix this, that makes it explicit. Simo. -- Simo Sorce * Red Hat, Inc * New York From

Re: [SSSD] [PATCH] Split database file to one per domain

2009-09-08 Thread Simo Sorce
On Tue, 2009-09-08 at 15:11 -0400, Stephen Gallagher wrote: Merged Sumit's fix for the sdap timestamp = NULL into this patch and pushed. I hope you merged it in the proper patch ;-) Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel

Re: [SSSD] [PATCH] more fixes for older libpcre versions

2009-09-09 Thread Simo Sorce
On Wed, 2009-09-09 at 13:23 +0200, Sumit Bose wrote: Hi, older versions of libpcre only support the Python naming style, ?Pname, for subpatterns. This patch changes our default pattern and adds some hints about this. Ack. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] Cleanups for library linking

2009-09-09 Thread Simo Sorce
On Wed, 2009-09-09 at 14:19 +0200, Sumit Bose wrote: Hi, I think the LDAP provider should link agains a LDAP library. So far it only worked, because sssd_be exports all symbols and links against libldb which links against libldap. Absolutely, full ack! Simo. -- Simo Sorce * Red Hat, Inc

Re: [SSSD] [PATCHES] Handle invalid domain configuration better

2009-09-09 Thread Simo Sorce
are sensible (minId maxId, neither 0) ack this one. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCHES] Handle invalid domain configuration better

2009-09-09 Thread Simo Sorce
On Wed, 2009-09-09 at 14:25 -0400, Dmitri Pal wrote: Simo Sorce wrote: On Wed, 2009-09-09 at 13:33 -0400, Stephen Gallagher wrote: Patch 0001: Ensure that daemonization happens after reading in the configuration, so critical configuration errors repord FAILED during init script

[SSSD] [PATCH] fix offline detection for ldap driver

2009-09-09 Thread Simo Sorce
fix offline handling in ldap driver and make enumeration task respect offline as well as mark as offline when needed. Simo. -- Simo Sorce * Red Hat, Inc * New York From 29572e04b662076e0f463a1ebe1387e6216e2753 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Wed, 9 Sep 2009 16

Re: [SSSD] [PATCH] Read and validate configuration before daemonizing

2009-09-10 Thread Simo Sorce
context. Although I wouldn't consider a decision not to to this as reason to nack. The rest looks good. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo

Re: [SSSD] [PATCH] Properly detect negative/invalid values for the minId and maxId

2009-09-10 Thread Simo Sorce
the conversion in a function that returns the enum and saves the integer (if available) in a variable ? That would save us searching the message twice to get the same string. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list

Re: [SSSD] [PATCH] Read and validate configuration before daemonizing

2009-09-10 Thread Simo Sorce
are then discarded, we should probably change the code to create a tmp_ctx right before running sysdb_init() and then talloc_zfree(tmp_ctx) instead of the db_list. This would also cause the mem_ctx to not be necessary anymore. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] Collection improvements to copy functions

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 16:34 -0400, Stephen Gallagher wrote: Ack pushed -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Read and validate configuration before daemonizing

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 16:58 -0400, Stephen Gallagher wrote: On 09/10/2009 04:42 PM, Simo Sorce wrote: On Thu, 2009-09-10 at 16:18 -0400, Stephen Gallagher wrote: mem_ctx is not used anymore in this function as far as I can see, please remove it. It is still used for sysdb_init, so I

Re: [SSSD] [PATCH] COLLECTION Functions to deal with hash

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 18:07 -0400, Dmitri Pal wrote: A small patch that addresses my concerns related to ELAPI starting to have too much knowledge about internals of collection. See patch comments for details. Ack, good move. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] ELAPI Better separation from collection internals.

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 18:33 -0400, Dmitri Pal wrote: Getting paranoid about good layering of the interfaces... Patch fixes ELAPI part to take advantage of the collection public interfaces only. Keeping ourselves honest is always a good thing! Ack. Simo. -- Simo Sorce * Red Hat, Inc * New

[SSSD] [PATCHES] fix access to freed memory

2009-09-11 Thread Simo Sorce
In a couple of places Valgrind spotted a few bugs where memory was beeing freed too early. Following patches correct this errors. Simo. -- Simo Sorce * Red Hat, Inc * New York From f7968749cd062081421e72006581e0aacf547bab Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Fri, 11

Re: [SSSD] [PATCHES] fix access to freed memory

2009-09-11 Thread Simo Sorce
On Fri, 2009-09-11 at 14:23 -0400, Stephen Gallagher wrote: On 09/11/2009 01:50 PM, Simo Sorce wrote: In a couple of places Valgrind spotted a few bugs where memory was beeing freed too early. Following patches correct this errors. Patch 0001: Ack Patch 0002: Ack pushed Simo. -- Simo

Re: [SSSD] [PATCH] Add 'make tests' target

2009-09-11 Thread Simo Sorce
On Fri, 2009-09-11 at 15:34 -0400, Stephen Gallagher wrote: Per Simo's request, here is a patch to enable the building (but not executing) of tests for the SSSD. To build and run them, 'make check' still works. ack and pushed Simo. -- Simo Sorce * Red Hat, Inc * New York

[SSSD] [PATCH] fis docs with new options and remove legacy

2009-09-11 Thread Simo Sorce
Docs update. Simo. -- Simo Sorce * Red Hat, Inc * New York From 46d75e25ae6a9b088f48a264a99234db73db56ea Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Fri, 11 Sep 2009 17:11:56 -0400 Subject: [PATCH] Update documentation and examples Remove the legacy option from examples

Re: [SSSD] [PATCH] fix broken getgrnam and getgrgid

2009-09-11 Thread Simo Sorce
On Fri, 2009-09-11 at 16:32 -0400, Stephen Gallagher wrote: On 09/11/2009 04:17 PM, Simo Sorce wrote: The check_cache() patch broke them. This patch should fix the bug (ticket #177). Ack pushed -- Simo Sorce * Red Hat, Inc * New York ___ sssd

Re: [SSSD] [PATCH] fis docs with new options and remove legacy

2009-09-11 Thread Simo Sorce
On Fri, 2009-09-11 at 17:17 -0400, Jenny Galipeau wrote: Simo Sorce wrote: Docs update. That was easy. Nice description of the ldapSchema option. ack pushed Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd

Re: [SSSD] [PATCH] add change password target to krb5 backend

2009-09-11 Thread Simo Sorce
and pushed. Sorry it took so long, but wasn't able to test krb auth before today. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCHES] Two small patches to address minor issues with starting as non-root

2009-09-11 Thread Simo Sorce
as root, and exit with an error message if it is not (the same as the tools). ack and pushed both Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd

Re: [SSSD] [PATCH] Let the PAM client send its PID

2009-09-12 Thread Simo Sorce
On Sat, 2009-09-12 at 10:11 +0200, Sumit Bose wrote: On Fri, Sep 11, 2009 at 05:46:24PM -0400, Simo Sorce wrote: On Fri, 2009-09-11 at 17:10 +0200, Sumit Bose wrote: Most of items are not mandatory at the protocol level. If e.g. the remote host is not known to the client it is not sent

Re: [SSSD] [PATCHES] python bindings for managing users in local domains

2009-09-13 Thread Simo Sorce
for the 3rd patch. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] Make offline status backend global

2009-09-13 Thread Simo Sorce
, that will be done eventually when we integrate also the DNS discovery options. Tested with ldap_id+ldap_auth and ldap_id+krb5_auth Simo. -- Simo Sorce * Red Hat, Inc * New York From 0cdf03e956838ae727760f8c22255958199f8e89 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Sat, 12 Sep

Re: [SSSD] [PATCH] Make offline status backend global

2009-09-14 Thread Simo Sorce
and explanations are enough :) Simo. -- Simo Sorce * Red Hat, Inc * New York From a0b02295b0e0c55174b37ad3b231d28e0e1d1f50 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Sat, 12 Sep 2009 00:05:55 -0400 Subject: [PATCH] Make the offline status backend-global Add helpers functions to query

Re: [SSSD] [PATCH 1/3] Let the PAM client send its PID -- 2nd version

2009-09-14 Thread Simo Sorce
it is strictly necessary, but the extra check in the v3 parse function is worth to have. and version numbers are cheap anyway, so I'd go for it. ACK. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https

Re: [SSSD] [PATCH] Make basic options typed

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 18:21 +0200, Sumit Bose wrote: On Mon, Sep 14, 2009 at 11:32:40AM -0400, Simo Sorce wrote: On Mon, 2009-09-14 at 14:34 +0200, Sumit Bose wrote: Nack. Generates a segfault running getent passwd u...@ldap I cannot reproduce this with my setup

Re: [SSSD] [PATCH] Make offline status backend global

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 18:10 +0200, Sumit Bose wrote: I agree, this patch is a good starting point and we can add fine tuning later. ACK. pushed Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel

Re: [SSSD] [PATCH 1/3] Let the PAM client send its PID -- 2nd version

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 11:36 -0400, Simo Sorce wrote: On Mon, 2009-09-14 at 10:09 +0200, Sumit Bose wrote: Hi, this is the new version of the cli_pid patch with the missing size added. There are two related patches. 0002 removes the unused client locale. It was added at a time where

Re: [SSSD] [PATCH] add krb5ccache_dir and krb5ccname_template option

2009-09-14 Thread Simo Sorce
about discarding consts in the tests. Warnings are only cosmetic so I decide to push anyway, however please provide patch to remove or silence them. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel

Re: [SSSD] [PATCH] fix the wrong usage of an offset

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 21:26 +0200, Sumit Bose wrote: Hi, I hadn't checked a last minute change properly with the result that the detection if mkstemp should be used or not is broken. This patch should fix this. tested, acked, pushed Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] Add PRERELEASE_VERSION variable for use in sssd.spec.i

2009-09-15 Thread Simo Sorce
On Tue, 2009-09-15 at 13:21 -0400, Stephen Gallagher wrote: This will add a second, optional line to the VERSION file that will be used by the automated build scripts to create snapshot versions. Ack -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] ELAPI: Fix dispatcher structure initialization

2009-09-16 Thread Simo Sorce
a say from the main maintainer of the code before pushing a patch. Unless it is blocking other developers or is urgent for any other reasonable motive. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel

Re: [SSSD] [PATCH] proxy bug

2009-09-16 Thread Simo Sorce
On Wed, 2009-09-16 at 08:48 -0400, Simo Sorce wrote: Please make it a macro or a subroutine instead of adding it three times. Yeah, will do. Ok new patches attached, with members debug turned into a macro. Simo. -- Simo Sorce * Red Hat, Inc * New York From

[SSSD] [PATCHES] a few basic fixed that caused segfaults/aborts

2009-09-22 Thread Simo Sorce
0001 caught compiling against talloc 2.0 0002 fixes long standing segfault with proxy+files Simo. 0001-Fix-copy-paste-of-wrong-structure.patch Description: application/mbox 0002-Don-t-try-to-use-initgroups_dyn-if-not-available.patch Description: application/mbox

Re: [SSSD] [PATCH] Allow entering parent groups as FQDN

2009-09-23 Thread Simo Sorce
On Wed, 2009-09-23 at 11:48 +0200, Jakub Hrozek wrote: Allow entering parent groups for groupadd,useradd,usermod as FQDN. Since members and parents must be from the same domain, error out if we can't determine the domain of member. Fixes: #121 ack and pushed. Simo.

Re: [SSSD] [PATCH] Remove provider=files

2009-09-23 Thread Simo Sorce
On Wed, 2009-09-23 at 12:07 +0200, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Remove this provider type, as well as any references in the docs and examples to the LEGACYLOCAL migration domain. Does not apply on top of master, can you rebase and re-post ? Simo.

Re: [SSSD] [PATCH] use getaddrinfo to resolve IP address of KDC

2009-09-23 Thread Simo Sorce
On Wed, 2009-09-23 at 13:01 +0200, Sumit Bose wrote: Hi, with this patch to the Kerberos locator plugin it is possible to use either the name or the IP address of the KDC in the krb5KDCIP option. ack and pushed Simo. ___ sssd-devel mailing list

Re: [SSSD] [PATCH] Remove provider=files

2009-09-23 Thread Simo Sorce
On Wed, 2009-09-23 at 14:26 +0200, Jakub Hrozek wrote: On 09/23/2009 06:14 PM, Simo Sorce wrote: Does not apply on top of master, can you rebase and re-post ? Sorry, attached make[3]: *** No rule to make target `examples/sssdproxylocal', needed by `all-am'. Stop. make[2]: *** [all

[SSSD] fixing ping probe when suspending computers

2009-09-24 Thread Simo Sorce
When a laptop is suspended the clock may be jumping hours, with this patch now we explicitly count failure to pong back, so that at most we may loose one ping due to time jumping and not kill the children right away. Simo. 0001-Handle-suspend-cases.patch Description: application/mbox

Re: [SSSD] [PATCH] Temporarily disable automatic config file reread

2009-09-25 Thread Simo Sorce
On Thu, 2009-09-24 at 09:09 -0400, Stephen Gallagher wrote: The backends do not honor the reloadConfig SBUS message right now, so if an admin changes the sssd.conf file, it will update only the monitor, potentially leaving the SSSD as a whole in a bad state. This patch will simply comment

Re: [SSSD] [PATCH] Send debug messages to logfile

2009-09-25 Thread Simo Sorce
On Fri, 2009-09-25 at 12:35 +0200, Jakub Hrozek wrote: /* set up things like debug , signals, daemonization, etc... */ +debug_log_file = talloc_strdup(NULL, sssd_pam); +if (debug_log_file == NULL) return 2; + debug_log_file is a process constant, it's useless to allocate memory

Re: [SSSD] [PATCH] extend sssd-krb5 man page

2009-09-25 Thread Simo Sorce
On Fri, 2009-09-25 at 15:09 +0200, Sumit Bose wrote: Hi, this patch to the sssd-krb5 man page should clarify how the krb5 provider will find the right UPN. This hopefully fixes #204. Please fell free to correct any grammar or spelling mistakes. Ack but I think some native english

[SSSD] [PATCH] leave space to run fd events on long operations

2009-09-25 Thread Simo Sorce
This is actually a workaround as we don't have a way to create a low prio tevent queue that fires at a priority lower than file events. I'll work with upstream to fix this later on, meanwhile this patch will do. FYI: I haven't used timed_timeval_add() because it is buggy wrt microseconds in

[SSSD] [PATCH] tighten up file permissions just to be safe

2009-09-28 Thread Simo Sorce
just make double sure we do not leak info. Simo. 0001-Tighten-up-permission.patch Description: application/mbox ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] tighten up file permissions just to be safe

2009-09-28 Thread Simo Sorce
On Mon, 2009-09-28 at 08:22 -0400, Stephen Gallagher wrote: On 09/28/2009 08:10 AM, Simo Sorce wrote: just make double sure we do not leak info. Ack, although you may want to change sensible to sensitive in the commit comment before pushing. Pushed and fixed the comment. Simo

[SSSD] [PATCH] Add SASL/GSSAPI support to ldap id provider

2009-09-28 Thread Simo Sorce
This is an initial implementation of SASL support for the id provider. It works and IMO it is complete enough to be committed. Comments or acks welcome :-) Simo. 0001-Initial-implementation-of-sasl-bind-support.patch Description: application/mbox ___

Re: [SSSD] [PATCH] Update polish translation for 0.6.0

2009-09-30 Thread Simo Sorce
On Wed, 2009-09-30 at 11:15 -0400, Stephen Gallagher wrote: Yes, it is. I didn't want to repeat my previous mistake and push this without a second pair of eyes. On Sep 30, 2009, at 11:14 AM, Simo Sorce sso...@redhat.com wrote: On Sun, 2009-09-27 at 10:11 -0400, Stephen Gallagher wrote

Re: [SSSD] [PATCH] more documentation and test for sssd.conf

2009-10-05 Thread Simo Sorce
On Mon, 2009-10-05 at 09:17 +0200, Sumit Bose wrote: Hi, this patch adds a sentence about the strict requirements on sssd.conf to the man page and another test. ack Simo. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [PATCH] fix for 218

2009-10-05 Thread Simo Sorce
Should fix 218 (tested with non responding ldap server), and also fix other races and potential memleaks. Simo. 0001-Make-dp-requests-more-robust.patch Description: application/mbox ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] fix for 218

2009-10-05 Thread Simo Sorce
On Mon, 2009-10-05 at 15:58 -0400, Simo Sorce wrote: Consider the case where our backend crashes and is restarted by the monitor. If we have a busy system where one entry is being requested continuously, say once per second, and the backend that NSS is talking to segfaults for some reason

Re: [SSSD] [PATCH] Add handling of expired passwords

2009-10-05 Thread Simo Sorce
On Mon, 2009-10-05 at 17:10 +0200, Sumit Bose wrote: I asked Jenny for a third opinion and she vote for the second version, i.e. returning the wrong password error. ok pushed all 3 to master. Simo. ___ sssd-devel mailing list

Re: [SSSD] [PATCH] remove redundant talloc_free

2009-10-05 Thread Simo Sorce
On Mon, 2009-10-05 at 13:59 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/05/2009 10:56 AM, Sumit Bose wrote: Hi, this patch is a fix for bug #213. The reason for the bug is a double free during the call of the sdap timeout handler. Ack.

Re: [SSSD] [PATCH] Remove btreemap

2009-10-06 Thread Simo Sorce
On Tue, 2009-10-06 at 10:48 -0400, Stephen Gallagher wrote: We no longer use it anywhere in the code, having replaced it with the more efficient dhash. ack, you may want to add a small comment in some header like: /* R.I.P. btreemap 2008-2009 */ :-) Simo.

[SSSD] [PATCH] Remove mpg option

2009-10-06 Thread Simo Sorce
See subj and patch comment. Simo. 0001-Remove-magicPrivateGroups-option.patch Description: application/mbox ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] add description of chpass_provider option to sssd.conf man page

2009-10-08 Thread Simo Sorce
On Thu, 2009-10-08 at 10:00 +0200, Sumit Bose wrote: Hi, this patch adds an explanation of the chpass_provider option to the sssd.conf man page. ack and pushed Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel

Re: [SSSD] [PATCH] add syslog message similar to pam_unix

2009-10-08 Thread Simo Sorce
On Thu, 2009-10-08 at 10:41 +0200, Sumit Bose wrote: Hi, with this patch pam_sss sends a syslog message in a format used by pam_unix. The idea is to help tools to search log files. This patch should fix #222. Ack and pushed Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] add support for server side LDAP password policies

2009-10-08 Thread Simo Sorce
. As a next step I will add support for the client side evaluation of LDAP attributes indicating an expired password Ack and pushed. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https

Re: [SSSD] [PATCH] Remove mpg option

2009-10-09 Thread Simo Sorce
On Fri, 2009-10-09 at 21:54 +0200, Sumit Bose wrote: I think it make sense to have it as a DB attribute and I would prefer to keep the attribute around. ACK Pushed. Simo. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] use the correct kerberos context for each target

2009-10-09 Thread Simo Sorce
On Fri, 2009-10-09 at 15:55 +0200, Sumit Bose wrote: Hi, I found an error for the case where the kerberos provider is used as change password provider but not as auth provider. This patch sould fix it. Looks obviously right! Ack and pushed. Simo.

Re: [SSSD] [PATCH] use old password if available during password change

2009-10-09 Thread Simo Sorce
On Fri, 2009-10-09 at 21:02 +0200, Sumit Bose wrote: Hi, this one should fix #223. Because sshd runs as root the old password was not sent to sssd and changing the user password failed. Please review carefully. I guess the problem here is to understand what do current pam modules, when

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Simo Sorce
messages. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Simo Sorce
logic to open/close debug files in the children. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Package SSSDConfig API

2009-10-12 Thread Simo Sorce
On Mon, 2009-10-12 at 17:21 -0400, Stephen Gallagher wrote: ACK -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] add -Werror-implicit-function-declaration to default gcc flags

2009-10-13 Thread Simo Sorce
On Tue, 2009-10-13 at 16:53 +0200, Sumit Bose wrote: Hi, this patch adds -Werror-implicit-function-declaration to the gcc flags. This should help to identify missing library calls. ACK -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel

Re: [SSSD] [PATCH] add a replacement if ldap_control_create is missing

2009-10-13 Thread Simo Sorce
On Tue, 2009-10-13 at 16:56 +0200, Sumit Bose wrote: Hi, this patch should fix the build issue on RHEL5 where ldap_control_create is not available. I'm preparing a similar patch for Kerberos. Looks good to me. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCHES] Clean up some warnings

2009-10-15 Thread Simo Sorce
on. ack 0003: Remove two unused functions. These functions were used when reconnecting to the DP after losing the connection. Since there is no DP any longer, there's no reason to have these functions. ack Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-15 Thread Simo Sorce
On Thu, 2009-10-15 at 18:00 +0200, Sumit Bose wrote: ok, new version attached, thanks again. ack and pushed Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org

Re: [SSSD] [PATCH] set chpass_provider implicit if not set explicit

2009-10-15 Thread Simo Sorce
both Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCHES] Clean up some warnings

2009-10-15 Thread Simo Sorce
On Thu, 2009-10-15 at 14:14 -0400, Stephen Gallagher wrote: On 10/15/2009 01:24 PM, Simo Sorce wrote: On Thu, 2009-10-15 at 12:51 -0400, Stephen Gallagher wrote: Most of these warnings are seen only on older platforms like RHEL5. 0001: Clean up warnings in pysss.c Shouldn't we just

[SSSD] [PATCH] add IPA backend

2009-10-15 Thread Simo Sorce
This patcheset does the minimal necessary work to separate initialization from actual providers code for ldap and kerberos and uses this to introduce a first basic ipa provider skeleton that simply reuses the ldap and krb5 providers code. Simo. -- Simo Sorce * Red Hat, Inc * New York From

Re: [SSSD] Design question

2009-10-16 Thread Simo Sorce
synchronously or not? As above. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Fix segfault when using SSS tools with no local provider

2009-10-16 Thread Simo Sorce
are a termination function. Only the allocating function should free contexts. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Do not allow setting auth, access or chpass providers for LOCAL

2009-10-16 Thread Simo Sorce
if these values are specified (unless they are explicitly also set to 'local') ack Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

  1   2   3   4   5   6   7   8   9   10   >