[SSSD] [sssd PR#142][comment] Fix breakage caused by having the NSS responder socket-activated

2017-02-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/142 Title: #142: Fix breakage caused by having the NSS responder socket-activated fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/61/67/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#142][opened] Fix breakage caused by having the NSS responder socket-activated

2017-02-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/142 Author: fidencio Title: #142: Fix breakage caused by having the NSS responder socket-activated Action: opened PR body: """ **MONITOR: Don't return an error in case we fail to register a service** This patch is a pre-requisite f

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-01-31 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework fidencio commented: """ Looking at the patches I see this can be a completely new library instead of being part of SSSD. Knowing this it does make sense to have it as a su

[SSSD] [sssd PR#140][+Changes requested] gcc7 related fixes

2017-01-30 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/140 Title: #140: gcc7 related fixes Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#141][opened] PAM: Use cache_req_user_by_name_*()

2017-01-31 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req_user_by_name_*() Action: opened PR body: """ PAM responder has been already using a lot from cache_req and one of the missing parts (most likely the only one?) was that pam_check_user_se

[SSSD] [sssd PR#140][comment] gcc7 related fixes

2017-01-31 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/140 Title: #140: gcc7 related fixes fidencio commented: """ On Tue, Jan 31, 2017 at 2:25 PM, lslebodn <notificati...@github.com> wrote: > On (31/01/17 04:06), fidencio wrote: > >On Tue, Jan 31, 2017 at 10:29 AM, lslebodn <

[SSSD] [sssd PR#140][comment] gcc7 related fixes

2017-01-31 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/140 Title: #140: gcc7 related fixes fidencio commented: """ On Tue, Jan 31, 2017 at 10:29 AM, lslebodn <notificati...@github.com> wrote: > > On (30/01/17 23:52), fidencio wrote: > >fidencio requested changes on this pull

[SSSD] [sssd PR#140][+Accepted] gcc7 related fixes

2017-01-31 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/140 Title: #140: gcc7 related fixes Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#140][comment] gcc7 related fixes

2017-01-31 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/140 Title: #140: gcc7 related fixes fidencio commented: """ Okay, go for the patches! """ See the full comment at https://github.com/SSSD/sssd/pull/140#issuecomment-276422869 ___ s

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups fidencio commented: """ @pbrezina, commits are ready to be reviewed. @spbnick, you're not (totally) blocked anymore. """ See the full comment at https:/

[SSSD] [sssd PR#148][+Changes requested] SYSTEMD: Update journald drop-in file

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/148 Title: #148: SYSTEMD: Update journald drop-in file Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#141][edited] PAM: Use cache_req to perform initgroups lookups

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req to perform initgroups lookups Action: edited Changed field: title Original value: """ PAM: Use cache_req_user_by_name_*() """ _

[SSSD] [sssd PR#141][synchronized] PAM: Use cache_req_user_by_name_*()

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req_user_by_name_*() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/141/head:pr141 git checkout pr141 From

[SSSD] [sssd PR#141][edited] PAM: Use cache_req to perform initgroups lookups

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req to perform initgroups lookups Action: edited Changed field: body Original value: """ PAM responder has been already using a lot from cache_req and one of the missing parts (most like

[SSSD] [sssd PR#141][-Changes requested] PAM: Use cache_req to perform initgroups lookups

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#148][comment] SYSTEMD: Update journald drop-in file

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/148 Title: #148: SYSTEMD: Update journald drop-in file fidencio commented: """ Patch looks fine. May I ask why the type notify required interactive mode? Would make sense to also add the explanation to the commit message? Patch is good

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/61/72/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#145][comment] Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/145 Title: #145: Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case fidencio commented: """ ACK from me. But, please, wait till @pbrezina's reaction to your comment before pushin

[SSSD] [sssd PR#148][+Accepted] SYSTEMD: Update journald drop-in file

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/148 Title: #148: SYSTEMD: Update journald drop-in file Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#147][comment] IFP: Update ifp_iface_generated.c

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c fidencio commented: """ @pbrezina, may I ask you to open a ticket for this issue? It has to be fixed in the (near) future. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#147][comment] IFP: Update ifp_iface_generated.c

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c fidencio commented: """ Pavel, I didn't remove the code manually. I've noticed this file changed after building the project. """ See the full comment at https:/

[SSSD] [sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty fidencio commented: """ Just to clarify, do you think we should go for the dummy local provider instead of this patch series? Or that we

[SSSD] [sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty fidencio commented: """ You did not mention anything in your comment, @lslebodn. While @pbrezina said "go with these patches".

[SSSD] [sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty fidencio commented: """ You did not mention anything in your comment, @lslebodn. While @pbrezina said "go with these patches".

[SSSD] [sssd PR#146][+Changes requested] Avoid running two instances of the same service

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#144][+Accepted] SSSD does not start if using only the local provider and services line is empty

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-02-07 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service fidencio commented: """ @pbrezina: sticking with sbus code is not something that simple to do here and I'll explain you the reasons. The code flow is: - for each of

[SSSD] [sssd PR#151][comment] BUILD: Fix linking of test_sdap_initgr

2017-02-08 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/151 Title: #151: BUILD: Fix linking of test_sdap_initgr fidencio commented: """ Was the breakage caused by a specific commit? Could you specify that on the commit log? """ See the full comment at https://github.com/S

[SSSD] [sssd PR#143][synchronized] Explicitly add ordering dependency for the responders' sockets

2017-02-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/143 Author: fidencio Title: #143: Explicitly add ordering dependency for the responders' sockets Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/143/head:pr143 git checkout pr143

[SSSD] [sssd PR#143][edited] Explicitly add ordering dependency for the responders' sockets

2017-02-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/143 Author: fidencio Title: #143: Explicitly add ordering dependency for the responders' sockets Action: edited Changed field: body Original value: """ This patch set is intended to solve https://fedorahosted.org/sssd/ticket/3298 and m

[SSSD] [sssd PR#143][synchronized] Explicitly add ordering dependency for the responders' sockets

2017-02-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/143 Author: fidencio Title: #143: Explicitly add ordering dependency for the responders' sockets Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/143/head:pr143 git checkout pr143

[SSSD] [sssd PR#144][opened] SSSD does not start if using only the local provider and services line is empty

2017-02-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Author: fidencio Title: #144: SSSD does not start if using only the local provider and services line is empty Action: opened PR body: """ SSSD has to notify systemd whenever its startup is finished. Currently it has been done only

[SSSD] [sssd PR#144][synchronized] SSSD does not start if using only the local provider and services line is empty

2017-02-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Author: fidencio Title: #144: SSSD does not start if using only the local provider and services line is empty Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/144/head:pr144

[SSSD] [sssd PR#127][-Changes requested] ssh: use cache_req

2017-02-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#143][synchronized] Explicitly add ordering dependency for the responders' sockets

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/143 Author: fidencio Title: #143: Explicitly add ordering dependency for the responders' sockets Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/143/head:pr143 git checkout pr143

[SSSD] [sssd PR#147][opened] IFP: Update ifp_iface_generated.c

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/147 Author: fidencio Title: #147: IFP: Update ifp_iface_generated.c Action: opened PR body: """ These changes are leftovers from commit 78b4b7e. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/S

[SSSD] [sssd PR#143][edited] Explicitly add ordering dependency for the responders' sockets

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/143 Author: fidencio Title: #143: Explicitly add ordering dependency for the responders' sockets Action: edited Changed field: body Original value: """ While debugging the whole breakage reported by Stric I've noticed that the NSS

[SSSD] [sssd PR#143][synchronized] Explicitly add ordering dependency for the responders' sockets

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/143 Author: fidencio Title: #143: Explicitly add ordering dependency for the responders' sockets Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/143/head:pr143 git checkout pr143

[SSSD] [sssd PR#146][opened] Avoid running two instances of the same service

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Author: fidencio Title: #146: Avoid running two instances of the same service Action: opened PR body: """ Those two patches together are responsible for avoiding running two "instances" of the same service. The commit

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service fidencio commented: """ Ah, an important and obvious note ... of course I'm okay re-writing the second patch to use DBus instead of sd-bus, in case it's required by the revi

[SSSD] [sssd PR#144][+Accepted] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty fidencio commented: """ There were no changes requested during the review. Changing, again, this patchset to Accepted. """

[SSSD] [sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty fidencio commented: """ Patch set updated. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#144][-Changes requested] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an

[SSSD] [sssd PR#144][+Changes requested] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an

[SSSD] [sssd PR#144][-Accepted] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Title: #144: SSSD does not start if using only the local provider and services line is empty Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#144][synchronized] SSSD does not start if using only the local provider and services line is empty

2017-02-08 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/144 Author: fidencio Title: #144: SSSD does not start if using only the local provider and services line is empty Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/144/head:pr144

[SSSD] [sssd PR#142][closed] Fix breakage caused by having the NSS responder socket-activated

2017-02-04 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/142 Author: fidencio Title: #142: Fix breakage caused by having the NSS responder socket-activated Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/142/head:pr142 git checkout pr142

[SSSD] [sssd PR#142][+Rejected] Fix breakage caused by having the NSS responder socket-activated

2017-02-04 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/142 Title: #142: Fix breakage caused by having the NSS responder socket-activated Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#142][comment] Fix breakage caused by having the NSS responder socket-activated

2017-02-04 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/142 Title: #142: Fix breakage caused by having the NSS responder socket-activated fidencio commented: """ And I've been told that disabling the NSS Responder socket is a no-go. Closing the PR, so, closing the PR. """

[SSSD] [sssd PR#142][+Changes requested] Fix breakage caused by having the NSS responder socket-activated

2017-02-04 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/142 Title: #142: Fix breakage caused by having the NSS responder socket-activated Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#142][comment] Fix breakage caused by having the NSS responder socket-activated

2017-02-04 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/142 Title: #142: Fix breakage caused by having the NSS responder socket-activated fidencio commented: """ The second patch is not good to go. When a responder is started by the monitor and then the same responder is socket-activated or m

[SSSD] [sssd PR#145][comment] Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case

2017-02-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/145 Title: #145: Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case fidencio commented: """ @jhrozek, There's one thing I didn't understand quite well. In the case you gave

[SSSD] [sssd PR#143][opened] Explicitly add ordering dependency for the responders' sockets

2017-02-04 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/143 Author: fidencio Title: #143: Explicitly add ordering dependency for the responders' sockets Action: opened PR body: """ This patch set is intended to solve https://fedorahosted.org/sssd/ticket/3298 and more details can be fin

[SSSD] [sssd PR#141][+Changes requested] PAM: Use cache_req_user_by_name_*()

2017-01-31 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req_user_by_name_*() Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#141][comment] PAM: Use cache_req_user_by_name_*()

2017-01-31 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req_user_by_name_*() fidencio commented: """ pam_srv tests also need to be changed. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2017-01-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders fidencio commented: """ New patch set pushed addressing @lslebodn's review. @lslebodn, @pbrezina: I'm wondering whether we should drop this patch [0] and make it part of a d

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2017-01-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders fidencio commented: """ New patch set pushed addressing @lslebodn's review. @lslebodn, @pbrezina: I'm wondering whether we should drop this patch [0] and make it part of a d

[SSSD] [sssd PR#128][synchronized] Fix group renaming issue when "id_provider = ldap" is set

2017-01-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Author: fidencio Title: #128: Fix group renaming issue when "id_provider = ldap" is set Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/128/head:pr128 git checkout

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2017-01-23 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders fidencio commented: """ New patch set pushed! """ See the full comment at https://github.com/SSSD/sssd/pull/94#issuecomment-274498903

[SSSD] [sssd PR#132][comment] Add "Wants=" to sssd unit

2017-01-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/132 Title: #132: Add "Wants=" to sssd unit fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/61/27/summary.html """ See the full comment at https://github.com/S

[SSSD] [sssd PR#131][+Accepted] MONITOR: Fix warning with undefined macro HAVE_SYSTEMD

2017-01-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/131 Title: #131: MONITOR: Fix warning with undefined macro HAVE_SYSTEMD Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#131][comment] MONITOR: Fix warning with undefined macro HAVE_SYSTEMD

2017-01-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/131 Title: #131: MONITOR: Fix warning with undefined macro HAVE_SYSTEMD fidencio commented: """ Obvious ACK! Sorry I missed it :-\ """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#132][comment] Add "Wants=" to sssd unit and avoid PAC responder to be always running

2017-01-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/132 Title: #132: Add "Wants=" to sssd unit and avoid PAC responder to be always running fidencio commented: """ @lslebodn: Okay, you don't agree with the second patch and I'm totally fine about that (in case other developers don

[SSSD] [sssd PR#132][synchronized] Add "Wants=" to sssd unit and avoid PAC responder to be always running

2017-01-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/132 Author: fidencio Title: #132: Add "Wants=" to sssd unit and avoid PAC responder to be always running Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/132/head

[SSSD] [sssd PR#132][synchronized] Add "Wants=" to sssd unit and avoid PAC responder to be always running

2017-01-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/132 Author: fidencio Title: #132: Add "Wants=" to sssd unit and avoid PAC responder to be always running Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/132/head

[SSSD] [sssd PR#132][edited] Add "Wants=" to sssd unit

2017-01-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/132 Author: fidencio Title: #132: Add "Wants=" to sssd unit Action: edited Changed field: title Original value: """ Add "Wants=" to sssd unit and avoid PAC responder to be always running """

[SSSD] [sssd PR#132][opened] Add "Wants=" to sssd unit and avoid PAC responder to be always running

2017-01-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/132 Author: fidencio Title: #132: Add "Wants=" to sssd unit and avoid PAC responder to be always running Action: opened PR body: """ The first patch changes the current logic of having the services' sockets disabled by de

[SSSD] [sssd PR#132][comment] Add "Wants=" to sssd unit

2017-01-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/132 Title: #132: Add "Wants=" to sssd unit fidencio commented: """ The patch changes the current logic of having the services' sockets disabled by default as it adds a "Wants=" to the sssd unit file, making all the servi

[SSSD] [sssd PR#132][-Changes requested] Add "Wants=" to sssd unit

2017-01-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/132 Title: #132: Add "Wants=" to sssd unit Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#132][synchronized] Add "Wants=" to sssd unit

2017-01-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/132 Author: fidencio Title: #132: Add "Wants=" to sssd unit Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/132/head:pr132 git checkout

[SSSD] [sssd PR#133][comment] sbus: use sss_ptr_hash for hash tables

2017-01-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables fidencio commented: """ "This patch reuses sss_ptr_hash module introduced in NSS patches in sbus code", as in the description of the PR would be more than enough. "&quo

[SSSD] [sssd PR#133][comment] sbus: use sss_ptr_hash for hash tables

2017-01-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables fidencio commented: """ Acked! Thanks for the changes! """ See the full comment at https://github.com/SSSD/sssd/pull/133#issuecomment-275381727 __

[SSSD] [sssd PR#135][comment] BUILD: Fix linking of test_wbc_calls

2017-01-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/135 Title: #135: BUILD: Fix linking of test_wbc_calls fidencio commented: """ On Thu, Jan 26, 2017 at 2:18 PM, lslebodn <notificati...@github.com> wrote: > On (26/01/17 01:58), fidencio wrote: > >Oh yeah, my bad. On 1

[SSSD] [sssd PR#133][comment] sbus: use sss_ptr_hash for hash tables

2017-01-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables fidencio commented: """ Tests have passed but our CI seems half broken. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#133][+Accepted] sbus: use sss_ptr_hash for hash tables

2017-01-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#133][comment] sbus: use sss_ptr_hash for hash tables

2017-01-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables fidencio commented: """ All the patches look sane. I, personally, would like to see some message in the commit log. If you don't think it's needed, feel free to just ignore this comme

[SSSD] [sssd PR#133][comment] sbus: use sss_ptr_hash for hash tables

2017-01-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/133 Title: #133: sbus: use sss_ptr_hash for hash tables fidencio commented: """ All the patches look sane. I, personally, would like to see some message in the commit log. If you don't think it's needed, feel free to just ignore this comme

[SSSD] [sssd PR#126][+Accepted] ldap_child: Fix use after free

2017-01-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/126 Title: #126: ldap_child: Fix use after free Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#135][comment] BUILD: Fix linking of test_wbc_calls

2017-01-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/135 Title: #135: BUILD: Fix linking of test_wbc_calls fidencio commented: """ @lslebodn: Although the fix seems quite simple I have to admit I didn't understand it. CLIENT_LIBS is LTLIBINTL, right? How does it pull the missing symbol? &q

[SSSD] [sssd PR#126][comment] ldap_child: Fix use after free

2017-01-25 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/126 Title: #126: ldap_child: Fix use after free fidencio commented: """ Patch looks good. Just a few nitpicks ... Commit short log: - "ldap_child" -> "LDAP_CHILD" Commit message: - "tb parrent&qu

[SSSD] [sssd PR#135][comment] BUILD: Fix linking of test_wbc_calls

2017-01-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/135 Title: #135: BUILD: Fix linking of test_wbc_calls fidencio commented: """ Oh yeah, my bad. On 1.14 the Makefile also contains: ``` if HAVE_PTHREAD CLIENT_LIBS += -lpthread endif ``` Just a small nitpick in the commit message: - ΅in

[SSSD] [sssd PR#135][+Accepted] BUILD: Fix linking of test_wbc_calls

2017-01-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/135 Title: #135: BUILD: Fix linking of test_wbc_calls Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#154][+Changes requested] Confront caches first

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/154 Title: #154: Confront caches first Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#141][-Changes requested] PAM: Use cache_req to perform initgroups lookups

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#141][synchronized] PAM: Use cache_req to perform initgroups lookups

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req to perform initgroups lookups Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/141/head:pr141 git checkout pr141 From

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes fidencio commented: """ @justin-stephenson: Thanks for the patches and explanation. I was able to reproduce the behavior you mentioned and, IMO, the patches look fine. I've just submitted them to

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/63/03/summary.html """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#66][+Accepted] Minor Dynamic DNS fixes

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#70][comment] check_duplicate: check name member before using it

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it fidencio commented: """ Can we have this one pushed by @sumit-bose and @jhrozek review? """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#141][synchronized] PAM: Use cache_req to perform initgroups lookups

2017-02-23 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req to perform initgroups lookups Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/141/head:pr141 git checkout pr141 From

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-23 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups fidencio commented: """ Big thanks to @sumit-bose who helped me with the tests not passing due to the rebase and for pointing out that a whole piece of code that could a

[SSSD] [sssd PR#141][-Changes requested] PAM: Use cache_req to perform initgroups lookups

2017-02-23 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-23 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/63/43/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#168][+Accepted] DOC: Deprecate README, add README.md

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md fidencio commented: """ ack! """ See the full comment at https://github.com/SSSD/sssd/pull/168#issuecomment-282236962 ___ s

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md fidencio commented: """ This is how the readme looks with the patch: https://github.com/jhrozek/sssd/tree/readme """ See the full comment at https://github.com/S

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ So, as far as I remember, the conclusion about this patch is that we should also have a really loud debug message saying that t

[SSSD] [sssd PR#128][+Changes requested] Fix group renaming issue when "id_provider = ldap" is set

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#153][+Accepted] sss_cache: User/groups invalidation in domain cache

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

  1   2   3   4   5   6   7   8   9   10   >