[SSSD] [sssd PR#5168][opened] Minor fix in ad_access.c out of memory check

2020-05-19 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/5168 Author: rdratlos Title: #5168: Minor fix in ad_access.c out of memory check Action: opened PR body: """ Wrong tevent request used for out-of memory check. Fixes https://github.com/SSSD/sssd/issues/5167 Signed-off-by: Thomas Reim &

[SSSD] [sssd PR#5168][synchronized] Minor fix in ad_access.c out of memory check

2020-05-19 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/5168 Author: rdratlos Title: #5168: Minor fix in ad_access.c out of memory check Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5168/head:pr5168 git checkout pr5168 From

[SSSD] [sssd PR#5168][comment] Minor fix in ad_access.c out of memory check

2020-05-19 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/5168 Title: #5168: Minor fix in ad_access.c out of memory check rdratlos commented: """ Found this during rework of AD GPO code. As ad_access.c is not affected by the changes, I split this into a separate PR. """

[SSSD] [sssd PR#412][comment] Gpo contributed patches

2017-11-19 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/412 Title: #412: Gpo contributed patches rdratlos commented: """ @mzidek-rh Sorry for my late reply. Thank you very much for reviewing the proposed patches and updating them. I have tested them on my systems and they still work perfe

[SSSD] [sssd PR#412][comment] Gpo contributed patches

2017-11-20 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/412 Title: #412: Gpo contributed patches rdratlos commented: """ Following an e-mail exchange with Lukas I have moved the patches, that have been updated by Michal here, back to Pagure and fixed the minor issues. See: https://pagure.io

[SSSD] [sssd PR#412][comment] Gpo contributed patches

2017-11-20 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/412 Title: #412: Gpo contributed patches rdratlos commented: """ Following an e-mail exchange with Lukas I have fetched the patches, that have been updated by Michal here, back to Pagure and fixed the minor issues. See: https://pagure.io

[SSSD] [sssd PR#552][opened] GPO: Store security CSE settings of all applicable GPOs

2018-04-14 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Author: rdratlos Title: #552: GPO: Store security CSE settings of all applicable GPOs Action: opened PR body: """ When two or more GPO rules were defined on the server and one of them contained no SIDs (no users or groups were specif

[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-14 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs rdratlos commented: """ This PR provides an alternative solution to #551 to fix [#3680](https://pagure.io/SSSD/sssd/issue/3680). #551 falls short of fixing the root

[SSSD] [sssd PR#551][comment] GPO: Fix bug with empty GPO rules

2018-04-14 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/551 Title: #551: GPO: Fix bug with empty GPO rules rdratlos commented: """ I believe this PR only fixes symptoms of the real root cause for [#3680](https://pagure.io/SSSD/sssd/issue/3680). Please check #552 which proposes a more sophist

[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-14 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs rdratlos commented: """ This PR provides an alternative solution to #551 to fix [#3680](https://pagure.io/SSSD/sssd/issue/3680). #551 falls short of fixing the root

[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-14 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs rdratlos commented: """ This PR provides an alternative solution to #551 to fix [#3680](https://pagure.io/SSSD/sssd/issue/3680). #551 falls short of fixing the root

[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-14 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs rdratlos commented: """ This PR provides an alternative solution to #551 to fix [#3680](https://pagure.io/SSSD/sssd/issue/3680). #551 falls short of fixing the root

[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-14 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs rdratlos commented: """ This PR provides an alternative solution to #551 to fix [#3680](https://pagure.io/SSSD/sssd/issue/3680). #551 falls short of fixing the root

[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-14 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs rdratlos commented: """ This PR provides an alternative solution to #551 to fix [#3680](https://pagure.io/SSSD/sssd/issue/3680). #551 falls short of fixing the root

[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-14 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs rdratlos commented: """ This PR provides an alternative solution to #551 to fix [#3680](https://pagure.io/SSSD/sssd/issue/3680). #551 falls short of fixing the root

[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-16 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs rdratlos commented: """ @fidencio Sorry, but I've never performed SSSD team's unit and integration tests. I've just built a fixed SSSD package base

[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-16 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs rdratlos commented: """ @fidencio Sorry, but I've never performed SSSD team's unit and integration tests. I've just built a fixed SSSD package base

[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-16 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs rdratlos commented: """ @fidencio If a run make check which seems to be performed for make-tests I get following error: > gcc: error: ./.libs/libsss_nss_idmap_tes

[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-17 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs rdratlos commented: """ @mzidek-rh Thank you very much for your review and the comments. I analysed the security CSE behaviour mid of last year and just have a few

[SSSD] [sssd PR#551][comment] GPO: Fix bug with empty GPO rules

2018-04-17 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/551 Title: #551: GPO: Fix bug with empty GPO rules rdratlos commented: """ Hi Michal,, of course your PR should continue to be reviewed. My intention was just to present an alternative approach based on some analysis half a year ago that g