[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ * master: 54c64aad71e6792edb7cf99988d9a7f4bc2b0c61 """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-250676156 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder fidencio commented: """ I'm using curl 7.47 on F24 and I have no problem using a full URL as described in the examples. So, I'm giving an ACK to the patch. In case of any issue (which doesn't seem to be the case), it can be fixed later on. @jhrozek, please, feel free to push this patch. """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-250603929 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder fidencio commented: """ I'm using libcurl 7.47 on F24 and I have no problem using a full URL as described in the examples. So, I'm giving an ACK to the patch. In case of any issue (which doesn't seem to be the case), it can be fixed later on. @jhrozek, please, feel free to push this patch. """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-250603929 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ On Wed, Sep 28, 2016 at 12:55:34AM -0700, Jakub Hrozek wrote: > On Mon, Sep 26, 2016 at 01:29:12PM -0700, lslebodn wrote: > > lslebodn commented on this pull request. > > > > > > > > > +The secret URI must begin with > > > /secrets/. > > + > > + > > + > > +Listing secrets > > + > > + > > +To list the available secrets, send a HTTP GET > > request > > +with a trailing slash appended to the container > > path. > > + > > + > > +Example: > > + > > +curl -H "Content-Type: application/json" \ > > + --unix-socket /var/run/secrets.socket \ > > + -XGET http://localhost/secrets/ > > > > IIRC curl had support for HTTP request via unix sockets even in older > > versions > > But cURL 7.50+ requires a valid URL to be provided, including a hostname. > > older versions could use `-XGET http:/secrets/`. > > > > we needn't mention that in man page but we can mention requirement for > > "cURL 7.50+" > > But since we include the URL in the examples, that should work with both > old and new versions, right? Or does the old curl version not work with a full URL? """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-250099261 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ On Mon, Sep 26, 2016 at 01:29:12PM -0700, lslebodn wrote: > lslebodn commented on this pull request. > > > > > +The secret URI must begin with /secrets/. > + > + > + > +Listing secrets > + > + > +To list the available secrets, send a HTTP GET > request > +with a trailing slash appended to the container path. > + > + > +Example: > + > +curl -H "Content-Type: application/json" \ > + --unix-socket /var/run/secrets.socket \ > + -XGET http://localhost/secrets/ > > IIRC curl had support for HTTP request via unix sockets even in older versions > But cURL 7.50+ requires a valid URL to be provided, including a hostname. > older versions could use `-XGET http:/secrets/`. > > we needn't mention that in man page but we can mention requirement for "cURL > 7.50+" But since we include the URL in the examples, that should work with both old and new versions, right? """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-250097536 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ Thank you for the review. I accepted both your suggestions. I hope we can merge the patch once the CI finishes. """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-249521520 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ Also removing the Accepted label since the content changed. """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-249138994 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ I wonder if @justin-stephenson would have some time to check the English? """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-249138735 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ I added a new paragraph down at the bottom of the page that adds an example of a proxy provider. """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-249138582 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ On Fri, Sep 16, 2016 at 05:03:04AM -0700, Christian Heimes wrote: > * Can SSSD's secret responder contact Custodia over Unix socket? I'd rather > have UDS as the default example configuration than TCP/IP. Looking at the code, so far it doesn't seem to be the case. For one, there is code that checks for either http:// or https:// in the schema and the connection itself only connects over SOCK_STREAM. > * We are considering to limit allowed characters in paths as Custodia can't > handle all quoted characters correctly. > https://github.com/latchset/custodia/issues/60#issuecomment-247580469 OK, noted, but should we mention this in the sssd manpage? """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-247585198 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder tiran commented: """ * Can SSSD's secret responder contact Custodia over Unix socket? I'd rather have UDS as the default example configuration than TCP/IP. * We are considering to limit allowed characters in paths as Custodia can't handle all quoted characters correctly. https://github.com/latchset/custodia/issues/60#issuecomment-247580469 """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-247583785 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ it would be nice if @simo5 or @tiran could skim over the manpage """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-247570447 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder lslebodn commented: """ Do we need review also from native speaker for initial version? LS """ See the full comment at https://github.com/SSSD/sssd/pull/24#issuecomment-247568557 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
