URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
jhrozek commented:
"""
On Tue, Sep 20, 2016 at 08:40:08AM -0700, lslebodn wrote:
> On (20/09/16 05:02), Jakub Hrozek wrote:
> >On Tue, Sep 20, 2016 at 04:45:53AM -0700,
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
lslebodn commented:
"""
On (20/09/16 05:02), Jakub Hrozek wrote:
>On Tue, Sep 20, 2016 at 04:45:53AM -0700, lslebodn wrote:
>> On (20/09/16 04:09), Jakub Hrozek wrote:
>> >I
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
celestian commented:
"""
So, code LGTM, thanks for Lukas's watchful eye.
I pushed patch to CI.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
jhrozek commented:
"""
On Tue, Sep 20, 2016 at 04:45:53AM -0700, lslebodn wrote:
> On (20/09/16 04:09), Jakub Hrozek wrote:
> >I was getting random failures where the socket
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
lslebodn commented:
"""
On (20/09/16 04:09), Jakub Hrozek wrote:
>I was getting random failures where the socket was not yet ready without
>the sleep, like this:
>
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
jhrozek commented:
"""
On Mon, Sep 19, 2016 at 06:54:12AM -0700, lslebodn wrote:
> lslebodn commented on this pull request.
>
>
>
> > +os.chmod(config.CONF_PATH,
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
celestian commented:
"""
ACK
"""
See the full comment at
https://github.com/SSSD/sssd/pull/25#issuecomment-247988840
___
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
lslebodn commented:
"""
On (19/09/16 04:39), Jakub Hrozek wrote:
>On Mon, Sep 19, 2016 at 04:21:08AM -0700, celestian wrote:
>> Well,
>>
>> LGTM. In my opinion we do not
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
celestian commented:
"""
Jakub,
IMHO we have description and the link to ticket. If it is not so strict then I
am OK with it.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
jhrozek commented:
"""
On Mon, Sep 19, 2016 at 04:21:08AM -0700, celestian wrote:
> Well,
>
> LGTM. In my opinion we do not have to run CI again for removing of comment.
>
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
celestian commented:
"""
Well,
LGTM. In my opinion we do not have to run CI again for removing of comment.
One last point. Jakub, please, could you fix the commit message?
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
jhrozek commented:
"""
On Mon, Sep 19, 2016 at 03:19:51AM -0700, lslebodn wrote:
> On (16/09/16 06:56), Jakub Hrozek wrote:
> >jhrozek commented on this pull request.
> >>
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
lslebodn commented:
"""
On (16/09/16 06:56), Jakub Hrozek wrote:
>jhrozek commented on this pull request.
>> +#
>+
>+import socket
>+import requests
>+
>+from
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
celestian commented:
"""
CI passed:
http://sssd-ci.duckdns.org/logs/job/53/55/summary.html
ACK
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
celestian commented:
"""
LGTM,
I will push it to our CI.
And how Lukas mentioned in mail, it could be nice to fix commit message before
pushing.
"""
See the full comment
URL: https://github.com/SSSD/sssd/pull/25
Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets
jhrozek commented:
"""
I also added a test for one of Fabiano's patches in the last patch iteration
"""
See the full comment at
16 matches
Mail list logo