[SSSD] [sssd PR#346][comment] intg: Disable add_remove tests

2017-08-14 Thread lslebodn 
  URL: https://github.com/SSSD/sssd/pull/346
Title: #346: intg: Disable add_remove tests

lslebodn commented:
"""
master:
* a24e735d33b788fec32acba70f30709eff44ebdf
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/346#issuecomment-322160626
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#346][comment] intg: Disable add_remove tests

2017-08-11 Thread spbnick 
  URL: https://github.com/SSSD/sssd/pull/346
Title: #346: intg: Disable add_remove tests

spbnick commented:
"""
Sure, go ahead and push it. My comment is just my preference. I can go on to 
explaining the reasoning, but I wouldn't want to force it on you and delay your 
work.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/346#issuecomment-321742523
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#346][comment] intg: Disable add_remove tests

2017-08-11 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/346
Title: #346: intg: Disable add_remove tests

fidencio commented:
"""
As per @lslebodn's explanation and per the last "stress tests" which those 
patches have been submitted to, I'd like to have them pushed ASAP and then we 
can unblock other patches that are also pending.

You have an ACK from me, but feel free to ping another developer if you feel 
like you need a second opinion on this.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/346#issuecomment-321737610
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#346][comment] intg: Disable add_remove tests

2017-08-10 Thread lslebodn 
  URL: https://github.com/SSSD/sssd/pull/346
Title: #346: intg: Disable add_remove tests

lslebodn commented:
"""
>I would prefer to have a comment in front of each disabled test saying it is 
>disabled and briefly explaining why (including a reference to the issue 
>perhaps).

Reference to issue is already in commit message and it also contains 
explanation 

Moreover, it is a temporary workaround for unblocking pushing other patches.
Ticket https://pagure.io/SSSD/sssd/issue/3463 is a blocker for 1.15.4 release. 
So this patch will have to be reverted before next release. Adding comment to 
code will not  change situation and therefore such duplication is unnecessary 
for temporary workaround.
Adding a comments directly is a redundant because description in commit
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/346#issuecomment-321728973
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#346][comment] intg: Disable add_remove tests

2017-08-10 Thread spbnick 
  URL: https://github.com/SSSD/sssd/pull/346
Title: #346: intg: Disable add_remove tests

spbnick commented:
"""
This is a good move, and looks fine to me, except I would prefer to have a 
comment in front of each disabled test saying it is disabled and briefly 
explaining why (including a reference to the issue perhaps).
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/346#issuecomment-321588154
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org