[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ master: * 0df79781d78973e5462dbef1e89d8fd6001da05c * e64696e1fab85c42aaeda65ddf49ee1b7e3f07e1 * 52ae4eeba9c97c0254a2025ec3b5ffe90588b775 * 841bcb5e1f66bb9c41e1884a2ab1dae654def13e * 3b0356f3bd82e78dffd38ebdc206b555d00dde2f """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-368085218 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ >I'm sorry I didn't see there was already ack by pbrezina and then the patches >only had a trivial change. No need to apologize. We are all busy and sometimes happen there is a PR pending review for some time. I am quite patience. And the most important is that we finally increased code coverage in upstream and extended possibilities in cwrap integration tests. >Nonetheless, the patches look good and I've only started CI to see if all >distros pass before pushing. Thank you. """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-367961830 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test jhrozek commented: """ CI: http://vm-031.$ABC/logs/job/85/06/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-367782486 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-365858862 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ On (07/12/17 20:14), Jakub Hrozek wrote: >I wanted to write tests GetUserGroups when I was working on the automatic >private groups feature. But then during manual testing I found >https://pagure.io/SSSD/sssd/issue/3543 which means that the groups are not >returned the same for GetUserGroups as they are for "id" even now for >subdomains (which already used auto private groups internally), so if the >feature didn't work until now in the first place, I didn't think it was too >urgent to test all the cases with the new addition. > Thank you for explanation >Would you like me to work on this review if nobody else picked up the patches >so far? > It is not important who will review it. LS """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-350281761 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test jhrozek commented: """ I wanted to write tests GetUserGroups when I was working on the automatic private groups feature. But then during manual testing I found https://pagure.io/SSSD/sssd/issue/3543 which means that the groups are not returned the same for GetUserGroups as they are for "id" even now for subdomains (which already used auto private groups internally), so if the feature didn't work until now in the first place, I didn't think it was too urgent to test all the cases with the new addition. Would you like me to work on this review if nobody else picked up the patches so far? """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-350081513 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ >> Can we upstream this, please? I'd like to extend the tests I have for the >> auto private groups with tests for the IFP responder as well.. > > I do not understand this question. @jhrozek could you elaborate? """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-350078444 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ > Can we upstream this, please? I'd like to extend the tests I have for the > auto private groups with tests for the IFP responder as well.. I do not understand this question. Anyway, bump after 6 weeks. """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-347534218 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test jhrozek commented: """ Can we upstream this, please? I'd like to extend the tests I have for the auto private groups with tests for the IFP responder as well.. """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-335034430 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ Test for ping introspection was added which was changed in different PR #393 """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-331460575 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test pbrezina commented: """ I opened https://github.com/SSSD/sssd/pull/393 to change ping to codegen arguments parsing. """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-331389408 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-331386571 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test pbrezina commented: """ ```xml ``` Parameters for ping method are parsed manually, therefore it is not shown in the introspection. But it can be parsed by the codegen without any troubles so it is just a historic relic. """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-331379883 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#391][comment] Use dbus-daemon in cwrap enviroment for test
URL: https://github.com/SSSD/sssd/pull/391 Title: #391: Use dbus-daemon in cwrap enviroment for test lslebodn commented: """ @pbrezina is there a reason why ping accept string as input even though introspection says something else? ``` sh# dbus-send --system --type=method_call --print-reply --dest=org.freedesktop.sssd.infopipe /org/freedesktop/sssd/infopipe org.freedesktop.DBus.Introspectable.Introspect | grep -C 2 Ping ``` """ See the full comment at https://github.com/SSSD/sssd/pull/391#issuecomment-330958987 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
