[SSSD] [sssd PR#4][comment] Added small tweaks to enable SSSD to be compiled with the musl libc

2017-08-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/4 Title: #4: Added small tweaks to enable SSSD to be compiled with the musl libc lslebodn commented: """ Patches does not apply to git master and it does not look like @lejonet would like to continue in this PR https://github.com/SSSD/sssd/pull/4#issuecomm

[SSSD] [sssd PR#4][comment] Added small tweaks to enable SSSD to be compiled with the musl libc

2017-08-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/4 Title: #4: Added small tweaks to enable SSSD to be compiled with the musl libc jhrozek commented: """ If you have time to hack on this issue, of course feel free to. """ See the full comment at https://github.com/SSSD/sssd/pull/4#issuecomment-320213609

[SSSD] [sssd PR#4][comment] Added small tweaks to enable SSSD to be compiled with the musl libc

2017-08-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/4 Title: #4: Added small tweaks to enable SSSD to be compiled with the musl libc lslebodn commented: """ I can reproduce compilation failure with musl on gentoo. if @lejonet does not want to the patch with requested changes then I can create another PR ""

[SSSD] [sssd PR#4][comment] Added small tweaks to enable SSSD to be compiled with the musl libc

2017-08-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/4 Title: #4: Added small tweaks to enable SSSD to be compiled with the musl libc lslebodn commented: """ I can reproduce compilation failure with musl on gentoo. if @lejonet does not want to update changes in patch then I can create another PR """ See th

[SSSD] [sssd PR#4][comment] Added small tweaks to enable SSSD to be compiled with the musl libc

2017-08-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/4 Title: #4: Added small tweaks to enable SSSD to be compiled with the musl libc jhrozek commented: """ I would prefer to close this with the 'deferred keyword'. The only question I have is whether we should file a ticket into the 'patches welcome' milesto

[SSSD] [sssd PR#4][comment] Added small tweaks to enable SSSD to be compiled with the musl libc

2017-08-03 Thread lejonet
URL: https://github.com/SSSD/sssd/pull/4 Title: #4: Added small tweaks to enable SSSD to be compiled with the musl libc lejonet commented: """ I don't know, due to other issues with musl for what I was trying to do, I dropped my efforts with musl a long while back, so I don't have any system to

[SSSD] [sssd PR#4][comment] Added small tweaks to enable SSSD to be compiled with the musl libc

2017-07-27 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/4 Title: #4: Added small tweaks to enable SSSD to be compiled with the musl libc fidencio commented: """ @lejonet, @lslebodn, does this PR still make sense? """ See the full comment at https://github.com/SSSD/sssd/pull/4#issuecomment-318327689 ___

[SSSD] [sssd PR#4][comment] Added small tweaks to enable SSSD to be compiled with the musl libc

2016-11-25 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/4 Title: #4: Added small tweaks to enable SSSD to be compiled with the musl libc lslebodn commented: """ @lejonet and BTW I would like to apologise for long gap between reviews """ See the full comment at https://github.com/SSSD/sssd/pull/4#issuecomment-

[SSSD] [sssd PR#4][comment] Added small tweaks to enable SSSD to be compiled with the musl libc

2016-11-25 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/4 Title: #4: Added small tweaks to enable SSSD to be compiled with the musl libc lslebodn commented: """ I checked header files on FreeBSD and gid_t is defined in `sys/types.h` as well. Could you check header sys/types.h in musl libc? BTW `ALLPERMS` define