[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 jhrozek commented: """ Since I don't think this PR will get any updates now, we should just close it. If anyone (probably a user or a maintainer of a stable distribution) will like to see this patch backported, please do submit a PR. """ See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-390784545 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/HSEZBZEOQ7NLFO5KQFWCHOJ6LSIDCGNC/
[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 jhrozek commented: """ I haven't looked at the code at all, but judging by the previous message, the state of this PR should be "Changes Requested". """ See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-367666723 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 sumit-bose commented: """ Hi Lukas, I think you backported the changes to the wrong function. In 1.13 in ipa_get_ad_override_connect_done() be_acct_req_to_override_filter() is called to create the filter for the override search and not get_be_acct_req_for_xyz(). be_acct_req_to_override_filter() was renamed to dp_id_data_to_override_filter() by 3d29430867cf92b2d71afa95abb679711231117c that's why the patch for master (c2dec0dc740ba426f26563563c0aea3a38f3c3c1) adds the sanitation to this function. HTH bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-359458111 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 fidencio commented: """ > Maybe, I do not know whether you used the same of IPA server for testing > master and 1.13 but version of ipa-client should not have anything with this > bug. Yep, I've used the very same ipa server. > Does it behave the same with sssd-1.15/-1.16? And no, I couldn't notice the very same behave on 1.15/1.16. As this PR does not have high prio (or higher prio) than a few other work that I have on my back, I'll visit it back in a few days/week. As said before, anyone else can review this and mainly **test** this patch/behaviour in order to not leave it blocked in case a few days/weeks is not acceptable. """ See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-348883656 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 lslebodn commented: """ On (29/11/17 12:06), fidencio wrote: >One thing that I have notice (with or without the patch) is that `getent group >f...@ad.ff`, f...@ad.ff being an AD group from the trusted domain doesn't >return me any results. I only can get some results after an `id >any_user_who_s_part_of_foo_ad_ff_group`. > >I guess this is not expected at all, or am I mistaken? > Does it behave the same with sssd-1.15/-1.16? LS """ See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-348520126 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 lslebodn commented: """ On (29/11/17 12:03), fidencio wrote: >I've tried to reproduce the very same issue using sssd-1.13.3-57.el6_9 and I >simply can't. May it be related to the ipa version? > Maybe, I do not know whether you used the same of IPA server for testing master and 1.13 but version of ipa-client should not have anything with this bug. """ See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-348519835 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 fidencio commented: """ One thing that I have notice (with or without the patch) is that `getent group f...@ad.ff`, f...@ad.ff being an AD group from the trusted domain doesn't return me any results. I only can get some results after an `id any_user_who_s_part_of_foo_ad_ff_group`. I guess this is not expected at all, or am I mistaken? """ See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-347841071 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 fidencio commented: """ I've tried to reproduce the very same issue using sssd-1.13.3-57.el6_9 and I simply can't. May it be related to the ipa version? I'll give it another try using an el7 system with 1.13 branch installed. """ See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-347840457 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 fidencio commented: """ Just for the record, I've talked to @lslebodn on IRC and I'll get to this PR later Today. """ See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-347504623 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 lslebodn commented: """ Bump after 6 weeks. """ See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-347490896 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
