[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format jhrozek commented: """ btw which platforms use 64bit id_t? """ See the full comment at https://github.com/SSSD/sssd/pull/448#issuecomment-344953635

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format lslebodn commented: """ master: * d25646c64a7117a6551468256efa82d01647751e """ See the full comment at https://github.com/SSSD/sssd/pull/448#issuecomment-344886324

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format fidencio commented: """ @lslebodn, hmm. makes sense, thanks for the explanation. Seems that @amitkumar50 new PR is okay with your suggestion, but I'd like to hear it from you. """

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-16 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format amitkumar50 commented: """ @fidencio Thanks I read inttypes.h convention here goes PRIuN. Done. """ See the full comment at

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-16 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format lslebodn commented: """ >This is not fixed. Although it seems nitpicking to me as gid_t, uid_t and id_t >as all of those ended up being defined as u32 type anyways ... all of those

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-15 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format fidencio commented: """ @amitkumar50, you made the changes addressing only half of @lslebodn's comments. @lslebodn said: "This one is for UID. So it should be SPRIuid ..." Okay, it's

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-15 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format amitkumar50 commented: """ Are some changes required? Label is 'Changed Requested' """ See the full comment at https://github.com/SSSD/sssd/pull/448#issuecomment-344817280

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format fidencio commented: """ Ack! I'll fire an internal CI run just for the sake of the process and add the "Accepted" label when I get the result. Thanks for the contribution,

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format fidencio commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/448#issuecomment-344156272 ___ sssd-devel

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-13 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/448#issuecomment-344130857

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-13 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/448#issuecomment-344130858