[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req jhrozek commented: """ Removing changes requested since a new patch had arrived """ See the full comment at https://github.com/SSSD/sssd/pull/449#issuecomment-347890037 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req amitkumar50 commented: """ @jhrozek Thanks for comments. So Shall I not work on this patch as of now? Or instead of EOK define `ERR_UID_OUTSIDE_RANGE` in `./src/util/util_errors.h` and return. """ See the full comment at https://github.com/SSSD/sssd/pull/449#issuecomment-344902647 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req jhrozek commented: """ @pbrezina I'm still running some tests with my patches, but in general they are ready and published in my gc_uid branch. btw see the downtream report - we were already asked for a backport to sssd-1-14, so while in general I'm OK with basing the patches to master atop mine (less work for me I guess :-)) we will also need patches for sssd-1-14. """ See the full comment at https://github.com/SSSD/sssd/pull/449#issuecomment-344568901 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req pbrezina commented: """ @jhrozek At this point, I think it will be better to wait for your cache req patches to come in. I think this check can be done during the phase where you check if the id is part of the domain. If it is outside the domain range, we can say it is not part of this domain. """ See the full comment at https://github.com/SSSD/sssd/pull/449#issuecomment-344213078 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req jhrozek commented: """ I'm sorry, but this patch is incorrect. As I wrote in the ticket, you want to check the input id (data->id inside cache_req) against the domain min/max limits inside the lookup_fn function of plugins that search by ID. My initial idea was to return a special error code (ERR_UID_OUTSIDE_RANGE?) so that the lookup wouldn't even continue. But this would only handle requests where we actually search the cache. Alternatively, we could add another plugin method. Not sure which way is more preferred, what do you think, @pbrezina """ See the full comment at https://github.com/SSSD/sssd/pull/449#issuecomment-344212156 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req fidencio commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/449#issuecomment-344157080 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/449#issuecomment-344152517 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/449#issuecomment-344152516 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
