[SSSD] [sssd PR#495][comment] DESKPROFILE: Add checks for user and host category
URL: https://github.com/SSSD/sssd/pull/495 Title: #495: DESKPROFILE: Add checks for user and host category jhrozek commented: """ * master: b72e444bc1cd2fe8d9617f09b446c678d4684fff """ See the full comment at https://github.com/SSSD/sssd/pull/495#issuecomment-363135559 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#495][comment] DESKPROFILE: Add checks for user and host category
URL: https://github.com/SSSD/sssd/pull/495 Title: #495: DESKPROFILE: Add checks for user and host category jhrozek commented: """ OK, Coverity came clean, thank you. """ See the full comment at https://github.com/SSSD/sssd/pull/495#issuecomment-363103608 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#495][comment] DESKPROFILE: Add checks for user and host category
URL: https://github.com/SSSD/sssd/pull/495
Title: #495: DESKPROFILE: Add checks for user and host category
fidencio commented:
"""
Here are the changes introduced in the last patch:
```
[ffidenci@pessoa x86_64]$ git diff
diff --git a/src/providers/ipa/ipa_deskprofile_rules_util.c
b/src/providers/ipa/ipa_deskprofile_rules_util.c
index ffcb5c846..01b7d0527 100644
--- a/src/providers/ipa/ipa_deskprofile_rules_util.c
+++ b/src/providers/ipa/ipa_deskprofile_rules_util.c
@@ -779,7 +779,22 @@ ipa_deskprofile_rules_save_rule_to_disk(
if (usercat != NULL && strcasecmp(usercat, "all") == 0) {
user_prio = talloc_strdup(tmp_ctx, rule_prio);
+if (user_prio == NULL) {
+DEBUG(SSSDBG_CRIT_FAILURE,
+ "Failed to allocate the user priority "
+ "when user category is \"all\"\n");
+ret = ENOMEM;
+goto done;
+}
+
group_prio = talloc_strdup(tmp_ctx, rule_prio);
+if (group_prio == NULL) {
+DEBUG(SSSDBG_CRIT_FAILURE,
+ "Failed to allocate the group priority "
+ "when user category is \"all\"\n");
+ret = ENOMEM;
+goto done;
+}
} else {
ret = ipa_deskprofile_rule_check_memberuser(tmp_ctx, domain, rule,
rule_name, rule_prio,
@@ -795,7 +810,22 @@ ipa_deskprofile_rules_save_rule_to_disk(
if (hostcat != NULL && strcasecmp(hostcat, "all") == 0) {
host_prio = talloc_strdup(tmp_ctx, rule_prio);
+if (host_prio == NULL) {
+DEBUG(SSSDBG_CRIT_FAILURE,
+ "Failed to allocate the host priority "
+ "when host category is \"all\"\n");
+ret = ENOMEM;
+goto done;
+}
+
hostgroup_prio = talloc_strdup(tmp_ctx, rule_prio);
+if (hostgroup_prio == NULL) {
+DEBUG(SSSDBG_CRIT_FAILURE,
+ "Failed to allocate the hostgroup priority "
+ "when host category is \"all\"\n");
+ret = ENOMEM;
+goto done;
+}
} else {
ret = ipa_deskprofile_rule_check_memberhost(tmp_ctx, domain, rule,
rule_name, rule_prio,
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/495#issuecomment-363092251
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#495][comment] DESKPROFILE: Add checks for user and host category
URL: https://github.com/SSSD/sssd/pull/495 Title: #495: DESKPROFILE: Add checks for user and host category jhrozek commented: """ Gah, no, sorry, I found another nitpick :-( """ See the full comment at https://github.com/SSSD/sssd/pull/495#issuecomment-363088593 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#495][comment] DESKPROFILE: Add checks for user and host category
URL: https://github.com/SSSD/sssd/pull/495 Title: #495: DESKPROFILE: Add checks for user and host category jhrozek commented: """ I have no more requests, thank you, ack. """ See the full comment at https://github.com/SSSD/sssd/pull/495#issuecomment-363088101 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#495][comment] DESKPROFILE: Add checks for user and host category
URL: https://github.com/SSSD/sssd/pull/495 Title: #495: DESKPROFILE: Add checks for user and host category fidencio commented: """ Patch has been updated, thanks for the review. """ See the full comment at https://github.com/SSSD/sssd/pull/495#issuecomment-362997910 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#495][comment] DESKPROFILE: Add checks for user and host category
URL: https://github.com/SSSD/sssd/pull/495 Title: #495: DESKPROFILE: Add checks for user and host category fidencio commented: """ Steps to reproduce the issue: 1. git clone https://github.com/fidencio/fleet-commander-vagans 2. In the project's folder do: cd fleet-commander; vagrant up 3. Once the VMs are provisioned, access cockpit: https://master.ipa.example:9090/ 4. Click in the "FleetCommander" tab 5. Close the windows that will open 6. Click in "Add Profile" 7. Add a profile without filling out Hosts and Hostgroups 8. From the fleet-commander folder, do: vagrant ssh ipaclient 8.1: ssh to the machine using admin's user: ssh -l admin localhost 8.2: Close the admin session 8.3 A root, take a look at journalctl -xe and a message about a crash will be seen. With the patch, 8.3 won't happen and your profile will be downloaded to /var/lib/deskprofile/ipa.example/admin/ NOTE: If your way to test it is through a fedpkg build, be aware of: https://bugzilla.redhat.com/show_bug.cgi?id=1536854 """ See the full comment at https://github.com/SSSD/sssd/pull/495#issuecomment-359338285 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#495][comment] DESKPROFILE: Add checks for user and host category
URL: https://github.com/SSSD/sssd/pull/495 Title: #495: DESKPROFILE: Add checks for user and host category fidencio commented: """ Steps to reproduce the issue: 1. git clone https://github.com/fidencio/fleet-commander-vagans 2. In the project's folder do: cd fleet-commander; vagrant up 3. Once the VMs are provisioned, access cockpit: https://master.ipa.example:9090/ 4. Click in the "FleetCommander" tab 5. Close the windows that will open 6. Click in "Add Profile" 7. Add a profile without filling out Hosts and Hostgroups 8. From the fleet-commander folder, do: vagrant ssh ipaclient 8.1: ssh to the machine using admin's user: ssh -l admin localhost 8.2: Close the admin session 8.3 A root, take a look at journalctl -xe and a message about a crash will be seen. With the patch, 10.3 won't happen and your profile will be downloaded to /var/lib/deskprofile/ipa.example/admin/ NOTE: If your way to test it is through a fedpkg build, be aware of: https://bugzilla.redhat.com/show_bug.cgi?id=1536854 """ See the full comment at https://github.com/SSSD/sssd/pull/495#issuecomment-359338285 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#495][comment] DESKPROFILE: Add checks for user and host category
URL: https://github.com/SSSD/sssd/pull/495 Title: #495: DESKPROFILE: Add checks for user and host category fidencio commented: """ Steps to reproduce the issue: 1. git clone https://github.com/fidencio/fleet-commander-vagans 2. In the project's folder do: cd fleet-commander; vagrant up 3. Once the VMs are provisioned, access cockpit: https://master.ipa.example:9090/ 4. Click in the "FleetCommander" tab 5. Close the windows that will open 6. Click in "Add Profile" 7. Add a profile without filling out Hosts and Hostgroups 8. Click in "Add Profile" 9. Add a profile without filling out Users and Groups 10. From the fleet-commander folder, do: vagrant ssh ipaclient 10.1: ssh to the machine using admin's user: ssh -l admin localhost 10.2: Close the admin session 10.3 A root, take a look at journalctl -xe and a message about a crash will be seen. With the patch, 10.3 won't happen and your profiles will be downloaded to /var/lib/deskprofile/ipa.example/admin/ NOTE: If your way to test it is through a fedpkg build, be aware of: https://bugzilla.redhat.com/show_bug.cgi?id=1536854 """ See the full comment at https://github.com/SSSD/sssd/pull/495#issuecomment-359338285 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#495][comment] DESKPROFILE: Add checks for user and host category
URL: https://github.com/SSSD/sssd/pull/495 Title: #495: DESKPROFILE: Add checks for user and host category fidencio commented: """ Steps to reproduce the issue:Steps to Reproduce: 1. git clone https://github.com/fidencio/fleet-commander-vagans 2. In the project's folder do: cd fleet-commander; vagrant up 3. Once the VMs are provisioned, access cockpit: https://master.ipa.example:9090/ 4. Click in the "FleetCommander" tab 5. Close the windows that will open 6. Click in "Add Profile" 7. Add a profile without filling out Hosts and Hostgroups 8. Click in "Add Profile" 9. Add a profile without filling out Users and Groups 10. From the fleet-commander folder, do: vagrant ssh ipaclient 10.1: ssh to the machine using admin's user: ssh -l admin localhost 10.2: Close the admin session 10.3 A root, take a look at journalctl -xe and a message about a crash will be seen. With the patch, 10.3 won't happen and your profiles will be downloaded to /var/lib/deskprofile/ipa.example/admin/ NOTE: If your way to test it is through a fedpkg build, be aware of: https://bugzilla.redhat.com/show_bug.cgi?id=1536854 """ See the full comment at https://github.com/SSSD/sssd/pull/495#issuecomment-359338285 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
