[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ master: * 3cf0aa1904fe791eed414bfb532c91a79ea2df9c * 0c0b9a3323dfc7988a58d4b67e9c94d0567ee82c * 76b79f5a816152d5aa07618b7825fb4926d15f1e * 0a539e693254275248ff

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ LGTM :-) I'll wait with pushing till after successful run in centos ci """ See the full comment at https://github.com/SSSD/sssd/pull/496#issuecomment-3676625

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ > Do you think that for completeness and easier reference it would be ok if I > push your patches to this PR and the 1.14 ones to PR#497? Feel free to push t

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 sumit-bose commented: """ @lslebodn, thank you, patches are looking good. ACK. Do you think that for completeness and easier reference it would be ok if I push your patches to this

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ And here are patches for 1.13 https://github.com/lslebodn/sssd/tree/cve_backport_1.13 @sumit-bose could you check them? """ See the full comment at https://

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ I added in-line comment. """ See the full comment at https://github.com/SSSD/sssd/pull/496#issuecomment-365637557 ___

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 jhrozek commented: """ I put it on my todo list, but only after some authselect reviews, so if anyone beats me to the review, I won't be mad. """ See the full comment at https://gi

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 fidencio commented: """ @jhrozek, @pbrezina, @mzidek-rh ... may I ask you guys for a review of this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/496#issueco

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 fidencio commented: """ ping! I either need a second reviewer here or a word saying that just my review is enough! """ See the full comment at https://github.com/SSSD/sssd/pull/496

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 fidencio commented: """ @lslebodn, did you have the chance to review this PR? """ See the full comment at https://github.com/SSSD/sssd/pull/496#issuecomment-364063071 __

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 fidencio commented: """ So, I have checked and unless I missed something the patch is good to go. As @lslebodn did the review of the original patch (for master branch) and he also h

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 fidencio commented: """ > The branch sssd-1-13 is quite diverged from master branch. Therefore it would > be good to check all functions which use ldb_search. I did that for master

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ The branch sssd-1-13 is quite diverged from master branch. Therefore it would be good to check all functions which use `ldb_search`. I did that for master br

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ > CI has passed apart from some issue running mock-build on rawhide: > http://vm-031.${abc}/logs/job/83/25/summary.html > > May the failure there be related t

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 fidencio commented: """ CI has passed apart from some issue running mock-build on rawhide: http://vm-031.${abc}/logs/job/83/25/summary.html May the failure there be related to the f

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 fidencio commented: """ Both the patch and the test that is together work as expected! """ See the full comment at https://github.com/SSSD/sssd/pull/496#issuecomment-361210174 _