URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
master:
* 6dc1de9781ab211a43d24cbaed7969d98abc1cc1
* fd17e0925dbcafedb878ddf828a37743c115c9dd
* 8f83feea4586a8fcf4365e0d22e0a16740424cc2
* 41454a64c714e984
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
Thank you for review.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/503#issuecomment-365956635
__
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
sumit-bose commented:
"""
ok, I have no further comments and CI passes as well
http://vm-031.../logs/job/84/09/summary.html (with the unrelated rawhide
exception), so ACK.
"""
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
sumit-bose commented:
"""
The latest version looks good. I'll run some local and CI test before giving
ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/503#is
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
> @lslebodn, I would it call just 'flags' as e.g. open(2).
What about latest version?
It is be backward compatible including negative test cases. But it a
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
> @lslebodn, I would it call just 'flags' as e.g. open(2).
It does not sounds to me very pythonic. I'll ask python gurus.
"""
See the full comment at
ht
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
sumit-bose commented:
"""
@lslebodn, I would it call just 'flags' as e.g. open(2).
"""
See the full comment at
https://github.com/SSSD/sssd/pull/503#issuecomment-360410544
_
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
On (24/01/18 19:44), sumit-bose wrote:
>I wonder if it is really needed to add murmurhash3_bin. Wouldn't it be
>possible to add an optional flags argument
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
sumit-bose commented:
"""
CI passes as well with the current exception of Debian
http://vm-031.../logs/job/83/10/summary.html.
"""
See the full comment at
https://github.com/SS
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
sumit-bose commented:
"""
Thank you for the test. It works well and fails is the fix is removed.
I agree with removing memchr() from the client code as well.
I wonder if it is r
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
You can revert 4382047 for testing purposes to ensure that test fails
"""
See the full comment at
https://github.com/SSSD/sssd/pull/503#issuecomment-3601
11 matches
Mail list logo
