[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-22 Thread lslebodn
  URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user

lslebodn commented:
"""
master:
* 5150fbdc429ee9ed52e80e5f133ddb48c5b79914
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/516#issuecomment-367678121
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-22 Thread jhrozek
  URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user

jhrozek commented:
"""
I think it's OK to add the Accepted label since the centos CI is passing now.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/516#issuecomment-367660685
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
  URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user

lslebodn commented:
"""
Justin,
thank you for review
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/516#issuecomment-367457190
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
  URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user

lslebodn commented:
"""
I tried to figure out why centos CI is failing and I noticed that xml element 
`note` is not allowed in DTD

```
/usr/bin/xmllint --catalogs --postvalid --nonet --noent --xinclude --noout 
../../../sssd/src/man/sssd.conf.5.xml
../../../sssd/src/man/sssd.conf.5.xml:2464: element note: validity error : 
Element note content does not follow the DTD, expecting (title? , (calloutlist 
| glosslist | bibliolist | itemizedlist | orderedlist | segmentedlist | 
simplelist | variablelist | literallayout | programlisting | programlistingco | 
screen | screenco | screenshot | synopsis | cmdsynopsis | funcsynopsis | 
classsynopsis | fieldsynopsis | constructorsynopsis | destructorsynopsis | 
methodsynopsis | formalpara | para | simpara | address | blockquote | graphic | 
graphicco | mediaobject | mediaobjectco | informalequation | informalexample | 
informalfigure | informaltable | equation | example | figure | table | 
procedure | sidebar | anchor | bridgehead | remark | indexterm | beginpage)+), 
got (CDATA)
Document ../../../sssd/src/man/sssd.conf.5.xml does not validate
make[2]: *** [Makefile:938: sssd.conf.5] Error 3
```

I can see that on other places in sssd.conf.5.xml we use either
```

NOTE: Sudo rules are
```

or NOTE without emphasis
```

NOTE: The filter_groups option doesn't affect
```

I'm sorry that I did not notice that earlier.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/516#issuecomment-367459699
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread justin-stephenson
  URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user

justin-stephenson commented:
"""
Okay from my side.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/516#issuecomment-367351699
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
  URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user

lslebodn commented:
"""
LGTM from content point of view.

@justin-stephenson could you check this PR as well?
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/516#issuecomment-367288934
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-20 Thread fidencio
  URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user

fidencio commented:
"""
retest this please
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/516#issuecomment-366967908
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-19 Thread fidencio
  URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user

fidencio commented:
"""
Changes done according to your suggestion.
Thanks for the review and I'm removing the "Changes Requested" label.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/516#issuecomment-366889568
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-19 Thread fidencio
  URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user

fidencio commented:
"""
Changes done according to your suggestion.
Thanks for the review and I'm removing the "Changes Requested" label.u
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/516#issuecomment-366889568
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org