URL: https://github.com/SSSD/sssd/pull/52
Author: lslebodn
 Title: #52: CI: Remove dlopen-test from valgrind blacklist
Action: opened

PR body:
"""
Dlopen test was added to blacklist due to following reason:
> Disable running dlopen-tests under Valgrind as their use of dlclose
> makes Valgrind drop symbols and produce meaningless backtraces, which
> cannot be matched with specific suppressions.

It's true that dlclose makes meaningless backtraces but it can
catch real leaks.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/52/head:pr52
git checkout pr52
From 61ca8f93032119cf975b1898fe9d38fdff70c1d1 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lsleb...@redhat.com>
Date: Thu, 29 Sep 2016 13:45:04 +0200
Subject: [PATCH] CI: Remove dlopen-test from valgrind blacklist

Dlopen test was added to blacklist due to following reason:
> Disable running dlopen-tests under Valgrind as their use of dlclose
> makes Valgrind drop symbols and produce meaningless backtraces, which
> cannot be matched with specific suppressions.

It's true that dlclose makes meaningless backtraces but it can
catch real leaks.
---
 contrib/ci/run | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/contrib/ci/run b/contrib/ci/run
index f96476f..6b5c6b8 100755
--- a/contrib/ci/run
+++ b/contrib/ci/run
@@ -187,8 +187,7 @@ function build_debug()
 {
     # Extended glob pattern matching tests to run under Valgrind.
     # NOTE: The particular pattern below is inverted
-    declare -r valgrind_test_pattern="\
-        !(*.py|*/dlopen-tests|*/whitespace_test|*/double_semicolon_test)"
+    declare -r valgrind_test_pattern="!(*.py|*/whitespace_test|*/double_semicolon_test)"
     export CFLAGS="$DEBUG_CFLAGS"
     declare test_dir
     declare test_dir_distcheck
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to