URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
fidencio commented:
"""
master:
efae950
9f68324
c1fbc6b
2124275
cc79227
d91661e
4759a48
f28d995
"""
See the full comment at
https://github.com/SSSD/sssd/pull
URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
jhrozek commented:
"""
CI: http://vm-031.$ABC/logs/job/90/34/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/579#issuecomment-396587573
__
URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
jhrozek commented:
"""
I think the commit that runs the offline callbacks is correct. The kdcinfo
files are now removed. The code looks OK, Coverity is not complaining so I w
URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
jhrozek commented:
"""
Thank you, I ran a quick test and I no longer see the crashes. I will continue
with the full review later, though.
"""
See the full comment at
https:
URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
jhrozek commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/579#issuecomment-395842120
__
URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
sumit-bose commented:
"""
I hope the latest version helps to fix/avoid the crash by making sure the
offline callbacks are only run once (as the online callbacks already are).
URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
jhrozek commented:
"""
Please let me know if you're too busy with adcli or realmd work and would
prefer me to investigate, for now, I'm just adding Changes Requested and will
URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
jhrozek commented:
"""
I think the general intention of the patch is good and I like destructors being
used in general, but there seems to be a bug. When I send SIGUSR1 to ss
URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
sumit-bose commented:
"""
Hi Jakub, thank you for the review I added a new patch which make the removal
of the krb5info files more flexible and takes care of the removal of t
URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
jhrozek commented:
"""
The only issue I found is that the kdcinfo files are note removed when sssd
exits.
One other thing we might consider is that the krb5_use_kdcinfo opti
URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
fidencio commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/579#issuecomment-392458475
_
URL: https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
jhrozek commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/579#issuecomment-392011228
__
12 matches
Mail list logo
