[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ master: f0b4d48 c07469f 0052abe """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-404415717

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched sumit-bose commented: """ Ok, test went well, Coverity and CI passed, ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-404280260

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched sumit-bose commented: """ Thank you, I'll run some test before giving ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-404149738

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ After a discussion on IRC we've agreed that would be better to have the tests using cmocka instead of check framework. Thus, the patchset has

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, I've updated the patchset. """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403964058

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ And make-check-valgrind is failing. Let me add the "Changes Requested" label again. """ See the full comment at

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, I've updated the patchset. Changes since last version: - rebased atop of git master; - making use of is_files_provider() call that

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched sumit-bose commented: """ @fidencio, ah, I only checked the current code because I thought I've already seen some macro/call for this. Thanks for adding the call.

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, I've done that as part of https://github.com/SSSD/sssd/pull/607. Take a look at

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, btw, I've updated my other patch to also use strcasecmp() instead of strcmp(), thanks. """ See the full comment at

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, I've done that as part of https://github.com/SSSD/sssd/pull/607. Take a look at

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ retest this, please """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403456101

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched sumit-bose commented: """ Not strictly related but in confdb.c strcasecmp() is used to check for the files provider. Maybe it would make sense to add a macro like e.g.