[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ master: f0b4d48 c07469f 0052abe """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-404415717 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/FJDMFVWQBXPIA7YUCPPPFG4UXGJD7XGT/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched sumit-bose commented: """ Ok, test went well, Coverity and CI passed, ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-404280260 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/NCAVDH63PYX6AZRFDEJHGVAOZXSTYGNK/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched sumit-bose commented: """ Thank you, I'll run some test before giving ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-404149738 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/DUUN7UBSJON7YZUX677VRY2PKIVAOZAG/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ After a discussion on IRC we've agreed that would be better to have the tests using cmocka instead of check framework. Thus, the patchset has been updated again. """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-404146273 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/V67OJVZUAXT6MO55YXQPVM33WLLERNHY/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, I've updated the patchset. """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403964058 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/S4UM6BYS3PQXVJMQXAJLGO3MOQNWVUG4/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ And make-check-valgrind is failing. Let me add the "Changes Requested" label again. """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403839339 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/SON3HM2GKTEIDNVJPTHOZ3D7L74GAQEV/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, I've updated the patchset. Changes since last version: - rebased atop of git master; - making use of is_files_provider() call that was pushed Today; - wrote tests for the changes in this patchset; - wrote tests for another issue fixed some time ago (https://pagure.io/SSSD/sssd/issue/3743); """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403808818 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/PPNXJNIKR5BBUDOBDYVEBKY2N3HT5JS5/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched sumit-bose commented: """ @fidencio, ah, I only checked the current code because I thought I've already seen some macro/call for this. Thanks for adding the call. Given the state of #607 I'd like to suggest to add it here rightaway. Since cache_req_domain_new_list_from_string_list() now not only special cases the files provider with respect to the fully qualified names but with the order as well, I think it would be worth to add a unit test for this call or for its caller cache_req_domain_new_list_from_domain_resolution_order(). What do you think? """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403477934 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/XVJU75HABMCN5CREMAWEXKIWL4B3KURB/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, I've done that as part of https://github.com/SSSD/sssd/pull/607. Take a look at https://github.com/SSSD/sssd/pull/607/commits/1e3e829056436783c0e85b145d2694b592b3b879 The plan is to rebase this one atop of the 607 (or vice-versa, depending on what will be acked first) """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403456495 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/MBSZCW2TWCYGT3QNG63F22O5G74CKRC4/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, btw, I've updated my other patch to also use strcasecmp() instead of strcmp(), thanks. """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403460395 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/L4EAHQDKLMGE37AY32MEUFX4LHORGQK2/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, I've done that as part of https://github.com/SSSD/sssd/pull/607. Take a look at https://github.com/SSSD/sssd/pull/607/commits/768039bd1adda130b550f9e405bac6d320858662 ... The plan is to rebase this one atop of the 607 (or vice-versa, depending on what will be acked first) """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403456495 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/ZJSD6OU7NCCSJF25ZTAI2E3UOHR5L6CM/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ retest this, please """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403456101 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/FERENKA22ICAANZP6762DVVR3OF4CWP7/
[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched sumit-bose commented: """ Not strictly related but in confdb.c strcasecmp() is used to check for the files provider. Maybe it would make sense to add a macro like e.g. IS_FILES_PROVIDER() (and fix the other occurrences in a different PR) to have a consistent check? """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403448353 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/G2QKLCTDWDSHSYS3AO7FETTLGIAMNE6S/
