URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
master:
4937f2c
"""
See the full comment at
https://github.com/SSSD/sssd/pull/614#issuecomment-411796606
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
We agreed on merging the PR during our team meeting.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
I see. We'll have a phone call Today and discuss this patch within SSSD team.
Although we don't have nor follow any "governance", I do
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
I see. We'll have a phone call Today and discuss this patch within SSSD team.
Although we don't have nor follow any "governance", I do
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
asheplyakov commented:
"""
@fidencio
> would you have a cache dump, logs or even a machine that you could give us
> access
Unfortunately no. That was a client's
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
Although the patch looks good, after a conversation with @jhrozek ... I have my
mind made that we may be just papering over a more critical
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
jhrozek commented:
"""
I'm not against this patch (I just had no time so far to do any test) but my
primary question is why do we have the incomplete groups in the
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
Adding the "Accepted" label.
I'll push on Wednesday, in order to give @jhrozek some time to answer as well.
Thanks a lot for your
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
asheplyakov commented:
"""
@fidencio: I'm OK with the proposed commit message change
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
CI results were okay, apart from the known issues.
@asheplyakov, there's one nitpick about the patch that I'd like to ask your
permission to
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
@asheplyakov, thanks for the contribution.
This patch does look correct to me. I'll just fire a run of our internal CI
(for the sake of the
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/614#issuecomment-403871241
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/614#issuecomment-403867722
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/614#issuecomment-403867723
14 matches
Mail list logo
